From 052a9fc250dd3eefdc6a7834fb0bfbc1654db22c Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Sat, 3 Oct 2026 16:13:46 +0200 Subject: [PATCH 01/16] Hide native Windows 11 Start button when using a replacement --- Src/StartMenu/StartMenuDLL/StartMenuDLL.cpp | 5 + .../StartMenuDLL/StartMenuDLL.vcxproj | 2 + .../StartMenuDLL/StartMenuDLL.vcxproj.filters | 6 + .../StartMenuDLL/Win11StartButton.cpp | 745 ++++++++++++++++++ Src/StartMenu/StartMenuDLL/Win11StartButton.h | 8 + 5 files changed, 766 insertions(+) create mode 100644 Src/StartMenu/StartMenuDLL/Win11StartButton.cpp create mode 100644 Src/StartMenu/StartMenuDLL/Win11StartButton.h diff --git a/Src/StartMenu/StartMenuDLL/StartMenuDLL.cpp b/Src/StartMenu/StartMenuDLL/StartMenuDLL.cpp index 3a6b18770..088569e08 100644 --- a/Src/StartMenu/StartMenuDLL/StartMenuDLL.cpp +++ b/Src/StartMenu/StartMenuDLL/StartMenuDLL.cpp @@ -14,6 +14,7 @@ #include "ResourceHelper.h" #include "LogManager.h" #include "TouchHelper.h" +#include "Win11StartButton.h" #include "IatHookHelper.h" #include "dllmain.h" #include @@ -2643,6 +2644,7 @@ void UpdateTaskBars( TUpdateTaskbar update ) InvalidateRect(taskBar.taskBar,NULL,TRUE); PostMessage(taskBar.taskBar,WM_THEMECHANGED,0,0); } + UpdateWin11StartButtonMonitor(); } /////////////////////////////////////////////////////////////////////////////// @@ -3227,6 +3229,7 @@ if (!g_bTrimHooks) UpdateTaskBars(TASKBAR_RECREATE_BUTTONS); UpdateTaskBars(TASKBAR_UPDATE_TEXTURE); + StartWin11StartButtonMonitor(); } static void RecreateStartButton( size_t taskbarId ) @@ -3288,6 +3291,8 @@ static DWORD WINAPI ExitThreadProc( void *param ) static void CleanStartMenuDLL( void ) { + StopWin11StartButtonMonitor(); + ClearIatHook(g_DwmpBTRHook); g_DwmpBTRHook=NULL; ClearIatHook(g_DwmpTWWRHook); diff --git a/Src/StartMenu/StartMenuDLL/StartMenuDLL.vcxproj b/Src/StartMenu/StartMenuDLL/StartMenuDLL.vcxproj index 0412e588c..416c5a52f 100644 --- a/Src/StartMenu/StartMenuDLL/StartMenuDLL.vcxproj +++ b/Src/StartMenu/StartMenuDLL/StartMenuDLL.vcxproj @@ -89,6 +89,7 @@ Create + @@ -110,6 +111,7 @@ + diff --git a/Src/StartMenu/StartMenuDLL/StartMenuDLL.vcxproj.filters b/Src/StartMenu/StartMenuDLL/StartMenuDLL.vcxproj.filters index fc2bd40cb..bfb839860 100644 --- a/Src/StartMenu/StartMenuDLL/StartMenuDLL.vcxproj.filters +++ b/Src/StartMenu/StartMenuDLL/StartMenuDLL.vcxproj.filters @@ -72,6 +72,9 @@ Source Files + + Source Files + @@ -128,6 +131,9 @@ Header Files + + Header Files + Resource Files diff --git a/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp new file mode 100644 index 000000000..1bb94cb35 --- /dev/null +++ b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp @@ -0,0 +1,745 @@ +// Windows 11 native Start button suppression. +// +// Open-Shell's replacement button is a separate layered window. Windows 11 +// renders its own Start button in XAML, so the old HWND hiding logic cannot +// remove the native glyph. This file uses the public XAML diagnostics API to +// suppress only the native Start glyph and its hit target. The XAML element is +// left in layout, so centered taskbar positioning remains owned by Windows. + +#include "stdafx.h" +#include "Win11StartButton.h" +#include "Settings.h" +#include "LogManager.h" +#include "ResourceHelper.h" + +#include +#include +#include +#include +#include + +static const GUID CLSID_OpenShellStartButtonTap = +{ 0x7d15741f, 0x2f3b, 0x4971, { 0xb8, 0x91, 0x6a, 0x5d, 0x42, 0xd7, 0x1a, 0x34 } }; + +static const UINT WM_OS_STARTBUTTON_APPLY = WM_APP + 0x35B; + +static volatile LONG g_StartButtonActive = 0; +static volatile LONG g_ConnectStarted = 0; + +static HMODULE GetThisModule( void ) +{ + HMODULE module = NULL; + GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS | GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT, + (LPCTSTR)&GetThisModule, &module); + return module; +} + +struct StartElement +{ + InstanceHandle parent; + CString type; + CString name; + bool visibilityOverride; + bool hitTestOverride; + + StartElement( void ) + { + parent = 0; + visibilityOverride = false; + hitTestOverride = false; + } +}; + +class CWin11StartButtonTap; +static CWin11StartButtonTap *g_Tap = NULL; +static SRWLOCK g_TapLock = SRWLOCK_INIT; + +static bool ContainsText( const CString &text, const wchar_t *part ) +{ + return text.Find(part) >= 0; +} + +static bool IsStartControl( const StartElement &element ) +{ + if (!ContainsText(element.type, L"ExperienceToggleButton")) + return false; + return element.name == L"LaunchListButton" || element.name == L"StartButton"; +} + +static bool IsStartGlyph( const StartElement &element ) +{ + if (element.name == L"Icon") + return true; + if (ContainsText(element.type, L"AnimatedVisualPlayer") || ContainsText(element.type, L"AepAnimatedIcon")) + return true; + if (ContainsText(element.type, L"FontIcon") || ContainsText(element.type, L"PathIcon") || + ContainsText(element.type, L"ImageIcon") || ContainsText(element.type, L"BitmapIcon") || + ContainsText(element.type, L"SymbolIcon")) + return true; + return false; +} + +class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCallback2 +{ +public: + CWin11StartButtonTap( void ) + { + m_Refs = 1; + m_Advised = false; + m_Dispatch = NULL; + m_PrimaryStart = 0; + InitializeCriticalSection(&m_Lock); + } + + ~CWin11StartButtonTap( void ) + { + if (m_Visual && m_Advised) + m_Visual->UnadviseVisualTreeChange(static_cast(this)); + if (m_Dispatch && GetWindowThreadProcessId(m_Dispatch, NULL) == GetCurrentThreadId()) + DestroyWindow(m_Dispatch); + + AcquireSRWLockExclusive(&g_TapLock); + if (g_Tap == this) + g_Tap = NULL; + ReleaseSRWLockExclusive(&g_TapLock); + + InterlockedExchange(&g_ConnectStarted, 0); + DeleteCriticalSection(&m_Lock); + } + + STDMETHODIMP QueryInterface( REFIID riid, void **ppv ) + { + if (!ppv) + return E_POINTER; + *ppv = NULL; + + if (riid == IID_IUnknown || riid == IID_IObjectWithSite) + *ppv = static_cast(this); + else if (riid == __uuidof(IVisualTreeServiceCallback) || riid == __uuidof(IVisualTreeServiceCallback2)) + *ppv = static_cast(this); + else + return E_NOINTERFACE; + + AddRef(); + return S_OK; + } + + STDMETHODIMP_(ULONG) AddRef( void ) + { + return (ULONG)InterlockedIncrement(&m_Refs); + } + + STDMETHODIMP_(ULONG) Release( void ) + { + LONG refs = InterlockedDecrement(&m_Refs); + if (!refs) + delete this; + return (ULONG)refs; + } + + STDMETHODIMP SetSite( IUnknown *site ) + { + if (m_Visual && m_Advised) + { + ApplyState(false); + m_Visual->UnadviseVisualTreeChange(static_cast(this)); + m_Advised = false; + } + m_Visual.Release(); + m_Site.Release(); + + if (!site) + { + AcquireSRWLockExclusive(&g_TapLock); + if (g_Tap == this) + g_Tap = NULL; + ReleaseSRWLockExclusive(&g_TapLock); + InterlockedExchange(&g_ConnectStarted, 0); + return S_OK; + } + + EnterCriticalSection(&m_Lock); + m_Elements.clear(); + m_PrimaryStart = 0; + LeaveCriticalSection(&m_Lock); + + m_Site = site; + HRESULT hr = site->QueryInterface(__uuidof(IVisualTreeService), (void**)&m_Visual); + if (FAILED(hr) || !m_Visual) + return hr; + + if (!CreateDispatchWindow()) + return HRESULT_FROM_WIN32(GetLastError()); + + AcquireSRWLockExclusive(&g_TapLock); + g_Tap = this; + ReleaseSRWLockExclusive(&g_TapLock); + + // Advise replays the existing tree. OnVisualTreeChange only records + // element handles; all property access is dispatched afterwards. + hr = m_Visual->AdviseVisualTreeChange(static_cast(this)); + if (SUCCEEDED(hr)) + { + m_Advised = true; + RequestApply(false); + } + LogToFile(STARTUP_LOG, L"Win11StartButton: visual tree advise 0x%08X", hr); + return hr; + } + + STDMETHODIMP GetSite( REFIID riid, void **ppv ) + { + if (!ppv) + return E_POINTER; + *ppv = NULL; + if (!m_Site) + return E_FAIL; + return m_Site->QueryInterface(riid, ppv); + } + + STDMETHODIMP OnVisualTreeChange( ParentChildRelation relation, VisualElement element, VisualMutationType mutationType ) + { + bool interesting = false; + + EnterCriticalSection(&m_Lock); + if (mutationType == Remove) + { + auto it = m_Elements.find(element.Handle); + if (it != m_Elements.end()) + { + interesting = it->second.visibilityOverride || it->second.hitTestOverride || IsStartControl(it->second); + bool wasPrimary = element.Handle == m_PrimaryStart; + m_Elements.erase(it); + if (wasPrimary) + { + m_PrimaryStart = 0; + for (auto candidate = m_Elements.begin(); candidate != m_Elements.end(); ++candidate) + { + if (IsStartControl(candidate->second)) + { + m_PrimaryStart = candidate->first; + break; + } + } + } + } + } + else if (mutationType == Add) + { + StartElement record; + record.parent = relation.Parent; + record.type = element.Type ? element.Type : L""; + record.name = element.Name ? element.Name : L""; + + auto previous = m_Elements.find(element.Handle); + if (previous != m_Elements.end()) + { + record.visibilityOverride = previous->second.visibilityOverride; + record.hitTestOverride = previous->second.hitTestOverride; + } + m_Elements[element.Handle] = record; + if (IsStartControl(record) && !m_PrimaryStart) + m_PrimaryStart = element.Handle; + + interesting = IsStartControl(record) || IsStartGlyph(record) || IsUnderStartButtonLocked(record.parent); + } + LeaveCriticalSection(&m_Lock); + + if (interesting) + RequestApply(false); + return S_OK; + } + + STDMETHODIMP OnElementStateChanged( InstanceHandle, VisualElementState, LPCWSTR ) + { + return S_OK; + } + + void RequestApply( bool synchronous ) + { + if (!m_Dispatch) + return; + if (synchronous) + SendMessage(m_Dispatch, WM_OS_STARTBUTTON_APPLY, 0, 0); + else + PostMessage(m_Dispatch, WM_OS_STARTBUTTON_APPLY, 0, 0); + } + +private: + static LRESULT CALLBACK DispatchProc( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam ) + { + CWin11StartButtonTap *tap = (CWin11StartButtonTap*)GetWindowLongPtr(hwnd, GWLP_USERDATA); + if (msg == WM_NCCREATE) + { + CREATESTRUCT *create = (CREATESTRUCT*)lParam; + tap = (CWin11StartButtonTap*)create->lpCreateParams; + SetWindowLongPtr(hwnd, GWLP_USERDATA, (LONG_PTR)tap); + } + if (msg == WM_OS_STARTBUTTON_APPLY && tap) + { + bool enabled = InterlockedCompareExchange(&g_StartButtonActive, 0, 0) != 0 && + GetSettingBool(L"EnableStartButton"); + tap->ApplyState(enabled); + return 0; + } + return DefWindowProc(hwnd, msg, wParam, lParam); + } + + bool CreateDispatchWindow( void ) + { + if (m_Dispatch) + return true; + + static const wchar_t CLASS_NAME[] = L"OpenShell.Win11StartButtonTap"; + WNDCLASS wc = {}; + HMODULE module = GetThisModule(); + if (!module) + return false; + + wc.lpfnWndProc = DispatchProc; + wc.hInstance = module; + wc.lpszClassName = CLASS_NAME; + if (!RegisterClass(&wc) && GetLastError() != ERROR_CLASS_ALREADY_EXISTS) + return false; + + m_Dispatch = CreateWindowEx(0, CLASS_NAME, L"", 0, 0, 0, 0, 0, + HWND_MESSAGE, NULL, module, this); + return m_Dispatch != NULL; + } + + bool IsUnderStartButtonLocked( InstanceHandle parent ) const + { + for (int depth = 0; depth < 24 && parent; depth++) + { + auto it = m_Elements.find(parent); + if (it == m_Elements.end()) + break; + if (IsStartControl(it->second)) + return true; + parent = it->second.parent; + } + return false; + } + + InstanceHandle GetStartAncestor( InstanceHandle handle ) + { + InstanceHandle result = 0; + EnterCriticalSection(&m_Lock); + auto it = m_Elements.find(handle); + if (it != m_Elements.end()) + { + InstanceHandle parent = it->second.parent; + for (int depth = 0; depth < 24 && parent; depth++) + { + auto pit = m_Elements.find(parent); + if (pit == m_Elements.end()) + break; + if (IsStartControl(pit->second)) + { + result = parent; + break; + } + parent = pit->second.parent; + } + } + LeaveCriticalSection(&m_Lock); + return result; + } + + static void FreeProperties( PropertyChainSource *sources, unsigned int sourceCount, + PropertyChainValue *values, unsigned int valueCount ) + { + if (sources) + { + for (unsigned int i = 0; i < sourceCount; i++) + { + SysFreeString(sources[i].TargetType); + SysFreeString(sources[i].Name); + SysFreeString(sources[i].SrcInfo.FileName); + SysFreeString(sources[i].SrcInfo.Hash); + } + CoTaskMemFree(sources); + } + if (values) + { + for (unsigned int i = 0; i < valueCount; i++) + { + SysFreeString(values[i].Type); + SysFreeString(values[i].DeclaringType); + SysFreeString(values[i].ValueType); + SysFreeString(values[i].ItemType); + SysFreeString(values[i].Value); + SysFreeString(values[i].PropertyName); + } + CoTaskMemFree(values); + } + } + + HRESULT FindProperty( InstanceHandle handle, const wchar_t *name, unsigned int *index, CString *typeName ) + { + unsigned int sourceCount = 0; + unsigned int valueCount = 0; + PropertyChainSource *sources = NULL; + PropertyChainValue *values = NULL; + HRESULT hr = m_Visual->GetPropertyValuesChain(handle, &sourceCount, &sources, &valueCount, &values); + if (FAILED(hr)) + { + FreeProperties(sources, sourceCount, values, valueCount); + return hr; + } + + bool found = false; + for (unsigned int i = 0; i < valueCount; i++) + { + if (!values[i].PropertyName || wcscmp(values[i].PropertyName, name) != 0) + continue; + if (values[i].MetadataBits & 0x2) // IsPropertyReadOnly + continue; + + *index = values[i].Index; + if (typeName) + *typeName = values[i].Type ? values[i].Type : L""; + found = true; + break; + } + FreeProperties(sources, sourceCount, values, valueCount); + return found ? S_OK : HRESULT_FROM_WIN32(ERROR_NOT_FOUND); + } + + HRESULT SetPropertyText( InstanceHandle handle, const wchar_t *name, const wchar_t *valueText ) + { + unsigned int index = 0; + CString typeName; + HRESULT hr = FindProperty(handle, name, &index, &typeName); + if (FAILED(hr) || typeName.IsEmpty()) + return FAILED(hr) ? hr : E_FAIL; + + CComBSTR type(typeName); + CComBSTR value(valueText); + InstanceHandle created = 0; + hr = m_Visual->CreateInstance(type, value, &created); + if (FAILED(hr)) + return hr; + return m_Visual->SetProperty(handle, created, index); + } + + HRESULT ClearPropertyByName( InstanceHandle handle, const wchar_t *name ) + { + unsigned int index = 0; + HRESULT hr = FindProperty(handle, name, &index, NULL); + if (FAILED(hr)) + return hr; + return m_Visual->ClearProperty(handle, index); + } + + void SetOverrideFlags( InstanceHandle handle, bool *visibility, bool *hitTest ) + { + EnterCriticalSection(&m_Lock); + auto it = m_Elements.find(handle); + if (it != m_Elements.end()) + { + if (visibility) + it->second.visibilityOverride = *visibility; + if (hitTest) + it->second.hitTestOverride = *hitTest; + } + LeaveCriticalSection(&m_Lock); + } + + void ApplyState( bool enabled ) + { + if (!m_Visual) + return; + + std::vector> elements; + InstanceHandle primaryStart = 0; + EnterCriticalSection(&m_Lock); + primaryStart = m_PrimaryStart; + for (auto it = m_Elements.begin(); it != m_Elements.end(); ++it) + elements.push_back(*it); + LeaveCriticalSection(&m_Lock); + + const bool allTaskbars = GetSettingBool(L"AllTaskbars"); + + for (size_t i = 0; i < elements.size(); i++) + { + InstanceHandle handle = elements[i].first; + StartElement record = elements[i].second; + + if (IsStartControl(record)) + { + bool target = allTaskbars || !primaryStart || handle == primaryStart; + if (enabled && target) + { + if (!record.hitTestOverride) + { + HRESULT hr = SetPropertyText(handle, L"IsHitTestVisible", L"False"); + if (SUCCEEDED(hr)) + { + bool value = true; + SetOverrideFlags(handle, NULL, &value); + } + } + } + else if (record.hitTestOverride) + { + HRESULT hr = ClearPropertyByName(handle, L"IsHitTestVisible"); + if (SUCCEEDED(hr)) + { + bool value = false; + SetOverrideFlags(handle, NULL, &value); + } + } + continue; + } + + if (!IsStartGlyph(record)) + continue; + + InstanceHandle startAncestor = GetStartAncestor(handle); + if (!startAncestor) + continue; + bool target = allTaskbars || !primaryStart || startAncestor == primaryStart; + + if (enabled && target) + { + if (!record.visibilityOverride) + { + HRESULT hr = SetPropertyText(handle, L"Visibility", L"Collapsed"); + if (SUCCEEDED(hr)) + { + bool value = true; + SetOverrideFlags(handle, &value, NULL); + } + } + } + else if (record.visibilityOverride) + { + HRESULT hr = ClearPropertyByName(handle, L"Visibility"); + if (SUCCEEDED(hr)) + { + bool value = false; + SetOverrideFlags(handle, &value, NULL); + } + } + } + } + + LONG m_Refs; + bool m_Advised; + HWND m_Dispatch; + CRITICAL_SECTION m_Lock; + CComPtr m_Site; + CComPtr m_Visual; + InstanceHandle m_PrimaryStart; + std::unordered_map m_Elements; +}; + +static CWin11StartButtonTap *GetTapRef( void ) +{ + CWin11StartButtonTap *tap = NULL; + AcquireSRWLockShared(&g_TapLock); + tap = g_Tap; + if (tap) + tap->AddRef(); + ReleaseSRWLockShared(&g_TapLock); + return tap; +} + +class CStartButtonTapFactory: public IClassFactory +{ +public: + CStartButtonTapFactory( void ) { m_Refs = 1; } + + STDMETHODIMP QueryInterface( REFIID riid, void **ppv ) + { + if (!ppv) + return E_POINTER; + *ppv = NULL; + if (riid != IID_IUnknown && riid != IID_IClassFactory) + return E_NOINTERFACE; + *ppv = static_cast(this); + AddRef(); + return S_OK; + } + + STDMETHODIMP_(ULONG) AddRef( void ) { return (ULONG)InterlockedIncrement(&m_Refs); } + STDMETHODIMP_(ULONG) Release( void ) { return (ULONG)InterlockedDecrement(&m_Refs); } + + STDMETHODIMP CreateInstance( IUnknown *outer, REFIID riid, void **ppv ) + { + if (!ppv) + return E_POINTER; + *ppv = NULL; + if (outer) + return CLASS_E_NOAGGREGATION; + + CWin11StartButtonTap *tap = new CWin11StartButtonTap(); + if (!tap) + return E_OUTOFMEMORY; + HRESULT hr = tap->QueryInterface(riid, ppv); + tap->Release(); + return hr; + } + + STDMETHODIMP LockServer( BOOL ) { return S_OK; } + +private: + LONG m_Refs; +}; + +static CStartButtonTapFactory g_Factory; + +// xamlom.h declares DllGetClassObject through the platform headers, so export +// our implementation under that name via a linker alias. +extern "C" HRESULT STDMETHODCALLTYPE OpenShellStartButtonDllGetClassObject( REFCLSID clsid, REFIID riid, LPVOID *ppv ) +{ + if (!IsEqualGUID(clsid, CLSID_OpenShellStartButtonTap)) + return CLASS_E_CLASSNOTAVAILABLE; + return g_Factory.QueryInterface(riid, ppv); +} + +#ifdef _M_IX86 +#pragma comment(linker, "/EXPORT:DllGetClassObject=_OpenShellStartButtonDllGetClassObject@12,PRIVATE") +#else +#pragma comment(linker, "/EXPORT:DllGetClassObject=OpenShellStartButtonDllGetClassObject,PRIVATE") +#endif + +typedef HRESULT (WINAPI *InitXamlDiagnosticsEx_t)( LPCWSTR, DWORD, LPCWSTR, LPCWSTR, CLSID, LPCWSTR ); + +struct ConnectAttempt +{ + InitXamlDiagnosticsEx_t init; + const wchar_t *endpoint; + wchar_t dllPath[MAX_PATH]; + HRESULT hr; +}; + +static DWORD WINAPI ConnectAttemptThread( LPVOID param ) +{ + ConnectAttempt *attempt = (ConnectAttempt*)param; + attempt->hr = attempt->init(attempt->endpoint, GetCurrentProcessId(), NULL, + attempt->dllPath, CLSID_OpenShellStartButtonTap, NULL); + return 0; +} + +static DWORD WINAPI ConnectThread( LPVOID ) +{ + HMODULE runtime = LoadLibraryEx(L"Windows.UI.Xaml.dll", NULL, LOAD_LIBRARY_SEARCH_SYSTEM32); + if (!runtime) + { + InterlockedExchange(&g_ConnectStarted, 0); + return 0; + } + + InitXamlDiagnosticsEx_t init = (InitXamlDiagnosticsEx_t)GetProcAddress(runtime, "InitializeXamlDiagnosticsEx"); + if (!init) + { + FreeLibrary(runtime); + InterlockedExchange(&g_ConnectStarted, 0); + return 0; + } + + HMODULE module = GetThisModule(); + wchar_t dllPath[MAX_PATH]; + if (!module || !GetModuleFileName(module, dllPath, _countof(dllPath))) + { + FreeLibrary(runtime); + InterlockedExchange(&g_ConnectStarted, 0); + return 0; + } + + const wchar_t *endpoints[] = { L"VisualDiagConnection1", L"VisualDiagConnection2" }; + HRESULT last = E_FAIL; + for (int retry = 0; retry < 8 && InterlockedCompareExchange(&g_StartButtonActive, 0, 0); retry++) + { + for (int i = 0; i < _countof(endpoints); i++) + { + ConnectAttempt attempt = {}; + attempt.init = init; + attempt.endpoint = endpoints[i]; + Strcpy(attempt.dllPath, _countof(attempt.dllPath), dllPath); + attempt.hr = E_FAIL; + + HANDLE thread = CreateThread(NULL, 0, ConnectAttemptThread, &attempt, 0, NULL); + if (!thread) + continue; + WaitForSingleObject(thread, INFINITE); + CloseHandle(thread); + last = attempt.hr; + if (SUCCEEDED(last)) + { + LogToFile(STARTUP_LOG, L"Win11StartButton: connected using %s", endpoints[i]); + FreeLibrary(runtime); + return 0; + } + } + Sleep(500); + } + + LogToFile(STARTUP_LOG, L"Win11StartButton: connection failed 0x%08X", last); + FreeLibrary(runtime); + InterlockedExchange(&g_ConnectStarted, 0); + return 0; +} + +static void EnsureConnection( void ) +{ + if (InterlockedCompareExchange(&g_ConnectStarted, 1, 0) != 0) + return; + + HANDLE thread = CreateThread(NULL, 0, ConnectThread, NULL, 0, NULL); + if (thread) + CloseHandle(thread); + else + InterlockedExchange(&g_ConnectStarted, 0); +} + +void StartWin11StartButtonMonitor( void ) +{ + if (!IsWin11()) + return; + + InterlockedExchange(&g_StartButtonActive, 1); + CWin11StartButtonTap *tap = GetTapRef(); + if (tap) + { + tap->RequestApply(false); + tap->Release(); + return; + } + EnsureConnection(); +} + +void UpdateWin11StartButtonMonitor( void ) +{ + if (!IsWin11()) + return; + + CWin11StartButtonTap *tap = GetTapRef(); + if (tap) + { + tap->RequestApply(false); + tap->Release(); + } + else if (InterlockedCompareExchange(&g_StartButtonActive, 0, 0)) + { + EnsureConnection(); + } +} + +void StopWin11StartButtonMonitor( void ) +{ + if (!IsWin11()) + return; + + InterlockedExchange(&g_StartButtonActive, 0); + CWin11StartButtonTap *tap = GetTapRef(); + if (tap) + { + // Synchronous restore: don't let Open-Shell exit while the native + // Start button is still carrying our XAML overrides. + tap->RequestApply(true); + tap->Release(); + } +} diff --git a/Src/StartMenu/StartMenuDLL/Win11StartButton.h b/Src/StartMenu/StartMenuDLL/Win11StartButton.h new file mode 100644 index 000000000..b4bc15b56 --- /dev/null +++ b/Src/StartMenu/StartMenuDLL/Win11StartButton.h @@ -0,0 +1,8 @@ +#pragma once + +// Windows 11 draws the native Start button in XAML. These helpers hide only +// the native glyph/hit target while Open-Shell's replacement button is active. +// They never move or resize either button. +void StartWin11StartButtonMonitor( void ); +void UpdateWin11StartButtonMonitor( void ); +void StopWin11StartButtonMonitor( void ); From 9f572bb07419216a6b3fe61f6ff64d828b52dd33 Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Sun, 4 Oct 2026 18:35:40 +0200 Subject: [PATCH 02/16] Fix Win11 TAP control matching and shutdown --- .../StartMenuDLL/Win11StartButton.cpp | 215 ++++++++++++++++-- 1 file changed, 191 insertions(+), 24 deletions(-) diff --git a/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp index 1bb94cb35..01f4a2df0 100644 --- a/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp +++ b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp @@ -22,6 +22,7 @@ static const GUID CLSID_OpenShellStartButtonTap = { 0x7d15741f, 0x2f3b, 0x4971, { 0xb8, 0x91, 0x6a, 0x5d, 0x42, 0xd7, 0x1a, 0x34 } }; static const UINT WM_OS_STARTBUTTON_APPLY = WM_APP + 0x35B; +static const UINT WM_OS_STARTBUTTON_DESTROY = WM_APP + 0x35C; static volatile LONG g_StartButtonActive = 0; static volatile LONG g_ConnectStarted = 0; @@ -41,12 +42,18 @@ struct StartElement CString name; bool visibilityOverride; bool hitTestOverride; + bool startControlResolved; + bool isStartControl; + unsigned int discoveryOrder; StartElement( void ) { parent = 0; visibilityOverride = false; hitTestOverride = false; + startControlResolved = false; + isStartControl = false; + discoveryOrder = 0; } }; @@ -59,7 +66,7 @@ static bool ContainsText( const CString &text, const wchar_t *part ) return text.Find(part) >= 0; } -static bool IsStartControl( const StartElement &element ) +static bool IsStartControlCandidate( const StartElement &element ) { if (!ContainsText(element.type, L"ExperienceToggleButton")) return false; @@ -88,6 +95,8 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal m_Advised = false; m_Dispatch = NULL; m_PrimaryStart = 0; + m_NextDiscoveryOrder = 0; + m_InjectionReferenceBalanced = false; InitializeCriticalSection(&m_Lock); } @@ -161,9 +170,33 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal EnterCriticalSection(&m_Lock); m_Elements.clear(); m_PrimaryStart = 0; + m_NextDiscoveryOrder = 0; LeaveCriticalSection(&m_Lock); m_Site = site; + + // InitializeXamlDiagnosticsEx loads the TAP DLL by path even though + // StartMenuDLL is already loaded. Balance that injection reference so + // Open-Shell can unload and initialize the DLL again after an explicit Exit. + if (!m_InjectionReferenceBalanced) + { + HMODULE module = GetThisModule(); + if (module) + { + FreeLibrary(module); + m_InjectionReferenceBalanced = true; + } + } + + // Exit may race a connection attempt. Do not attach a new callback after + // shutdown has already begun. + if (!InterlockedCompareExchange(&g_StartButtonActive, 0, 0)) + { + m_Site.Release(); + InterlockedExchange(&g_ConnectStarted, 0); + return S_OK; + } + HRESULT hr = site->QueryInterface(__uuidof(IVisualTreeService), (void**)&m_Visual); if (FAILED(hr) || !m_Visual) return hr; @@ -207,21 +240,12 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal auto it = m_Elements.find(element.Handle); if (it != m_Elements.end()) { - interesting = it->second.visibilityOverride || it->second.hitTestOverride || IsStartControl(it->second); + interesting = it->second.visibilityOverride || it->second.hitTestOverride || + it->second.isStartControl || IsStartControlCandidate(it->second); bool wasPrimary = element.Handle == m_PrimaryStart; m_Elements.erase(it); if (wasPrimary) - { - m_PrimaryStart = 0; - for (auto candidate = m_Elements.begin(); candidate != m_Elements.end(); ++candidate) - { - if (IsStartControl(candidate->second)) - { - m_PrimaryStart = candidate->first; - break; - } - } - } + m_PrimaryStart = FindPrimaryStartLocked(); } } else if (mutationType == Add) @@ -236,12 +260,18 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal { record.visibilityOverride = previous->second.visibilityOverride; record.hitTestOverride = previous->second.hitTestOverride; + record.startControlResolved = previous->second.startControlResolved; + record.isStartControl = previous->second.isStartControl; + record.discoveryOrder = previous->second.discoveryOrder; + } + else + { + record.discoveryOrder = ++m_NextDiscoveryOrder; } m_Elements[element.Handle] = record; - if (IsStartControl(record) && !m_PrimaryStart) - m_PrimaryStart = element.Handle; - interesting = IsStartControl(record) || IsStartGlyph(record) || IsUnderStartButtonLocked(record.parent); + interesting = IsStartControlCandidate(record) || IsStartGlyph(record) || + IsUnderStartButtonLocked(record.parent); } LeaveCriticalSection(&m_Lock); @@ -265,6 +295,43 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal PostMessage(m_Dispatch, WM_OS_STARTBUTTON_APPLY, 0, 0); } + void Shutdown( void ) + { + // Prevent new users of the TAP while teardown is in progress. The caller + // holds a reference, so UnadviseVisualTreeChange cannot destroy this object + // out from under the shutdown sequence. + AcquireSRWLockExclusive(&g_TapLock); + if (g_Tap == this) + g_Tap = NULL; + ReleaseSRWLockExclusive(&g_TapLock); + + // Restore the native XAML state before detaching the callback. + RequestApply(true); + + if (m_Visual && m_Advised) + { + HRESULT hr = m_Visual->UnadviseVisualTreeChange(static_cast(this)); + if (FAILED(hr)) + { + // Keep the DLL resident rather than leave XAML with a callback into + // unloaded code. Explorer restart remains the safe recovery path. + HMODULE module = NULL; + GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS, + (LPCTSTR)&GetThisModule, &module); + LogToFile(STARTUP_LOG, L"Win11StartButton: visual tree unadvise failed 0x%08X", hr); + return; + } + m_Advised = false; + } + + m_Visual.Release(); + m_Site.Release(); + InterlockedExchange(&g_ConnectStarted, 0); + + if (m_Dispatch) + SendMessage(m_Dispatch, WM_OS_STARTBUTTON_DESTROY, 0, 0); + } + private: static LRESULT CALLBACK DispatchProc( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam ) { @@ -282,6 +349,13 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal tap->ApplyState(enabled); return 0; } + if (msg == WM_OS_STARTBUTTON_DESTROY && tap) + { + tap->m_Dispatch = NULL; + SetWindowLongPtr(hwnd, GWLP_USERDATA, 0); + DestroyWindow(hwnd); + return 0; + } return DefWindowProc(hwnd, msg, wParam, lParam); } @@ -314,7 +388,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal auto it = m_Elements.find(parent); if (it == m_Elements.end()) break; - if (IsStartControl(it->second)) + if (it->second.isStartControl) return true; parent = it->second.parent; } @@ -334,7 +408,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal auto pit = m_Elements.find(parent); if (pit == m_Elements.end()) break; - if (IsStartControl(pit->second)) + if (pit->second.isStartControl) { result = parent; break; @@ -375,6 +449,78 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal } } + InstanceHandle FindPrimaryStartLocked( void ) const + { + InstanceHandle primary = 0; + unsigned int bestOrder = 0; + for (auto it = m_Elements.begin(); it != m_Elements.end(); ++it) + { + if (!it->second.isStartControl) + continue; + if (!primary || it->second.discoveryOrder < bestOrder) + { + primary = it->first; + bestOrder = it->second.discoveryOrder; + } + } + return primary; + } + + HRESULT ResolveStartControl( InstanceHandle handle, const StartElement &element, bool *isStartControl ) + { + *isStartControl = false; + if (!IsStartControlCandidate(element)) + return S_OK; + + // Older taskbar implementations may expose a distinct x:Name. + if (element.name.CompareNoCase(L"StartButton") == 0) + { + *isStartControl = true; + return S_OK; + } + + unsigned int sourceCount = 0; + unsigned int valueCount = 0; + PropertyChainSource *sources = NULL; + PropertyChainValue *values = NULL; + HRESULT hr = m_Visual->GetPropertyValuesChain(handle, &sourceCount, &sources, &valueCount, &values); + if (FAILED(hr)) + { + FreeProperties(sources, sourceCount, values, valueCount); + return hr; + } + + for (unsigned int i = 0; i < valueCount; i++) + { + if (!values[i].PropertyName || !values[i].Value) + continue; + if (_wcsicmp(values[i].PropertyName, L"AutomationId") != 0 && + _wcsicmp(values[i].PropertyName, L"AutomationProperties.AutomationId") != 0) + continue; + if (_wcsicmp(values[i].Value, L"StartButton") == 0) + { + *isStartControl = true; + break; + } + } + + FreeProperties(sources, sourceCount, values, valueCount); + return S_OK; + } + + void SetControlClassification( InstanceHandle handle, bool isStartControl ) + { + EnterCriticalSection(&m_Lock); + auto it = m_Elements.find(handle); + if (it != m_Elements.end()) + { + it->second.startControlResolved = true; + it->second.isStartControl = isStartControl; + m_PrimaryStart = FindPrimaryStartLocked(); + } + LeaveCriticalSection(&m_Lock); + } + HRESULT FindProperty( InstanceHandle handle, const wchar_t *name, unsigned int *index, CString *typeName ) { unsigned int sourceCount = 0; @@ -452,13 +598,34 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal return; std::vector> elements; - InstanceHandle primaryStart = 0; EnterCriticalSection(&m_Lock); - primaryStart = m_PrimaryStart; for (auto it = m_Elements.begin(); it != m_Elements.end(); ++it) elements.push_back(*it); LeaveCriticalSection(&m_Lock); + // Start and Task View share ExperienceToggleButton#LaunchListButton on + // current Windows 11 builds. Resolve the attached AutomationId on the XAML + // UI thread before changing any control or descendant. + for (size_t i = 0; i < elements.size(); i++) + { + StartElement &record = elements[i].second; + if (!IsStartControlCandidate(record) || record.startControlResolved) + continue; + + bool isStartControl = false; + if (SUCCEEDED(ResolveStartControl(elements[i].first, record, &isStartControl))) + { + record.startControlResolved = true; + record.isStartControl = isStartControl; + SetControlClassification(elements[i].first, isStartControl); + } + } + + InstanceHandle primaryStart = 0; + EnterCriticalSection(&m_Lock); + primaryStart = m_PrimaryStart; + LeaveCriticalSection(&m_Lock); + const bool allTaskbars = GetSettingBool(L"AllTaskbars"); for (size_t i = 0; i < elements.size(); i++) @@ -466,7 +633,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal InstanceHandle handle = elements[i].first; StartElement record = elements[i].second; - if (IsStartControl(record)) + if (record.isStartControl) { bool target = allTaskbars || !primaryStart || handle == primaryStart; if (enabled && target) @@ -532,6 +699,8 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal CComPtr m_Site; CComPtr m_Visual; InstanceHandle m_PrimaryStart; + unsigned int m_NextDiscoveryOrder; + bool m_InjectionReferenceBalanced; std::unordered_map m_Elements; }; @@ -737,9 +906,7 @@ void StopWin11StartButtonMonitor( void ) CWin11StartButtonTap *tap = GetTapRef(); if (tap) { - // Synchronous restore: don't let Open-Shell exit while the native - // Start button is still carrying our XAML overrides. - tap->RequestApply(true); + tap->Shutdown(); tap->Release(); } } From 3a9869845c43421fef700e2e7f7dbd90a9265b3c Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Sun, 4 Oct 2026 20:42:56 +0200 Subject: [PATCH 03/16] Fix Win11 TAP teardown ordering --- .../StartMenuDLL/Win11StartButton.cpp | 159 ++++++++++++------ 1 file changed, 105 insertions(+), 54 deletions(-) diff --git a/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp index 01f4a2df0..abed3e766 100644 --- a/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp +++ b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp @@ -22,7 +22,7 @@ static const GUID CLSID_OpenShellStartButtonTap = { 0x7d15741f, 0x2f3b, 0x4971, { 0xb8, 0x91, 0x6a, 0x5d, 0x42, 0xd7, 0x1a, 0x34 } }; static const UINT WM_OS_STARTBUTTON_APPLY = WM_APP + 0x35B; -static const UINT WM_OS_STARTBUTTON_DESTROY = WM_APP + 0x35C; +static const UINT WM_OS_STARTBUTTON_SHUTDOWN = WM_APP + 0x35C; static volatile LONG g_StartButtonActive = 0; static volatile LONG g_ConnectStarted = 0; @@ -175,38 +175,41 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal m_Site = site; - // InitializeXamlDiagnosticsEx loads the TAP DLL by path even though - // StartMenuDLL is already loaded. Balance that injection reference so - // Open-Shell can unload and initialize the DLL again after an explicit Exit. - if (!m_InjectionReferenceBalanced) - { - HMODULE module = GetThisModule(); - if (module) - { - FreeLibrary(module); - m_InjectionReferenceBalanced = true; - } - } - + // Keep the module reference acquired by InitializeXamlDiagnosticsEx for + // the whole TAP session. It is balanced only after the callback and all + // XAML/COM references have been released. StartMenuDLL has its own module + // reference while Open-Shell is active, so balancing the diagnostics + // reference during teardown cannot unload code that is still executing. + // // Exit may race a connection attempt. Do not attach a new callback after // shutdown has already begun. if (!InterlockedCompareExchange(&g_StartButtonActive, 0, 0)) { m_Site.Release(); + BalanceInjectionReference(); InterlockedExchange(&g_ConnectStarted, 0); return S_OK; } HRESULT hr = site->QueryInterface(__uuidof(IVisualTreeService), (void**)&m_Visual); if (FAILED(hr) || !m_Visual) + { + m_Visual.Release(); + m_Site.Release(); + BalanceInjectionReference(); + InterlockedExchange(&g_ConnectStarted, 0); return hr; + } if (!CreateDispatchWindow()) - return HRESULT_FROM_WIN32(GetLastError()); - - AcquireSRWLockExclusive(&g_TapLock); - g_Tap = this; - ReleaseSRWLockExclusive(&g_TapLock); + { + DWORD error = GetLastError(); + m_Visual.Release(); + m_Site.Release(); + BalanceInjectionReference(); + InterlockedExchange(&g_ConnectStarted, 0); + return HRESULT_FROM_WIN32(error); + } // Advise replays the existing tree. OnVisualTreeChange only records // element handles; all property access is dispatched afterwards. @@ -214,8 +217,30 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal if (SUCCEEDED(hr)) { m_Advised = true; + + // Publish the TAP only after the subscription is fully established. + // Otherwise an Advise failure can leave g_Tap pointing at an object + // that the XAML runtime is about to release. + AcquireSRWLockExclusive(&g_TapLock); + g_Tap = this; + ReleaseSRWLockExclusive(&g_TapLock); + RequestApply(false); } + else + { + if (m_Dispatch) + { + HWND dispatch = m_Dispatch; + m_Dispatch = NULL; + SetWindowLongPtr(dispatch, GWLP_USERDATA, 0); + DestroyWindow(dispatch); + } + m_Visual.Release(); + m_Site.Release(); + BalanceInjectionReference(); + InterlockedExchange(&g_ConnectStarted, 0); + } LogToFile(STARTUP_LOG, L"Win11StartButton: visual tree advise 0x%08X", hr); return hr; } @@ -295,41 +320,26 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal PostMessage(m_Dispatch, WM_OS_STARTBUTTON_APPLY, 0, 0); } - void Shutdown( void ) + HRESULT Shutdown( void ) { - // Prevent new users of the TAP while teardown is in progress. The caller - // holds a reference, so UnadviseVisualTreeChange cannot destroy this object - // out from under the shutdown sequence. + // SetSite creates the dispatch window on the XAML thread. Run the complete + // XAML/COM teardown on that same thread rather than releasing apartment- + // sensitive interfaces from whichever thread initiated Open-Shell Exit. + if (!m_Dispatch) + return E_UNEXPECTED; + + HRESULT hr = (HRESULT)SendMessage(m_Dispatch, WM_OS_STARTBUTTON_SHUTDOWN, 0, 0); + if (FAILED(hr)) + return hr; + AcquireSRWLockExclusive(&g_TapLock); if (g_Tap == this) g_Tap = NULL; ReleaseSRWLockExclusive(&g_TapLock); - // Restore the native XAML state before detaching the callback. - RequestApply(true); - - if (m_Visual && m_Advised) - { - HRESULT hr = m_Visual->UnadviseVisualTreeChange(static_cast(this)); - if (FAILED(hr)) - { - // Keep the DLL resident rather than leave XAML with a callback into - // unloaded code. Explorer restart remains the safe recovery path. - HMODULE module = NULL; - GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS, - (LPCTSTR)&GetThisModule, &module); - LogToFile(STARTUP_LOG, L"Win11StartButton: visual tree unadvise failed 0x%08X", hr); - return; - } - m_Advised = false; - } - - m_Visual.Release(); - m_Site.Release(); InterlockedExchange(&g_ConnectStarted, 0); - - if (m_Dispatch) - SendMessage(m_Dispatch, WM_OS_STARTBUTTON_DESTROY, 0, 0); + BalanceInjectionReference(); + return S_OK; } private: @@ -349,14 +359,53 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal tap->ApplyState(enabled); return 0; } - if (msg == WM_OS_STARTBUTTON_DESTROY && tap) + if (msg == WM_OS_STARTBUTTON_SHUTDOWN && tap) + return tap->ShutdownOnDispatchThread(); + return DefWindowProc(hwnd, msg, wParam, lParam); + } + + HRESULT ShutdownOnDispatchThread( void ) + { + // The window is owned by the same thread on which SetSite ran. Keep all + // operations touching the XAML diagnostics interfaces on this thread. + ApplyState(false); + + if (m_Visual && m_Advised) { - tap->m_Dispatch = NULL; - SetWindowLongPtr(hwnd, GWLP_USERDATA, 0); - DestroyWindow(hwnd); - return 0; + HRESULT hr = m_Visual->UnadviseVisualTreeChange(static_cast(this)); + if (FAILED(hr)) + { + LogToFile(STARTUP_LOG, L"Win11StartButton: visual tree unadvise failed 0x%08X", hr); + return hr; + } + m_Advised = false; + } + + m_Visual.Release(); + m_Site.Release(); + + if (m_Dispatch) + { + HWND dispatch = m_Dispatch; + m_Dispatch = NULL; + SetWindowLongPtr(dispatch, GWLP_USERDATA, 0); + DestroyWindow(dispatch); + } + return S_OK; + } + + void BalanceInjectionReference( void ) + { + if (m_InjectionReferenceBalanced) + return; + + HMODULE module = GetThisModule(); + if (module) + { + // Mark first: FreeLibrary can run loader callbacks before it returns. + m_InjectionReferenceBalanced = true; + FreeLibrary(module); } - return DefWindowProc(hwnd, msg, wParam, lParam); } bool CreateDispatchWindow( void ) @@ -906,7 +955,9 @@ void StopWin11StartButtonMonitor( void ) CWin11StartButtonTap *tap = GetTapRef(); if (tap) { - tap->Shutdown(); + HRESULT hr = tap->Shutdown(); + if (FAILED(hr)) + LogToFile(STARTUP_LOG, L"Win11StartButton: TAP shutdown failed 0x%08X", hr); tap->Release(); } } From 192b2e3a42bc7121c28cfd7ba3acae3cfe359b23 Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Sun, 4 Oct 2026 20:48:22 +0200 Subject: [PATCH 04/16] Keep Win11 TAP connection worker resident --- .../StartMenuDLL/Win11StartButton.cpp | 55 ++++++++++++------- 1 file changed, 34 insertions(+), 21 deletions(-) diff --git a/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp index abed3e766..edb68920d 100644 --- a/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp +++ b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp @@ -841,31 +841,35 @@ static DWORD WINAPI ConnectAttemptThread( LPVOID param ) return 0; } -static DWORD WINAPI ConnectThread( LPVOID ) +static DWORD FinishConnectThread( HMODULE moduleReference, HMODULE runtime, bool resetConnectionState ) { + if (runtime) + FreeLibrary(runtime); + if (resetConnectionState) + InterlockedExchange(&g_ConnectStarted, 0); + + // The connection worker executes from StartMenuDLL and can outlive the normal + // Open-Shell unload path. Release its private module reference and terminate + // atomically so the DLL cannot disappear underneath the thread's return path. + FreeLibraryAndExitThread(moduleReference, 0); + return 0; +} + +static DWORD WINAPI ConnectThread( LPVOID param ) +{ + HMODULE moduleReference = (HMODULE)param; HMODULE runtime = LoadLibraryEx(L"Windows.UI.Xaml.dll", NULL, LOAD_LIBRARY_SEARCH_SYSTEM32); if (!runtime) - { - InterlockedExchange(&g_ConnectStarted, 0); - return 0; - } + return FinishConnectThread(moduleReference, NULL, true); InitXamlDiagnosticsEx_t init = (InitXamlDiagnosticsEx_t)GetProcAddress(runtime, "InitializeXamlDiagnosticsEx"); if (!init) - { - FreeLibrary(runtime); - InterlockedExchange(&g_ConnectStarted, 0); - return 0; - } + return FinishConnectThread(moduleReference, runtime, true); HMODULE module = GetThisModule(); wchar_t dllPath[MAX_PATH]; if (!module || !GetModuleFileName(module, dllPath, _countof(dllPath))) - { - FreeLibrary(runtime); - InterlockedExchange(&g_ConnectStarted, 0); - return 0; - } + return FinishConnectThread(moduleReference, runtime, true); const wchar_t *endpoints[] = { L"VisualDiagConnection1", L"VisualDiagConnection2" }; HRESULT last = E_FAIL; @@ -888,17 +892,14 @@ static DWORD WINAPI ConnectThread( LPVOID ) if (SUCCEEDED(last)) { LogToFile(STARTUP_LOG, L"Win11StartButton: connected using %s", endpoints[i]); - FreeLibrary(runtime); - return 0; + return FinishConnectThread(moduleReference, runtime, false); } } Sleep(500); } LogToFile(STARTUP_LOG, L"Win11StartButton: connection failed 0x%08X", last); - FreeLibrary(runtime); - InterlockedExchange(&g_ConnectStarted, 0); - return 0; + return FinishConnectThread(moduleReference, runtime, true); } static void EnsureConnection( void ) @@ -906,11 +907,23 @@ static void EnsureConnection( void ) if (InterlockedCompareExchange(&g_ConnectStarted, 1, 0) != 0) return; - HANDLE thread = CreateThread(NULL, 0, ConnectThread, NULL, 0, NULL); + HMODULE moduleReference = NULL; + if (!GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS, (LPCTSTR)&ConnectThread, &moduleReference)) + { + InterlockedExchange(&g_ConnectStarted, 0); + return; + } + + HANDLE thread = CreateThread(NULL, 0, ConnectThread, moduleReference, 0, NULL); if (thread) + { CloseHandle(thread); + } else + { + FreeLibrary(moduleReference); InterlockedExchange(&g_ConnectStarted, 0); + } } void StartWin11StartButtonMonitor( void ) From 440d76eb690d2020f8fdfa575294f4e549177df7 Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Mon, 5 Oct 2026 12:54:33 +0200 Subject: [PATCH 05/16] Isolate Win11 XAML TAP lifetime from StartMenuDLL --- .../StartMenuDLL/Win11StartButton.cpp | 992 ++---------------- .../StartMenuHelper/StartMenuHelper.cpp | 6 + .../StartMenuHelper/StartMenuHelper.vcxproj | 2 + .../StartMenuHelper.vcxproj.filters | 6 + .../StartMenuHelper/StartMenuHelper32.def | 3 + .../StartMenuHelper/StartMenuHelper64.def | 3 + .../StartMenuHelper/Win11StartButtonTap.cpp | 939 +++++++++++++++++ .../StartMenuHelper/Win11StartButtonTap.h | 9 + 8 files changed, 1029 insertions(+), 931 deletions(-) create mode 100644 Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp create mode 100644 Src/StartMenu/StartMenuHelper/Win11StartButtonTap.h diff --git a/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp index edb68920d..663d9fbe2 100644 --- a/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp +++ b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp @@ -1,10 +1,8 @@ -// Windows 11 native Start button suppression. +// Windows 11 native Start button suppression bridge. // -// Open-Shell's replacement button is a separate layered window. Windows 11 -// renders its own Start button in XAML, so the old HWND hiding logic cannot -// remove the native glyph. This file uses the public XAML diagnostics API to -// suppress only the native Start glyph and its hit target. The XAML element is -// left in layout, so centered taskbar positioning remains owned by Windows. +// XAML Diagnostics retains its TAP site object for the diagnostics session. +// The TAP therefore lives in StartMenuHelper, which may remain resident in +// Explorer, while StartMenuDLL can still unload/reload on Exit. #include "stdafx.h" #include "Win11StartButton.h" @@ -12,965 +10,97 @@ #include "LogManager.h" #include "ResourceHelper.h" -#include -#include -#include -#include -#include +typedef void (__cdecl *StartWin11StartButtonTap_t)( BOOL enabled, BOOL allTaskbars ); +typedef void (__cdecl *UpdateWin11StartButtonTap_t)( BOOL enabled, BOOL allTaskbars ); +typedef void (__cdecl *StopWin11StartButtonTap_t)( void ); -static const GUID CLSID_OpenShellStartButtonTap = -{ 0x7d15741f, 0x2f3b, 0x4971, { 0xb8, 0x91, 0x6a, 0x5d, 0x42, 0xd7, 0x1a, 0x34 } }; +static HMODULE g_StartButtonTapModule = NULL; +static StartWin11StartButtonTap_t g_StartButtonTapStart = NULL; +static UpdateWin11StartButtonTap_t g_StartButtonTapUpdate = NULL; +static StopWin11StartButtonTap_t g_StartButtonTapStop = NULL; -static const UINT WM_OS_STARTBUTTON_APPLY = WM_APP + 0x35B; -static const UINT WM_OS_STARTBUTTON_SHUTDOWN = WM_APP + 0x35C; - -static volatile LONG g_StartButtonActive = 0; -static volatile LONG g_ConnectStarted = 0; - -static HMODULE GetThisModule( void ) +static bool LoadStartButtonTap( void ) { - HMODULE module = NULL; - GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS | GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT, - (LPCTSTR)&GetThisModule, &module); - return module; -} - -struct StartElement -{ - InstanceHandle parent; - CString type; - CString name; - bool visibilityOverride; - bool hitTestOverride; - bool startControlResolved; - bool isStartControl; - unsigned int discoveryOrder; - - StartElement( void ) - { - parent = 0; - visibilityOverride = false; - hitTestOverride = false; - startControlResolved = false; - isStartControl = false; - discoveryOrder = 0; - } -}; - -class CWin11StartButtonTap; -static CWin11StartButtonTap *g_Tap = NULL; -static SRWLOCK g_TapLock = SRWLOCK_INIT; - -static bool ContainsText( const CString &text, const wchar_t *part ) -{ - return text.Find(part) >= 0; -} - -static bool IsStartControlCandidate( const StartElement &element ) -{ - if (!ContainsText(element.type, L"ExperienceToggleButton")) - return false; - return element.name == L"LaunchListButton" || element.name == L"StartButton"; -} - -static bool IsStartGlyph( const StartElement &element ) -{ - if (element.name == L"Icon") - return true; - if (ContainsText(element.type, L"AnimatedVisualPlayer") || ContainsText(element.type, L"AepAnimatedIcon")) + if (g_StartButtonTapModule) return true; - if (ContainsText(element.type, L"FontIcon") || ContainsText(element.type, L"PathIcon") || - ContainsText(element.type, L"ImageIcon") || ContainsText(element.type, L"BitmapIcon") || - ContainsText(element.type, L"SymbolIcon")) - return true; - return false; -} - -class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCallback2 -{ -public: - CWin11StartButtonTap( void ) - { - m_Refs = 1; - m_Advised = false; - m_Dispatch = NULL; - m_PrimaryStart = 0; - m_NextDiscoveryOrder = 0; - m_InjectionReferenceBalanced = false; - InitializeCriticalSection(&m_Lock); - } - - ~CWin11StartButtonTap( void ) - { - if (m_Visual && m_Advised) - m_Visual->UnadviseVisualTreeChange(static_cast(this)); - if (m_Dispatch && GetWindowThreadProcessId(m_Dispatch, NULL) == GetCurrentThreadId()) - DestroyWindow(m_Dispatch); - - AcquireSRWLockExclusive(&g_TapLock); - if (g_Tap == this) - g_Tap = NULL; - ReleaseSRWLockExclusive(&g_TapLock); - - InterlockedExchange(&g_ConnectStarted, 0); - DeleteCriticalSection(&m_Lock); - } - - STDMETHODIMP QueryInterface( REFIID riid, void **ppv ) - { - if (!ppv) - return E_POINTER; - *ppv = NULL; - - if (riid == IID_IUnknown || riid == IID_IObjectWithSite) - *ppv = static_cast(this); - else if (riid == __uuidof(IVisualTreeServiceCallback) || riid == __uuidof(IVisualTreeServiceCallback2)) - *ppv = static_cast(this); - else - return E_NOINTERFACE; - - AddRef(); - return S_OK; - } - - STDMETHODIMP_(ULONG) AddRef( void ) - { - return (ULONG)InterlockedIncrement(&m_Refs); - } - - STDMETHODIMP_(ULONG) Release( void ) - { - LONG refs = InterlockedDecrement(&m_Refs); - if (!refs) - delete this; - return (ULONG)refs; - } - - STDMETHODIMP SetSite( IUnknown *site ) - { - if (m_Visual && m_Advised) - { - ApplyState(false); - m_Visual->UnadviseVisualTreeChange(static_cast(this)); - m_Advised = false; - } - m_Visual.Release(); - m_Site.Release(); - - if (!site) - { - AcquireSRWLockExclusive(&g_TapLock); - if (g_Tap == this) - g_Tap = NULL; - ReleaseSRWLockExclusive(&g_TapLock); - InterlockedExchange(&g_ConnectStarted, 0); - return S_OK; - } - - EnterCriticalSection(&m_Lock); - m_Elements.clear(); - m_PrimaryStart = 0; - m_NextDiscoveryOrder = 0; - LeaveCriticalSection(&m_Lock); - - m_Site = site; - - // Keep the module reference acquired by InitializeXamlDiagnosticsEx for - // the whole TAP session. It is balanced only after the callback and all - // XAML/COM references have been released. StartMenuDLL has its own module - // reference while Open-Shell is active, so balancing the diagnostics - // reference during teardown cannot unload code that is still executing. - // - // Exit may race a connection attempt. Do not attach a new callback after - // shutdown has already begun. - if (!InterlockedCompareExchange(&g_StartButtonActive, 0, 0)) - { - m_Site.Release(); - BalanceInjectionReference(); - InterlockedExchange(&g_ConnectStarted, 0); - return S_OK; - } - - HRESULT hr = site->QueryInterface(__uuidof(IVisualTreeService), (void**)&m_Visual); - if (FAILED(hr) || !m_Visual) - { - m_Visual.Release(); - m_Site.Release(); - BalanceInjectionReference(); - InterlockedExchange(&g_ConnectStarted, 0); - return hr; - } - - if (!CreateDispatchWindow()) - { - DWORD error = GetLastError(); - m_Visual.Release(); - m_Site.Release(); - BalanceInjectionReference(); - InterlockedExchange(&g_ConnectStarted, 0); - return HRESULT_FROM_WIN32(error); - } - - // Advise replays the existing tree. OnVisualTreeChange only records - // element handles; all property access is dispatched afterwards. - hr = m_Visual->AdviseVisualTreeChange(static_cast(this)); - if (SUCCEEDED(hr)) - { - m_Advised = true; - // Publish the TAP only after the subscription is fully established. - // Otherwise an Advise failure can leave g_Tap pointing at an object - // that the XAML runtime is about to release. - AcquireSRWLockExclusive(&g_TapLock); - g_Tap = this; - ReleaseSRWLockExclusive(&g_TapLock); - - RequestApply(false); - } - else - { - if (m_Dispatch) - { - HWND dispatch = m_Dispatch; - m_Dispatch = NULL; - SetWindowLongPtr(dispatch, GWLP_USERDATA, 0); - DestroyWindow(dispatch); - } - m_Visual.Release(); - m_Site.Release(); - BalanceInjectionReference(); - InterlockedExchange(&g_ConnectStarted, 0); - } - LogToFile(STARTUP_LOG, L"Win11StartButton: visual tree advise 0x%08X", hr); - return hr; - } - - STDMETHODIMP GetSite( REFIID riid, void **ppv ) - { - if (!ppv) - return E_POINTER; - *ppv = NULL; - if (!m_Site) - return E_FAIL; - return m_Site->QueryInterface(riid, ppv); - } - - STDMETHODIMP OnVisualTreeChange( ParentChildRelation relation, VisualElement element, VisualMutationType mutationType ) - { - bool interesting = false; - - EnterCriticalSection(&m_Lock); - if (mutationType == Remove) - { - auto it = m_Elements.find(element.Handle); - if (it != m_Elements.end()) - { - interesting = it->second.visibilityOverride || it->second.hitTestOverride || - it->second.isStartControl || IsStartControlCandidate(it->second); - bool wasPrimary = element.Handle == m_PrimaryStart; - m_Elements.erase(it); - if (wasPrimary) - m_PrimaryStart = FindPrimaryStartLocked(); - } - } - else if (mutationType == Add) - { - StartElement record; - record.parent = relation.Parent; - record.type = element.Type ? element.Type : L""; - record.name = element.Name ? element.Name : L""; - - auto previous = m_Elements.find(element.Handle); - if (previous != m_Elements.end()) - { - record.visibilityOverride = previous->second.visibilityOverride; - record.hitTestOverride = previous->second.hitTestOverride; - record.startControlResolved = previous->second.startControlResolved; - record.isStartControl = previous->second.isStartControl; - record.discoveryOrder = previous->second.discoveryOrder; - } - else - { - record.discoveryOrder = ++m_NextDiscoveryOrder; - } - m_Elements[element.Handle] = record; - - interesting = IsStartControlCandidate(record) || IsStartGlyph(record) || - IsUnderStartButtonLocked(record.parent); - } - LeaveCriticalSection(&m_Lock); - - if (interesting) - RequestApply(false); - return S_OK; - } - - STDMETHODIMP OnElementStateChanged( InstanceHandle, VisualElementState, LPCWSTR ) - { - return S_OK; - } - - void RequestApply( bool synchronous ) - { - if (!m_Dispatch) - return; - if (synchronous) - SendMessage(m_Dispatch, WM_OS_STARTBUTTON_APPLY, 0, 0); - else - PostMessage(m_Dispatch, WM_OS_STARTBUTTON_APPLY, 0, 0); - } - - HRESULT Shutdown( void ) - { - // SetSite creates the dispatch window on the XAML thread. Run the complete - // XAML/COM teardown on that same thread rather than releasing apartment- - // sensitive interfaces from whichever thread initiated Open-Shell Exit. - if (!m_Dispatch) - return E_UNEXPECTED; - - HRESULT hr = (HRESULT)SendMessage(m_Dispatch, WM_OS_STARTBUTTON_SHUTDOWN, 0, 0); - if (FAILED(hr)) - return hr; - - AcquireSRWLockExclusive(&g_TapLock); - if (g_Tap == this) - g_Tap = NULL; - ReleaseSRWLockExclusive(&g_TapLock); - - InterlockedExchange(&g_ConnectStarted, 0); - BalanceInjectionReference(); - return S_OK; - } - -private: - static LRESULT CALLBACK DispatchProc( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam ) - { - CWin11StartButtonTap *tap = (CWin11StartButtonTap*)GetWindowLongPtr(hwnd, GWLP_USERDATA); - if (msg == WM_NCCREATE) - { - CREATESTRUCT *create = (CREATESTRUCT*)lParam; - tap = (CWin11StartButtonTap*)create->lpCreateParams; - SetWindowLongPtr(hwnd, GWLP_USERDATA, (LONG_PTR)tap); - } - if (msg == WM_OS_STARTBUTTON_APPLY && tap) - { - bool enabled = InterlockedCompareExchange(&g_StartButtonActive, 0, 0) != 0 && - GetSettingBool(L"EnableStartButton"); - tap->ApplyState(enabled); - return 0; - } - if (msg == WM_OS_STARTBUTTON_SHUTDOWN && tap) - return tap->ShutdownOnDispatchThread(); - return DefWindowProc(hwnd, msg, wParam, lParam); - } - - HRESULT ShutdownOnDispatchThread( void ) - { - // The window is owned by the same thread on which SetSite ran. Keep all - // operations touching the XAML diagnostics interfaces on this thread. - ApplyState(false); - - if (m_Visual && m_Advised) - { - HRESULT hr = m_Visual->UnadviseVisualTreeChange(static_cast(this)); - if (FAILED(hr)) - { - LogToFile(STARTUP_LOG, L"Win11StartButton: visual tree unadvise failed 0x%08X", hr); - return hr; - } - m_Advised = false; - } - - m_Visual.Release(); - m_Site.Release(); - - if (m_Dispatch) - { - HWND dispatch = m_Dispatch; - m_Dispatch = NULL; - SetWindowLongPtr(dispatch, GWLP_USERDATA, 0); - DestroyWindow(dispatch); - } - return S_OK; - } - - void BalanceInjectionReference( void ) - { - if (m_InjectionReferenceBalanced) - return; - - HMODULE module = GetThisModule(); - if (module) - { - // Mark first: FreeLibrary can run loader callbacks before it returns. - m_InjectionReferenceBalanced = true; - FreeLibrary(module); - } - } - - bool CreateDispatchWindow( void ) - { - if (m_Dispatch) - return true; - - static const wchar_t CLASS_NAME[] = L"OpenShell.Win11StartButtonTap"; - WNDCLASS wc = {}; - HMODULE module = GetThisModule(); - if (!module) - return false; - - wc.lpfnWndProc = DispatchProc; - wc.hInstance = module; - wc.lpszClassName = CLASS_NAME; - if (!RegisterClass(&wc) && GetLastError() != ERROR_CLASS_ALREADY_EXISTS) - return false; - - m_Dispatch = CreateWindowEx(0, CLASS_NAME, L"", 0, 0, 0, 0, 0, - HWND_MESSAGE, NULL, module, this); - return m_Dispatch != NULL; - } - - bool IsUnderStartButtonLocked( InstanceHandle parent ) const - { - for (int depth = 0; depth < 24 && parent; depth++) - { - auto it = m_Elements.find(parent); - if (it == m_Elements.end()) - break; - if (it->second.isStartControl) - return true; - parent = it->second.parent; - } + wchar_t path[MAX_PATH]; + DWORD pathLength = GetModuleFileName(g_Instance, path, _countof(path)); + if (!pathLength || pathLength >= _countof(path)) return false; - } - - InstanceHandle GetStartAncestor( InstanceHandle handle ) - { - InstanceHandle result = 0; - EnterCriticalSection(&m_Lock); - auto it = m_Elements.find(handle); - if (it != m_Elements.end()) - { - InstanceHandle parent = it->second.parent; - for (int depth = 0; depth < 24 && parent; depth++) - { - auto pit = m_Elements.find(parent); - if (pit == m_Elements.end()) - break; - if (pit->second.isStartControl) - { - result = parent; - break; - } - parent = pit->second.parent; - } - } - LeaveCriticalSection(&m_Lock); - return result; - } - - static void FreeProperties( PropertyChainSource *sources, unsigned int sourceCount, - PropertyChainValue *values, unsigned int valueCount ) - { - if (sources) - { - for (unsigned int i = 0; i < sourceCount; i++) - { - SysFreeString(sources[i].TargetType); - SysFreeString(sources[i].Name); - SysFreeString(sources[i].SrcInfo.FileName); - SysFreeString(sources[i].SrcInfo.Hash); - } - CoTaskMemFree(sources); - } - if (values) - { - for (unsigned int i = 0; i < valueCount; i++) - { - SysFreeString(values[i].Type); - SysFreeString(values[i].DeclaringType); - SysFreeString(values[i].ValueType); - SysFreeString(values[i].ItemType); - SysFreeString(values[i].Value); - SysFreeString(values[i].PropertyName); - } - CoTaskMemFree(values); - } - } - - InstanceHandle FindPrimaryStartLocked( void ) const - { - InstanceHandle primary = 0; - unsigned int bestOrder = 0; - for (auto it = m_Elements.begin(); it != m_Elements.end(); ++it) - { - if (!it->second.isStartControl) - continue; - if (!primary || it->second.discoveryOrder < bestOrder) - { - primary = it->first; - bestOrder = it->second.discoveryOrder; - } - } - return primary; - } - - HRESULT ResolveStartControl( InstanceHandle handle, const StartElement &element, bool *isStartControl ) - { - *isStartControl = false; - if (!IsStartControlCandidate(element)) - return S_OK; - - // Older taskbar implementations may expose a distinct x:Name. - if (element.name.CompareNoCase(L"StartButton") == 0) - { - *isStartControl = true; - return S_OK; - } - - unsigned int sourceCount = 0; - unsigned int valueCount = 0; - PropertyChainSource *sources = NULL; - PropertyChainValue *values = NULL; - HRESULT hr = m_Visual->GetPropertyValuesChain(handle, &sourceCount, &sources, &valueCount, &values); - if (FAILED(hr)) - { - FreeProperties(sources, sourceCount, values, valueCount); - return hr; - } - - for (unsigned int i = 0; i < valueCount; i++) - { - if (!values[i].PropertyName || !values[i].Value) - continue; - if (_wcsicmp(values[i].PropertyName, L"AutomationId") != 0 && - _wcsicmp(values[i].PropertyName, L"AutomationProperties.AutomationId") != 0) - continue; - if (_wcsicmp(values[i].Value, L"StartButton") == 0) - { - *isStartControl = true; - break; - } - } - - FreeProperties(sources, sourceCount, values, valueCount); - return S_OK; - } - - void SetControlClassification( InstanceHandle handle, bool isStartControl ) - { - EnterCriticalSection(&m_Lock); - auto it = m_Elements.find(handle); - if (it != m_Elements.end()) - { - it->second.startControlResolved = true; - it->second.isStartControl = isStartControl; - m_PrimaryStart = FindPrimaryStartLocked(); - } - LeaveCriticalSection(&m_Lock); - } - - HRESULT FindProperty( InstanceHandle handle, const wchar_t *name, unsigned int *index, CString *typeName ) - { - unsigned int sourceCount = 0; - unsigned int valueCount = 0; - PropertyChainSource *sources = NULL; - PropertyChainValue *values = NULL; - HRESULT hr = m_Visual->GetPropertyValuesChain(handle, &sourceCount, &sources, &valueCount, &values); - if (FAILED(hr)) - { - FreeProperties(sources, sourceCount, values, valueCount); - return hr; - } - - bool found = false; - for (unsigned int i = 0; i < valueCount; i++) - { - if (!values[i].PropertyName || wcscmp(values[i].PropertyName, name) != 0) - continue; - if (values[i].MetadataBits & 0x2) // IsPropertyReadOnly - continue; - - *index = values[i].Index; - if (typeName) - *typeName = values[i].Type ? values[i].Type : L""; - found = true; - break; - } - FreeProperties(sources, sourceCount, values, valueCount); - return found ? S_OK : HRESULT_FROM_WIN32(ERROR_NOT_FOUND); - } - - HRESULT SetPropertyText( InstanceHandle handle, const wchar_t *name, const wchar_t *valueText ) - { - unsigned int index = 0; - CString typeName; - HRESULT hr = FindProperty(handle, name, &index, &typeName); - if (FAILED(hr) || typeName.IsEmpty()) - return FAILED(hr) ? hr : E_FAIL; - - CComBSTR type(typeName); - CComBSTR value(valueText); - InstanceHandle created = 0; - hr = m_Visual->CreateInstance(type, value, &created); - if (FAILED(hr)) - return hr; - return m_Visual->SetProperty(handle, created, index); - } - - HRESULT ClearPropertyByName( InstanceHandle handle, const wchar_t *name ) - { - unsigned int index = 0; - HRESULT hr = FindProperty(handle, name, &index, NULL); - if (FAILED(hr)) - return hr; - return m_Visual->ClearProperty(handle, index); - } - - void SetOverrideFlags( InstanceHandle handle, bool *visibility, bool *hitTest ) - { - EnterCriticalSection(&m_Lock); - auto it = m_Elements.find(handle); - if (it != m_Elements.end()) - { - if (visibility) - it->second.visibilityOverride = *visibility; - if (hitTest) - it->second.hitTestOverride = *hitTest; - } - LeaveCriticalSection(&m_Lock); - } - - void ApplyState( bool enabled ) - { - if (!m_Visual) - return; - - std::vector> elements; - EnterCriticalSection(&m_Lock); - for (auto it = m_Elements.begin(); it != m_Elements.end(); ++it) - elements.push_back(*it); - LeaveCriticalSection(&m_Lock); - - // Start and Task View share ExperienceToggleButton#LaunchListButton on - // current Windows 11 builds. Resolve the attached AutomationId on the XAML - // UI thread before changing any control or descendant. - for (size_t i = 0; i < elements.size(); i++) - { - StartElement &record = elements[i].second; - if (!IsStartControlCandidate(record) || record.startControlResolved) - continue; - - bool isStartControl = false; - if (SUCCEEDED(ResolveStartControl(elements[i].first, record, &isStartControl))) - { - record.startControlResolved = true; - record.isStartControl = isStartControl; - SetControlClassification(elements[i].first, isStartControl); - } - } - - InstanceHandle primaryStart = 0; - EnterCriticalSection(&m_Lock); - primaryStart = m_PrimaryStart; - LeaveCriticalSection(&m_Lock); - - const bool allTaskbars = GetSettingBool(L"AllTaskbars"); - - for (size_t i = 0; i < elements.size(); i++) - { - InstanceHandle handle = elements[i].first; - StartElement record = elements[i].second; - - if (record.isStartControl) - { - bool target = allTaskbars || !primaryStart || handle == primaryStart; - if (enabled && target) - { - if (!record.hitTestOverride) - { - HRESULT hr = SetPropertyText(handle, L"IsHitTestVisible", L"False"); - if (SUCCEEDED(hr)) - { - bool value = true; - SetOverrideFlags(handle, NULL, &value); - } - } - } - else if (record.hitTestOverride) - { - HRESULT hr = ClearPropertyByName(handle, L"IsHitTestVisible"); - if (SUCCEEDED(hr)) - { - bool value = false; - SetOverrideFlags(handle, NULL, &value); - } - } - continue; - } - - if (!IsStartGlyph(record)) - continue; - - InstanceHandle startAncestor = GetStartAncestor(handle); - if (!startAncestor) - continue; - bool target = allTaskbars || !primaryStart || startAncestor == primaryStart; - - if (enabled && target) - { - if (!record.visibilityOverride) - { - HRESULT hr = SetPropertyText(handle, L"Visibility", L"Collapsed"); - if (SUCCEEDED(hr)) - { - bool value = true; - SetOverrideFlags(handle, &value, NULL); - } - } - } - else if (record.visibilityOverride) - { - HRESULT hr = ClearPropertyByName(handle, L"Visibility"); - if (SUCCEEDED(hr)) - { - bool value = false; - SetOverrideFlags(handle, &value, NULL); - } - } - } - } - - LONG m_Refs; - bool m_Advised; - HWND m_Dispatch; - CRITICAL_SECTION m_Lock; - CComPtr m_Site; - CComPtr m_Visual; - InstanceHandle m_PrimaryStart; - unsigned int m_NextDiscoveryOrder; - bool m_InjectionReferenceBalanced; - std::unordered_map m_Elements; -}; - -static CWin11StartButtonTap *GetTapRef( void ) -{ - CWin11StartButtonTap *tap = NULL; - AcquireSRWLockShared(&g_TapLock); - tap = g_Tap; - if (tap) - tap->AddRef(); - ReleaseSRWLockShared(&g_TapLock); - return tap; -} - -class CStartButtonTapFactory: public IClassFactory -{ -public: - CStartButtonTapFactory( void ) { m_Refs = 1; } - - STDMETHODIMP QueryInterface( REFIID riid, void **ppv ) - { - if (!ppv) - return E_POINTER; - *ppv = NULL; - if (riid != IID_IUnknown && riid != IID_IClassFactory) - return E_NOINTERFACE; - *ppv = static_cast(this); - AddRef(); - return S_OK; - } - - STDMETHODIMP_(ULONG) AddRef( void ) { return (ULONG)InterlockedIncrement(&m_Refs); } - STDMETHODIMP_(ULONG) Release( void ) { return (ULONG)InterlockedDecrement(&m_Refs); } - - STDMETHODIMP CreateInstance( IUnknown *outer, REFIID riid, void **ppv ) - { - if (!ppv) - return E_POINTER; - *ppv = NULL; - if (outer) - return CLASS_E_NOAGGREGATION; - - CWin11StartButtonTap *tap = new CWin11StartButtonTap(); - if (!tap) - return E_OUTOFMEMORY; - HRESULT hr = tap->QueryInterface(riid, ppv); - tap->Release(); - return hr; - } - STDMETHODIMP LockServer( BOOL ) { return S_OK; } - -private: - LONG m_Refs; -}; - -static CStartButtonTapFactory g_Factory; - -// xamlom.h declares DllGetClassObject through the platform headers, so export -// our implementation under that name via a linker alias. -extern "C" HRESULT STDMETHODCALLTYPE OpenShellStartButtonDllGetClassObject( REFCLSID clsid, REFIID riid, LPVOID *ppv ) -{ - if (!IsEqualGUID(clsid, CLSID_OpenShellStartButtonTap)) - return CLASS_E_CLASSNOTAVAILABLE; - return g_Factory.QueryInterface(riid, ppv); -} + wchar_t *name = wcsrchr(path, L'\\'); + if (!name) + return false; + name++; -#ifdef _M_IX86 -#pragma comment(linker, "/EXPORT:DllGetClassObject=_OpenShellStartButtonDllGetClassObject@12,PRIVATE") +#ifdef _WIN64 + const wchar_t helperName[] = L"StartMenuHelper64.dll"; #else -#pragma comment(linker, "/EXPORT:DllGetClassObject=OpenShellStartButtonDllGetClassObject,PRIVATE") + const wchar_t helperName[] = L"StartMenuHelper32.dll"; #endif -typedef HRESULT (WINAPI *InitXamlDiagnosticsEx_t)( LPCWSTR, DWORD, LPCWSTR, LPCWSTR, CLSID, LPCWSTR ); - -struct ConnectAttempt -{ - InitXamlDiagnosticsEx_t init; - const wchar_t *endpoint; - wchar_t dllPath[MAX_PATH]; - HRESULT hr; -}; - -static DWORD WINAPI ConnectAttemptThread( LPVOID param ) -{ - ConnectAttempt *attempt = (ConnectAttempt*)param; - attempt->hr = attempt->init(attempt->endpoint, GetCurrentProcessId(), NULL, - attempt->dllPath, CLSID_OpenShellStartButtonTap, NULL); - return 0; -} - -static DWORD FinishConnectThread( HMODULE moduleReference, HMODULE runtime, bool resetConnectionState ) -{ - if (runtime) - FreeLibrary(runtime); - if (resetConnectionState) - InterlockedExchange(&g_ConnectStarted, 0); - - // The connection worker executes from StartMenuDLL and can outlive the normal - // Open-Shell unload path. Release its private module reference and terminate - // atomically so the DLL cannot disappear underneath the thread's return path. - FreeLibraryAndExitThread(moduleReference, 0); - return 0; -} - -static DWORD WINAPI ConnectThread( LPVOID param ) -{ - HMODULE moduleReference = (HMODULE)param; - HMODULE runtime = LoadLibraryEx(L"Windows.UI.Xaml.dll", NULL, LOAD_LIBRARY_SEARCH_SYSTEM32); - if (!runtime) - return FinishConnectThread(moduleReference, NULL, true); - - InitXamlDiagnosticsEx_t init = (InitXamlDiagnosticsEx_t)GetProcAddress(runtime, "InitializeXamlDiagnosticsEx"); - if (!init) - return FinishConnectThread(moduleReference, runtime, true); - - HMODULE module = GetThisModule(); - wchar_t dllPath[MAX_PATH]; - if (!module || !GetModuleFileName(module, dllPath, _countof(dllPath))) - return FinishConnectThread(moduleReference, runtime, true); + const size_t remaining = path + _countof(path) - name; + if (_countof(helperName) > remaining) + return false; + wcscpy_s(name, remaining, helperName); - const wchar_t *endpoints[] = { L"VisualDiagConnection1", L"VisualDiagConnection2" }; - HRESULT last = E_FAIL; - for (int retry = 0; retry < 8 && InterlockedCompareExchange(&g_StartButtonActive, 0, 0); retry++) + HMODULE module = LoadLibraryEx(path, NULL, + LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR | LOAD_LIBRARY_SEARCH_SYSTEM32); + if (!module) { - for (int i = 0; i < _countof(endpoints); i++) - { - ConnectAttempt attempt = {}; - attempt.init = init; - attempt.endpoint = endpoints[i]; - Strcpy(attempt.dllPath, _countof(attempt.dllPath), dllPath); - attempt.hr = E_FAIL; - - HANDLE thread = CreateThread(NULL, 0, ConnectAttemptThread, &attempt, 0, NULL); - if (!thread) - continue; - WaitForSingleObject(thread, INFINITE); - CloseHandle(thread); - last = attempt.hr; - if (SUCCEEDED(last)) - { - LogToFile(STARTUP_LOG, L"Win11StartButton: connected using %s", endpoints[i]); - return FinishConnectThread(moduleReference, runtime, false); - } - } - Sleep(500); + LogToFile(STARTUP_LOG, L"Win11StartButton: unable to load TAP helper 0x%08X", GetLastError()); + return false; } - LogToFile(STARTUP_LOG, L"Win11StartButton: connection failed 0x%08X", last); - return FinishConnectThread(moduleReference, runtime, true); -} - -static void EnsureConnection( void ) -{ - if (InterlockedCompareExchange(&g_ConnectStarted, 1, 0) != 0) - return; - - HMODULE moduleReference = NULL; - if (!GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS, (LPCTSTR)&ConnectThread, &moduleReference)) + StartWin11StartButtonTap_t start = + (StartWin11StartButtonTap_t)GetProcAddress(module, "StartWin11StartButtonTap"); + UpdateWin11StartButtonTap_t update = + (UpdateWin11StartButtonTap_t)GetProcAddress(module, "UpdateWin11StartButtonTap"); + StopWin11StartButtonTap_t stop = + (StopWin11StartButtonTap_t)GetProcAddress(module, "StopWin11StartButtonTap"); + if (!start || !update || !stop) { - InterlockedExchange(&g_ConnectStarted, 0); - return; + LogToFile(STARTUP_LOG, L"Win11StartButton: TAP helper exports are unavailable"); + FreeLibrary(module); + return false; } - HANDLE thread = CreateThread(NULL, 0, ConnectThread, moduleReference, 0, NULL); - if (thread) - { - CloseHandle(thread); - } - else - { - FreeLibrary(moduleReference); - InterlockedExchange(&g_ConnectStarted, 0); - } + g_StartButtonTapModule = module; + g_StartButtonTapStart = start; + g_StartButtonTapUpdate = update; + g_StartButtonTapStop = stop; + return true; } void StartWin11StartButtonMonitor( void ) { - if (!IsWin11()) + if (!IsWin11() || !LoadStartButtonTap()) return; - InterlockedExchange(&g_StartButtonActive, 1); - CWin11StartButtonTap *tap = GetTapRef(); - if (tap) - { - tap->RequestApply(false); - tap->Release(); - return; - } - EnsureConnection(); + g_StartButtonTapStart(GetSettingBool(L"EnableStartButton"), GetSettingBool(L"AllTaskbars")); } void UpdateWin11StartButtonMonitor( void ) { - if (!IsWin11()) + if (!IsWin11() || !g_StartButtonTapModule) return; - CWin11StartButtonTap *tap = GetTapRef(); - if (tap) - { - tap->RequestApply(false); - tap->Release(); - } - else if (InterlockedCompareExchange(&g_StartButtonActive, 0, 0)) - { - EnsureConnection(); - } + g_StartButtonTapUpdate(GetSettingBool(L"EnableStartButton"), GetSettingBool(L"AllTaskbars")); } void StopWin11StartButtonMonitor( void ) { - if (!IsWin11()) + if (!IsWin11() || !g_StartButtonTapModule) return; - InterlockedExchange(&g_StartButtonActive, 0); - CWin11StartButtonTap *tap = GetTapRef(); - if (tap) - { - HRESULT hr = tap->Shutdown(); - if (FAILED(hr)) - LogToFile(STARTUP_LOG, L"Win11StartButton: TAP shutdown failed 0x%08X", hr); - tap->Release(); - } + g_StartButtonTapStop(); + + // Drop only StartMenuDLL's explicit reference. XAML Diagnostics owns the TAP + // module reference for the diagnostics session after a successful connection. + FreeLibrary(g_StartButtonTapModule); + g_StartButtonTapModule = NULL; + g_StartButtonTapStart = NULL; + g_StartButtonTapUpdate = NULL; + g_StartButtonTapStop = NULL; } diff --git a/Src/StartMenu/StartMenuHelper/StartMenuHelper.cpp b/Src/StartMenu/StartMenuHelper/StartMenuHelper.cpp index 5004cb83e..1c9e07c41 100644 --- a/Src/StartMenu/StartMenuHelper/StartMenuHelper.cpp +++ b/Src/StartMenu/StartMenuHelper/StartMenuHelper.cpp @@ -5,6 +5,7 @@ #include "resource.h" #include "StartMenuHelper_h.h" #include "dllmain.h" +#include "Win11StartButtonTap.h" #include "ResourceHelper.h" #include "Settings.h" #include "StringUtils.h" @@ -206,6 +207,11 @@ static void StartStartMenu( void ) STDAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID* ppv) { WaitDllInitThread(); + + HRESULT tapResult = GetWin11StartButtonTapClassObject(rclsid, riid, ppv); + if (tapResult != CLASS_E_CLASSNOTAVAILABLE) + return tapResult; + if (rclsid==g_EmulationClsid) { LogToFile(STARTUP_LOG,L"StartMenuHelper: DllGetClassObject1"); diff --git a/Src/StartMenu/StartMenuHelper/StartMenuHelper.vcxproj b/Src/StartMenu/StartMenuHelper/StartMenuHelper.vcxproj index 3e7790656..b7c5e7d84 100644 --- a/Src/StartMenu/StartMenuHelper/StartMenuHelper.vcxproj +++ b/Src/StartMenu/StartMenuHelper/StartMenuHelper.vcxproj @@ -109,6 +109,7 @@ + NotUsing @@ -138,6 +139,7 @@ + diff --git a/Src/StartMenu/StartMenuHelper/StartMenuHelper.vcxproj.filters b/Src/StartMenu/StartMenuHelper/StartMenuHelper.vcxproj.filters index 119fd0dfb..dc32bdb51 100644 --- a/Src/StartMenu/StartMenuHelper/StartMenuHelper.vcxproj.filters +++ b/Src/StartMenu/StartMenuHelper/StartMenuHelper.vcxproj.filters @@ -43,6 +43,9 @@ Source Files + + Source Files + @@ -100,6 +103,9 @@ Header Files + + Header Files + diff --git a/Src/StartMenu/StartMenuHelper/StartMenuHelper32.def b/Src/StartMenu/StartMenuHelper/StartMenuHelper32.def index 5b895b082..9b9d799ff 100644 --- a/Src/StartMenu/StartMenuHelper/StartMenuHelper32.def +++ b/Src/StartMenu/StartMenuHelper/StartMenuHelper32.def @@ -8,3 +8,6 @@ EXPORTS DllRegisterServer PRIVATE DllUnregisterServer PRIVATE DllInstall PRIVATE + StartWin11StartButtonTap + UpdateWin11StartButtonTap + StopWin11StartButtonTap diff --git a/Src/StartMenu/StartMenuHelper/StartMenuHelper64.def b/Src/StartMenu/StartMenuHelper/StartMenuHelper64.def index dd824295a..574e2b446 100644 --- a/Src/StartMenu/StartMenuHelper/StartMenuHelper64.def +++ b/Src/StartMenu/StartMenuHelper/StartMenuHelper64.def @@ -8,3 +8,6 @@ EXPORTS DllRegisterServer PRIVATE DllUnregisterServer PRIVATE DllInstall PRIVATE + StartWin11StartButtonTap + UpdateWin11StartButtonTap + StopWin11StartButtonTap diff --git a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp new file mode 100644 index 000000000..5539af2af --- /dev/null +++ b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp @@ -0,0 +1,939 @@ +// Windows 11 native Start button suppression. +// +// Open-Shell's replacement button is a separate layered window. Windows 11 +// renders its own Start button in XAML, so the old HWND hiding logic cannot +// remove the native glyph. This file uses the public XAML diagnostics API to +// suppress only the native Start glyph and its hit target. The XAML element is +// left in layout, so centered taskbar positioning remains owned by Windows. + +#include "stdafx.h" +#include "Win11StartButtonTap.h" +#include "StartMenuHelper_h.h" +#include "dllmain.h" +#include "Settings.h" +#include "StringUtils.h" +#include "..\StartMenuDLL\LogManager.h" + +#include +#include +#include +#include +#include + +static const GUID CLSID_OpenShellStartButtonTap = +{ 0x7d15741f, 0x2f3b, 0x4971, { 0xb8, 0x91, 0x6a, 0x5d, 0x42, 0xd7, 0x1a, 0x34 } }; + +static const UINT WM_OS_STARTBUTTON_APPLY = WM_APP + 0x35B; + +static volatile LONG g_StartButtonActive = 0; +static volatile LONG g_StartButtonEnabled = 0; +static volatile LONG g_AllTaskbars = 0; +static volatile LONG g_ConnectStarted = 0; + +static HMODULE GetThisModule( void ) +{ + HMODULE module = NULL; + GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS | GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT, + (LPCTSTR)&GetThisModule, &module); + return module; +} + +struct StartElement +{ + InstanceHandle parent; + CString type; + CString name; + bool visibilityOverride; + bool hitTestOverride; + bool startControlResolved; + bool isStartControl; + unsigned int discoveryOrder; + + StartElement( void ) + { + parent = 0; + visibilityOverride = false; + hitTestOverride = false; + startControlResolved = false; + isStartControl = false; + discoveryOrder = 0; + } +}; + +class CWin11StartButtonTap; +static CWin11StartButtonTap *g_Tap = NULL; +static SRWLOCK g_TapLock = SRWLOCK_INIT; + +static bool ContainsText( const CString &text, const wchar_t *part ) +{ + return text.Find(part) >= 0; +} + +static bool IsStartControlCandidate( const StartElement &element ) +{ + if (!ContainsText(element.type, L"ExperienceToggleButton")) + return false; + return element.name == L"LaunchListButton" || element.name == L"StartButton"; +} + +static bool IsStartGlyph( const StartElement &element ) +{ + if (element.name == L"Icon") + return true; + if (ContainsText(element.type, L"AnimatedVisualPlayer") || ContainsText(element.type, L"AepAnimatedIcon")) + return true; + if (ContainsText(element.type, L"FontIcon") || ContainsText(element.type, L"PathIcon") || + ContainsText(element.type, L"ImageIcon") || ContainsText(element.type, L"BitmapIcon") || + ContainsText(element.type, L"SymbolIcon")) + return true; + return false; +} + +static void FreeVisualElementStrings( VisualElement &element ) +{ + SysFreeString(element.Type); + SysFreeString(element.Name); + SysFreeString(element.SrcInfo.FileName); + SysFreeString(element.SrcInfo.Hash); +} + +class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCallback2 +{ +public: + CWin11StartButtonTap( void ) + { + m_Refs = 1; + m_Advised = false; + m_Dispatch = NULL; + m_PrimaryStart = 0; + m_NextDiscoveryOrder = 0; + InitializeCriticalSection(&m_Lock); + _AtlModule.Lock(); + } + + ~CWin11StartButtonTap( void ) + { + if (m_Visual && m_Advised) + m_Visual->UnadviseVisualTreeChange(static_cast(this)); + if (m_Dispatch && GetWindowThreadProcessId(m_Dispatch, NULL) == GetCurrentThreadId()) + DestroyWindow(m_Dispatch); + + AcquireSRWLockExclusive(&g_TapLock); + if (g_Tap == this) + g_Tap = NULL; + ReleaseSRWLockExclusive(&g_TapLock); + + InterlockedExchange(&g_ConnectStarted, 0); + DeleteCriticalSection(&m_Lock); + _AtlModule.Unlock(); + } + + STDMETHODIMP QueryInterface( REFIID riid, void **ppv ) + { + if (!ppv) + return E_POINTER; + *ppv = NULL; + + if (riid == IID_IUnknown || riid == IID_IObjectWithSite) + *ppv = static_cast(this); + else if (riid == __uuidof(IVisualTreeServiceCallback) || riid == __uuidof(IVisualTreeServiceCallback2)) + *ppv = static_cast(this); + else + return E_NOINTERFACE; + + AddRef(); + return S_OK; + } + + STDMETHODIMP_(ULONG) AddRef( void ) + { + return (ULONG)InterlockedIncrement(&m_Refs); + } + + STDMETHODIMP_(ULONG) Release( void ) + { + LONG refs = InterlockedDecrement(&m_Refs); + if (!refs) + delete this; + return (ULONG)refs; + } + + STDMETHODIMP SetSite( IUnknown *site ) + { + if (m_Visual && m_Advised) + { + ApplyState(false); + HRESULT hr = m_Visual->UnadviseVisualTreeChange(static_cast(this)); + if (FAILED(hr)) + { + LogToFile(STARTUP_LOG, L"Win11StartButtonTap: visual tree unadvise failed 0x%08X", hr); + return hr; + } + m_Advised = false; + } + m_Visual.Release(); + m_Site.Release(); + + if (!site) + { + AcquireSRWLockExclusive(&g_TapLock); + if (g_Tap == this) + g_Tap = NULL; + ReleaseSRWLockExclusive(&g_TapLock); + + EnterCriticalSection(&m_Lock); + m_Elements.clear(); + m_PrimaryStart = 0; + m_NextDiscoveryOrder = 0; + LeaveCriticalSection(&m_Lock); + + if (m_Dispatch && GetWindowThreadProcessId(m_Dispatch, NULL) == GetCurrentThreadId()) + { + HWND dispatch = m_Dispatch; + m_Dispatch = NULL; + SetWindowLongPtr(dispatch, GWLP_USERDATA, 0); + DestroyWindow(dispatch); + } + + InterlockedExchange(&g_ConnectStarted, 0); + return S_OK; + } + + EnterCriticalSection(&m_Lock); + m_Elements.clear(); + m_PrimaryStart = 0; + m_NextDiscoveryOrder = 0; + LeaveCriticalSection(&m_Lock); + + m_Site = site; + + // XAML Diagnostics keeps the TAP site object and its module loaded for + // the lifetime of the diagnostics session. Do not reject a late SetSite + // when Open-Shell is inactive: keeping the site attached lets a later + // StartMenuDLL instance reuse the same resident TAP safely. + HRESULT hr = site->QueryInterface(__uuidof(IVisualTreeService), (void**)&m_Visual); + if (FAILED(hr) || !m_Visual) + { + m_Visual.Release(); + m_Site.Release(); + InterlockedExchange(&g_ConnectStarted, 0); + return hr; + } + + if (!CreateDispatchWindow()) + { + DWORD error = GetLastError(); + m_Visual.Release(); + m_Site.Release(); + InterlockedExchange(&g_ConnectStarted, 0); + return HRESULT_FROM_WIN32(error); + } + + // Advise replays the existing tree. OnVisualTreeChange only records + // element handles; all property access is dispatched afterwards. + hr = m_Visual->AdviseVisualTreeChange(static_cast(this)); + if (SUCCEEDED(hr)) + { + m_Advised = true; + + // Publish the TAP only after the subscription is fully established. + // Otherwise an Advise failure can leave g_Tap pointing at an object + // that the XAML runtime is about to release. + AcquireSRWLockExclusive(&g_TapLock); + g_Tap = this; + ReleaseSRWLockExclusive(&g_TapLock); + + RequestApply(false); + } + else + { + if (m_Dispatch) + { + HWND dispatch = m_Dispatch; + m_Dispatch = NULL; + SetWindowLongPtr(dispatch, GWLP_USERDATA, 0); + DestroyWindow(dispatch); + } + m_Visual.Release(); + m_Site.Release(); + InterlockedExchange(&g_ConnectStarted, 0); + } + LogToFile(STARTUP_LOG, L"Win11StartButton: visual tree advise 0x%08X", hr); + return hr; + } + + STDMETHODIMP GetSite( REFIID riid, void **ppv ) + { + if (!ppv) + return E_POINTER; + *ppv = NULL; + if (!m_Site) + return E_FAIL; + return m_Site->QueryInterface(riid, ppv); + } + + STDMETHODIMP OnVisualTreeChange( ParentChildRelation relation, VisualElement element, VisualMutationType mutationType ) + { + // Add notifications transfer ownership of VisualElement's BSTRs to the + // callback. For Remove notifications only element.Handle is valid. + const bool ownsElementStrings = mutationType == Add; + bool interesting = false; + + EnterCriticalSection(&m_Lock); + if (mutationType == Remove) + { + auto it = m_Elements.find(element.Handle); + if (it != m_Elements.end()) + { + interesting = it->second.visibilityOverride || it->second.hitTestOverride || + it->second.isStartControl || IsStartControlCandidate(it->second); + bool wasPrimary = element.Handle == m_PrimaryStart; + m_Elements.erase(it); + if (wasPrimary) + m_PrimaryStart = FindPrimaryStartLocked(); + } + } + else if (mutationType == Add) + { + StartElement record; + record.parent = relation.Parent; + record.type = element.Type ? element.Type : L""; + record.name = element.Name ? element.Name : L""; + + auto previous = m_Elements.find(element.Handle); + if (previous != m_Elements.end()) + { + record.visibilityOverride = previous->second.visibilityOverride; + record.hitTestOverride = previous->second.hitTestOverride; + record.startControlResolved = previous->second.startControlResolved; + record.isStartControl = previous->second.isStartControl; + record.discoveryOrder = previous->second.discoveryOrder; + } + else + { + record.discoveryOrder = ++m_NextDiscoveryOrder; + } + m_Elements[element.Handle] = record; + + interesting = IsStartControlCandidate(record) || IsStartGlyph(record) || + IsUnderStartButtonLocked(record.parent); + } + LeaveCriticalSection(&m_Lock); + + if (interesting) + RequestApply(false); + if (ownsElementStrings) + FreeVisualElementStrings(element); + return S_OK; + } + + STDMETHODIMP OnElementStateChanged( InstanceHandle, VisualElementState, LPCWSTR ) + { + return S_OK; + } + + void RequestApply( bool synchronous ) + { + if (!m_Dispatch) + return; + if (synchronous) + SendMessage(m_Dispatch, WM_OS_STARTBUTTON_APPLY, 0, 0); + else + PostMessage(m_Dispatch, WM_OS_STARTBUTTON_APPLY, 0, 0); + } + + HRESULT Deactivate( void ) + { + // The diagnostics runtime retains this site beyond Open-Shell's lifetime. + // Restore only our overrides; keep the site, callback and dispatch window + // alive so StartMenuDLL can unload/reload independently. + if (!m_Dispatch) + return E_UNEXPECTED; + RequestApply(true); + return S_OK; + } + +private: + static LRESULT CALLBACK DispatchProc( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam ) + { + CWin11StartButtonTap *tap = (CWin11StartButtonTap*)GetWindowLongPtr(hwnd, GWLP_USERDATA); + if (msg == WM_NCCREATE) + { + CREATESTRUCT *create = (CREATESTRUCT*)lParam; + tap = (CWin11StartButtonTap*)create->lpCreateParams; + SetWindowLongPtr(hwnd, GWLP_USERDATA, (LONG_PTR)tap); + } + if (msg == WM_OS_STARTBUTTON_APPLY && tap) + { + bool enabled = InterlockedCompareExchange(&g_StartButtonActive, 0, 0) != 0 && + InterlockedCompareExchange(&g_StartButtonEnabled, 0, 0) != 0; + tap->ApplyState(enabled); + return 0; + } + return DefWindowProc(hwnd, msg, wParam, lParam); + } + + + bool CreateDispatchWindow( void ) + { + if (m_Dispatch) + return true; + + static const wchar_t CLASS_NAME[] = L"OpenShell.Win11StartButtonTap"; + WNDCLASS wc = {}; + HMODULE module = GetThisModule(); + if (!module) + return false; + + wc.lpfnWndProc = DispatchProc; + wc.hInstance = module; + wc.lpszClassName = CLASS_NAME; + if (!RegisterClass(&wc) && GetLastError() != ERROR_CLASS_ALREADY_EXISTS) + return false; + + m_Dispatch = CreateWindowEx(0, CLASS_NAME, L"", 0, 0, 0, 0, 0, + HWND_MESSAGE, NULL, module, this); + return m_Dispatch != NULL; + } + + bool IsUnderStartButtonLocked( InstanceHandle parent ) const + { + for (int depth = 0; depth < 24 && parent; depth++) + { + auto it = m_Elements.find(parent); + if (it == m_Elements.end()) + break; + if (it->second.isStartControl) + return true; + parent = it->second.parent; + } + return false; + } + + InstanceHandle GetStartAncestor( InstanceHandle handle ) + { + InstanceHandle result = 0; + EnterCriticalSection(&m_Lock); + auto it = m_Elements.find(handle); + if (it != m_Elements.end()) + { + InstanceHandle parent = it->second.parent; + for (int depth = 0; depth < 24 && parent; depth++) + { + auto pit = m_Elements.find(parent); + if (pit == m_Elements.end()) + break; + if (pit->second.isStartControl) + { + result = parent; + break; + } + parent = pit->second.parent; + } + } + LeaveCriticalSection(&m_Lock); + return result; + } + + static void FreeProperties( PropertyChainSource *sources, unsigned int sourceCount, + PropertyChainValue *values, unsigned int valueCount ) + { + if (sources) + { + for (unsigned int i = 0; i < sourceCount; i++) + { + SysFreeString(sources[i].TargetType); + SysFreeString(sources[i].Name); + SysFreeString(sources[i].SrcInfo.FileName); + SysFreeString(sources[i].SrcInfo.Hash); + } + CoTaskMemFree(sources); + } + if (values) + { + for (unsigned int i = 0; i < valueCount; i++) + { + SysFreeString(values[i].Type); + SysFreeString(values[i].DeclaringType); + SysFreeString(values[i].ValueType); + SysFreeString(values[i].ItemType); + SysFreeString(values[i].Value); + SysFreeString(values[i].PropertyName); + } + CoTaskMemFree(values); + } + } + + InstanceHandle FindPrimaryStartLocked( void ) const + { + InstanceHandle primary = 0; + unsigned int bestOrder = 0; + for (auto it = m_Elements.begin(); it != m_Elements.end(); ++it) + { + if (!it->second.isStartControl) + continue; + if (!primary || it->second.discoveryOrder < bestOrder) + { + primary = it->first; + bestOrder = it->second.discoveryOrder; + } + } + return primary; + } + + HRESULT ResolveStartControl( InstanceHandle handle, const StartElement &element, bool *isStartControl ) + { + *isStartControl = false; + if (!IsStartControlCandidate(element)) + return S_OK; + + // Older taskbar implementations may expose a distinct x:Name. + if (element.name.CompareNoCase(L"StartButton") == 0) + { + *isStartControl = true; + return S_OK; + } + + unsigned int sourceCount = 0; + unsigned int valueCount = 0; + PropertyChainSource *sources = NULL; + PropertyChainValue *values = NULL; + HRESULT hr = m_Visual->GetPropertyValuesChain(handle, &sourceCount, &sources, &valueCount, &values); + if (FAILED(hr)) + { + FreeProperties(sources, sourceCount, values, valueCount); + return hr; + } + + for (unsigned int i = 0; i < valueCount; i++) + { + if (!values[i].PropertyName || !values[i].Value) + continue; + if (_wcsicmp(values[i].PropertyName, L"AutomationId") != 0 && + _wcsicmp(values[i].PropertyName, L"AutomationProperties.AutomationId") != 0) + continue; + if (_wcsicmp(values[i].Value, L"StartButton") == 0) + { + *isStartControl = true; + break; + } + } + + FreeProperties(sources, sourceCount, values, valueCount); + return S_OK; + } + + void SetControlClassification( InstanceHandle handle, bool isStartControl ) + { + EnterCriticalSection(&m_Lock); + auto it = m_Elements.find(handle); + if (it != m_Elements.end()) + { + it->second.startControlResolved = true; + it->second.isStartControl = isStartControl; + m_PrimaryStart = FindPrimaryStartLocked(); + } + LeaveCriticalSection(&m_Lock); + } + + HRESULT FindProperty( InstanceHandle handle, const wchar_t *name, unsigned int *index, CString *typeName ) + { + unsigned int sourceCount = 0; + unsigned int valueCount = 0; + PropertyChainSource *sources = NULL; + PropertyChainValue *values = NULL; + HRESULT hr = m_Visual->GetPropertyValuesChain(handle, &sourceCount, &sources, &valueCount, &values); + if (FAILED(hr)) + { + FreeProperties(sources, sourceCount, values, valueCount); + return hr; + } + + bool found = false; + for (unsigned int i = 0; i < valueCount; i++) + { + if (!values[i].PropertyName || wcscmp(values[i].PropertyName, name) != 0) + continue; + if (values[i].MetadataBits & 0x2) // IsPropertyReadOnly + continue; + + *index = values[i].Index; + if (typeName) + *typeName = values[i].Type ? values[i].Type : L""; + found = true; + break; + } + FreeProperties(sources, sourceCount, values, valueCount); + return found ? S_OK : HRESULT_FROM_WIN32(ERROR_NOT_FOUND); + } + + HRESULT SetPropertyText( InstanceHandle handle, const wchar_t *name, const wchar_t *valueText ) + { + unsigned int index = 0; + CString typeName; + HRESULT hr = FindProperty(handle, name, &index, &typeName); + if (FAILED(hr) || typeName.IsEmpty()) + return FAILED(hr) ? hr : E_FAIL; + + CComBSTR type(typeName); + CComBSTR value(valueText); + InstanceHandle created = 0; + hr = m_Visual->CreateInstance(type, value, &created); + if (FAILED(hr)) + return hr; + return m_Visual->SetProperty(handle, created, index); + } + + HRESULT ClearPropertyByName( InstanceHandle handle, const wchar_t *name ) + { + unsigned int index = 0; + HRESULT hr = FindProperty(handle, name, &index, NULL); + if (FAILED(hr)) + return hr; + return m_Visual->ClearProperty(handle, index); + } + + void SetOverrideFlags( InstanceHandle handle, bool *visibility, bool *hitTest ) + { + EnterCriticalSection(&m_Lock); + auto it = m_Elements.find(handle); + if (it != m_Elements.end()) + { + if (visibility) + it->second.visibilityOverride = *visibility; + if (hitTest) + it->second.hitTestOverride = *hitTest; + } + LeaveCriticalSection(&m_Lock); + } + + void ApplyState( bool enabled ) + { + if (!m_Visual) + return; + + std::vector> elements; + EnterCriticalSection(&m_Lock); + for (auto it = m_Elements.begin(); it != m_Elements.end(); ++it) + elements.push_back(*it); + LeaveCriticalSection(&m_Lock); + + // Start and Task View share ExperienceToggleButton#LaunchListButton on + // current Windows 11 builds. Resolve the attached AutomationId on the XAML + // UI thread before changing any control or descendant. + for (size_t i = 0; i < elements.size(); i++) + { + StartElement &record = elements[i].second; + if (!IsStartControlCandidate(record) || record.startControlResolved) + continue; + + bool isStartControl = false; + if (SUCCEEDED(ResolveStartControl(elements[i].first, record, &isStartControl))) + { + record.startControlResolved = true; + record.isStartControl = isStartControl; + SetControlClassification(elements[i].first, isStartControl); + } + } + + InstanceHandle primaryStart = 0; + EnterCriticalSection(&m_Lock); + primaryStart = m_PrimaryStart; + LeaveCriticalSection(&m_Lock); + + const bool allTaskbars = InterlockedCompareExchange(&g_AllTaskbars, 0, 0) != 0; + + for (size_t i = 0; i < elements.size(); i++) + { + InstanceHandle handle = elements[i].first; + StartElement record = elements[i].second; + + if (record.isStartControl) + { + bool target = allTaskbars || !primaryStart || handle == primaryStart; + if (enabled && target) + { + if (!record.hitTestOverride) + { + HRESULT hr = SetPropertyText(handle, L"IsHitTestVisible", L"False"); + if (SUCCEEDED(hr)) + { + bool value = true; + SetOverrideFlags(handle, NULL, &value); + } + } + } + else if (record.hitTestOverride) + { + HRESULT hr = ClearPropertyByName(handle, L"IsHitTestVisible"); + if (SUCCEEDED(hr)) + { + bool value = false; + SetOverrideFlags(handle, NULL, &value); + } + } + continue; + } + + if (!IsStartGlyph(record)) + continue; + + InstanceHandle startAncestor = GetStartAncestor(handle); + if (!startAncestor) + continue; + bool target = allTaskbars || !primaryStart || startAncestor == primaryStart; + + if (enabled && target) + { + if (!record.visibilityOverride) + { + HRESULT hr = SetPropertyText(handle, L"Visibility", L"Collapsed"); + if (SUCCEEDED(hr)) + { + bool value = true; + SetOverrideFlags(handle, &value, NULL); + } + } + } + else if (record.visibilityOverride) + { + HRESULT hr = ClearPropertyByName(handle, L"Visibility"); + if (SUCCEEDED(hr)) + { + bool value = false; + SetOverrideFlags(handle, &value, NULL); + } + } + } + } + + LONG m_Refs; + bool m_Advised; + HWND m_Dispatch; + CRITICAL_SECTION m_Lock; + CComPtr m_Site; + CComPtr m_Visual; + InstanceHandle m_PrimaryStart; + unsigned int m_NextDiscoveryOrder; + std::unordered_map m_Elements; +}; + +static CWin11StartButtonTap *GetTapRef( void ) +{ + CWin11StartButtonTap *tap = NULL; + AcquireSRWLockShared(&g_TapLock); + tap = g_Tap; + if (tap) + tap->AddRef(); + ReleaseSRWLockShared(&g_TapLock); + return tap; +} + +class CStartButtonTapFactory: public IClassFactory +{ +public: + CStartButtonTapFactory( void ) { m_Refs = 1; } + + STDMETHODIMP QueryInterface( REFIID riid, void **ppv ) + { + if (!ppv) + return E_POINTER; + *ppv = NULL; + if (riid != IID_IUnknown && riid != IID_IClassFactory) + return E_NOINTERFACE; + *ppv = static_cast(this); + AddRef(); + return S_OK; + } + + STDMETHODIMP_(ULONG) AddRef( void ) { return (ULONG)InterlockedIncrement(&m_Refs); } + STDMETHODIMP_(ULONG) Release( void ) { return (ULONG)InterlockedDecrement(&m_Refs); } + + STDMETHODIMP CreateInstance( IUnknown *outer, REFIID riid, void **ppv ) + { + if (!ppv) + return E_POINTER; + *ppv = NULL; + if (outer) + return CLASS_E_NOAGGREGATION; + + CWin11StartButtonTap *tap = new CWin11StartButtonTap(); + if (!tap) + return E_OUTOFMEMORY; + HRESULT hr = tap->QueryInterface(riid, ppv); + tap->Release(); + return hr; + } + + STDMETHODIMP LockServer( BOOL lock ) + { + if (lock) + _AtlModule.Lock(); + else + _AtlModule.Unlock(); + return S_OK; + } + +private: + LONG m_Refs; +}; + +static CStartButtonTapFactory g_Factory; + +HRESULT GetWin11StartButtonTapClassObject( REFCLSID clsid, REFIID riid, LPVOID *ppv ) +{ + if (!IsEqualGUID(clsid, CLSID_OpenShellStartButtonTap)) + return CLASS_E_CLASSNOTAVAILABLE; + return g_Factory.QueryInterface(riid, ppv); +} + +typedef HRESULT (WINAPI *InitXamlDiagnosticsEx_t)( LPCWSTR, DWORD, LPCWSTR, LPCWSTR, CLSID, LPCWSTR ); + +struct ConnectAttempt +{ + InitXamlDiagnosticsEx_t init; + const wchar_t *endpoint; + wchar_t dllPath[MAX_PATH]; + HRESULT hr; +}; + +static DWORD WINAPI ConnectAttemptThread( LPVOID param ) +{ + ConnectAttempt *attempt = (ConnectAttempt*)param; + attempt->hr = attempt->init(attempt->endpoint, GetCurrentProcessId(), NULL, + attempt->dllPath, CLSID_OpenShellStartButtonTap, NULL); + return 0; +} + +static DWORD FinishConnectThread( HMODULE moduleReference, HMODULE runtime, bool resetConnectionState ) +{ + if (runtime) + FreeLibrary(runtime); + if (resetConnectionState) + InterlockedExchange(&g_ConnectStarted, 0); + + // Keep a private StartMenuHelper reference while this worker is running. + // Release it atomically with thread termination so a failed diagnostics + // connection cannot unload the helper underneath the worker's return path. + FreeLibraryAndExitThread(moduleReference, 0); + return 0; +} + +static DWORD WINAPI ConnectThread( LPVOID param ) +{ + HMODULE moduleReference = (HMODULE)param; + HMODULE runtime = LoadLibraryEx(L"Windows.UI.Xaml.dll", NULL, LOAD_LIBRARY_SEARCH_SYSTEM32); + if (!runtime) + return FinishConnectThread(moduleReference, NULL, true); + + InitXamlDiagnosticsEx_t init = (InitXamlDiagnosticsEx_t)GetProcAddress(runtime, "InitializeXamlDiagnosticsEx"); + if (!init) + return FinishConnectThread(moduleReference, runtime, true); + + HMODULE module = GetThisModule(); + wchar_t dllPath[MAX_PATH]; + if (!module || !GetModuleFileName(module, dllPath, _countof(dllPath))) + return FinishConnectThread(moduleReference, runtime, true); + + const wchar_t *endpoints[] = { L"VisualDiagConnection1", L"VisualDiagConnection2" }; + HRESULT last = E_FAIL; + for (int retry = 0; retry < 8 && InterlockedCompareExchange(&g_StartButtonActive, 0, 0); retry++) + { + for (int i = 0; i < _countof(endpoints); i++) + { + ConnectAttempt attempt = {}; + attempt.init = init; + attempt.endpoint = endpoints[i]; + Strcpy(attempt.dllPath, _countof(attempt.dllPath), dllPath); + attempt.hr = E_FAIL; + + HANDLE thread = CreateThread(NULL, 0, ConnectAttemptThread, &attempt, 0, NULL); + if (!thread) + continue; + WaitForSingleObject(thread, INFINITE); + CloseHandle(thread); + last = attempt.hr; + if (SUCCEEDED(last)) + { + LogToFile(STARTUP_LOG, L"Win11StartButton: connected using %s", endpoints[i]); + return FinishConnectThread(moduleReference, runtime, false); + } + } + Sleep(500); + } + + LogToFile(STARTUP_LOG, L"Win11StartButton: connection failed 0x%08X", last); + return FinishConnectThread(moduleReference, runtime, true); +} + +static void EnsureConnection( void ) +{ + if (InterlockedCompareExchange(&g_ConnectStarted, 1, 0) != 0) + return; + + HMODULE moduleReference = NULL; + if (!GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS, (LPCTSTR)&ConnectThread, &moduleReference)) + { + InterlockedExchange(&g_ConnectStarted, 0); + return; + } + + HANDLE thread = CreateThread(NULL, 0, ConnectThread, moduleReference, 0, NULL); + if (thread) + { + CloseHandle(thread); + } + else + { + FreeLibrary(moduleReference); + InterlockedExchange(&g_ConnectStarted, 0); + } +} + +extern "C" void StartWin11StartButtonTap( BOOL enabled, BOOL allTaskbars ) +{ + InterlockedExchange(&g_StartButtonEnabled, enabled ? 1 : 0); + InterlockedExchange(&g_AllTaskbars, allTaskbars ? 1 : 0); + InterlockedExchange(&g_StartButtonActive, 1); + + CWin11StartButtonTap *tap = GetTapRef(); + if (tap) + { + tap->RequestApply(false); + tap->Release(); + return; + } + + EnsureConnection(); +} + +extern "C" void UpdateWin11StartButtonTap( BOOL enabled, BOOL allTaskbars ) +{ + InterlockedExchange(&g_StartButtonEnabled, enabled ? 1 : 0); + InterlockedExchange(&g_AllTaskbars, allTaskbars ? 1 : 0); + + CWin11StartButtonTap *tap = GetTapRef(); + if (tap) + { + tap->RequestApply(false); + tap->Release(); + } + else if (InterlockedCompareExchange(&g_StartButtonActive, 0, 0)) + { + EnsureConnection(); + } +} + +extern "C" void StopWin11StartButtonTap( void ) +{ + InterlockedExchange(&g_StartButtonActive, 0); + + CWin11StartButtonTap *tap = GetTapRef(); + if (tap) + { + HRESULT hr = tap->Deactivate(); + if (FAILED(hr)) + LogToFile(STARTUP_LOG, L"Win11StartButtonTap: deactivate failed 0x%08X", hr); + tap->Release(); + } +} diff --git a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.h b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.h new file mode 100644 index 000000000..08df88960 --- /dev/null +++ b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.h @@ -0,0 +1,9 @@ +#pragma once + +#include + +HRESULT GetWin11StartButtonTapClassObject( REFCLSID clsid, REFIID riid, LPVOID *ppv ); + +extern "C" void StartWin11StartButtonTap( BOOL enabled, BOOL allTaskbars ); +extern "C" void UpdateWin11StartButtonTap( BOOL enabled, BOOL allTaskbars ); +extern "C" void StopWin11StartButtonTap( void ); From 2ec3d6d408414298c3ec26f327276e912f8fbbfd Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Mon, 5 Oct 2026 13:12:47 +0200 Subject: [PATCH 06/16] Do not free XAML callback input strings --- .../StartMenuHelper/Win11StartButtonTap.cpp | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp index 5539af2af..6770e6431 100644 --- a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp +++ b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp @@ -89,14 +89,6 @@ static bool IsStartGlyph( const StartElement &element ) return false; } -static void FreeVisualElementStrings( VisualElement &element ) -{ - SysFreeString(element.Type); - SysFreeString(element.Name); - SysFreeString(element.SrcInfo.FileName); - SysFreeString(element.SrcInfo.Hash); -} - class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCallback2 { public: @@ -274,9 +266,8 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal STDMETHODIMP OnVisualTreeChange( ParentChildRelation relation, VisualElement element, VisualMutationType mutationType ) { - // Add notifications transfer ownership of VisualElement's BSTRs to the - // callback. For Remove notifications only element.Handle is valid. - const bool ownsElementStrings = mutationType == Add; + // VisualElement is an [in] parameter. The XAML diagnostics runtime owns + // the BSTR fields; copy the values we need but never free callback input. bool interesting = false; EnterCriticalSection(&m_Lock); @@ -322,8 +313,6 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal if (interesting) RequestApply(false); - if (ownsElementStrings) - FreeVisualElementStrings(element); return S_OK; } From 4a7254fd35ab51393364b4eb9cf88086bfb0546c Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Tue, 6 Oct 2026 19:06:48 +0200 Subject: [PATCH 07/16] Load StartMenuHelper from System32 as fallback --- .../StartMenuDLL/Win11StartButton.cpp | 39 +++++++++++-------- 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp index 663d9fbe2..f1c975207 100644 --- a/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp +++ b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp @@ -24,29 +24,36 @@ static bool LoadStartButtonTap( void ) if (g_StartButtonTapModule) return true; - wchar_t path[MAX_PATH]; - DWORD pathLength = GetModuleFileName(g_Instance, path, _countof(path)); - if (!pathLength || pathLength >= _countof(path)) - return false; - - wchar_t *name = wcsrchr(path, L'\\'); - if (!name) - return false; - name++; - #ifdef _WIN64 const wchar_t helperName[] = L"StartMenuHelper64.dll"; #else const wchar_t helperName[] = L"StartMenuHelper32.dll"; #endif - const size_t remaining = path + _countof(path) - name; - if (_countof(helperName) > remaining) - return false; - wcscpy_s(name, remaining, helperName); + // Prefer a helper next to StartMenuDLL for local development builds, but + // installed Open-Shell keeps StartMenuHelper in System32. + HMODULE module = NULL; + wchar_t path[MAX_PATH]; + DWORD pathLength = GetModuleFileName(g_Instance, path, _countof(path)); + if (pathLength && pathLength < _countof(path)) + { + wchar_t *name = wcsrchr(path, L'\\'); + if (name) + { + name++; + const size_t remaining = path + _countof(path) - name; + if (_countof(helperName) <= remaining) + { + wcscpy_s(name, remaining, helperName); + module = LoadLibraryEx(path, NULL, + LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR | LOAD_LIBRARY_SEARCH_SYSTEM32); + } + } + } + + if (!module) + module = LoadLibraryEx(helperName, NULL, LOAD_LIBRARY_SEARCH_SYSTEM32); - HMODULE module = LoadLibraryEx(path, NULL, - LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR | LOAD_LIBRARY_SEARCH_SYSTEM32); if (!module) { LogToFile(STARTUP_LOG, L"Win11StartButton: unable to load TAP helper 0x%08X", GetLastError()); From 422fe0349cac177ce9711644e782eba469d00310 Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Tue, 6 Oct 2026 19:06:51 +0200 Subject: [PATCH 08/16] Avoid GetCurrentTime macro conflict in XAML headers --- Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp index 6770e6431..13a7dc5d6 100644 --- a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp +++ b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp @@ -14,6 +14,7 @@ #include "StringUtils.h" #include "..\StartMenuDLL\LogManager.h" +#undef GetCurrentTime #include #include #include From 0a769cde58b68721e99e0580556f275382e99f5a Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Tue, 6 Oct 2026 20:14:08 +0200 Subject: [PATCH 09/16] Simplify full-path StartMenuHelper loading --- Src/StartMenu/StartMenuDLL/Win11StartButton.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp index f1c975207..5f03a52ba 100644 --- a/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp +++ b/Src/StartMenu/StartMenuDLL/Win11StartButton.cpp @@ -45,8 +45,7 @@ static bool LoadStartButtonTap( void ) if (_countof(helperName) <= remaining) { wcscpy_s(name, remaining, helperName); - module = LoadLibraryEx(path, NULL, - LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR | LOAD_LIBRARY_SEARCH_SYSTEM32); + module = LoadLibrary(path); } } } From c3c353bbb6a9df530651c4bdb1bb65b04a91975a Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Tue, 6 Oct 2026 20:14:11 +0200 Subject: [PATCH 10/16] Use in-class initialization for StartElement --- .../StartMenuHelper/Win11StartButtonTap.cpp | 22 +++++-------------- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp index 13a7dc5d6..1ce348939 100644 --- a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp +++ b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp @@ -41,24 +41,14 @@ static HMODULE GetThisModule( void ) struct StartElement { - InstanceHandle parent; + InstanceHandle parent = 0; CString type; CString name; - bool visibilityOverride; - bool hitTestOverride; - bool startControlResolved; - bool isStartControl; - unsigned int discoveryOrder; - - StartElement( void ) - { - parent = 0; - visibilityOverride = false; - hitTestOverride = false; - startControlResolved = false; - isStartControl = false; - discoveryOrder = 0; - } + bool visibilityOverride = false; + bool hitTestOverride = false; + bool startControlResolved = false; + bool isStartControl = false; + unsigned int discoveryOrder = 0; }; class CWin11StartButtonTap; From 2bce76c7a9d5871b7aa98808a3f641ef6e398478 Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Tue, 6 Oct 2026 20:29:14 +0200 Subject: [PATCH 11/16] Modernize Win11 TAP synchronization and COM lifetime --- .../StartMenuHelper/Win11StartButtonTap.cpp | 244 ++++++++---------- 1 file changed, 114 insertions(+), 130 deletions(-) diff --git a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp index 1ce348939..deaf407c8 100644 --- a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp +++ b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp @@ -18,7 +18,11 @@ #include #include #include +#include +#include +#include #include +#include #include static const GUID CLSID_OpenShellStartButtonTap = @@ -26,10 +30,10 @@ static const GUID CLSID_OpenShellStartButtonTap = static const UINT WM_OS_STARTBUTTON_APPLY = WM_APP + 0x35B; -static volatile LONG g_StartButtonActive = 0; -static volatile LONG g_StartButtonEnabled = 0; -static volatile LONG g_AllTaskbars = 0; -static volatile LONG g_ConnectStarted = 0; +static std::atomic_bool g_StartButtonActive{ false }; +static std::atomic_bool g_StartButtonEnabled{ false }; +static std::atomic_bool g_AllTaskbars{ false }; +static std::atomic_bool g_ConnectStarted{ false }; static HMODULE GetThisModule( void ) { @@ -53,7 +57,7 @@ struct StartElement class CWin11StartButtonTap; static CWin11StartButtonTap *g_Tap = NULL; -static SRWLOCK g_TapLock = SRWLOCK_INIT; +static std::shared_mutex g_TapMutex; static bool ContainsText( const CString &text, const wchar_t *part ) { @@ -85,29 +89,28 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal public: CWin11StartButtonTap( void ) { - m_Refs = 1; - m_Advised = false; - m_Dispatch = NULL; - m_PrimaryStart = 0; - m_NextDiscoveryOrder = 0; - InitializeCriticalSection(&m_Lock); _AtlModule.Lock(); } ~CWin11StartButtonTap( void ) { + { + std::unique_lock lock(g_TapMutex); + if (g_Tap == this) + g_Tap = NULL; + } + if (m_Visual && m_Advised) m_Visual->UnadviseVisualTreeChange(static_cast(this)); if (m_Dispatch && GetWindowThreadProcessId(m_Dispatch, NULL) == GetCurrentThreadId()) - DestroyWindow(m_Dispatch); - - AcquireSRWLockExclusive(&g_TapLock); - if (g_Tap == this) - g_Tap = NULL; - ReleaseSRWLockExclusive(&g_TapLock); + { + HWND dispatch = m_Dispatch; + m_Dispatch = NULL; + SetWindowLongPtr(dispatch, GWLP_USERDATA, 0); + DestroyWindow(dispatch); + } - InterlockedExchange(&g_ConnectStarted, 0); - DeleteCriticalSection(&m_Lock); + g_ConnectStarted.store(false); _AtlModule.Unlock(); } @@ -130,15 +133,15 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal STDMETHODIMP_(ULONG) AddRef( void ) { - return (ULONG)InterlockedIncrement(&m_Refs); + return ++m_Refs; } STDMETHODIMP_(ULONG) Release( void ) { - LONG refs = InterlockedDecrement(&m_Refs); + ULONG refs = --m_Refs; if (!refs) delete this; - return (ULONG)refs; + return refs; } STDMETHODIMP SetSite( IUnknown *site ) @@ -154,22 +157,25 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal } m_Advised = false; } - m_Visual.Release(); - m_Site.Release(); - if (!site) { - AcquireSRWLockExclusive(&g_TapLock); + std::unique_lock lock(g_TapMutex); if (g_Tap == this) g_Tap = NULL; - ReleaseSRWLockExclusive(&g_TapLock); + } + + m_Visual.Release(); + m_Site.Release(); - EnterCriticalSection(&m_Lock); + { + std::lock_guard lock(m_Mutex); m_Elements.clear(); m_PrimaryStart = 0; m_NextDiscoveryOrder = 0; - LeaveCriticalSection(&m_Lock); + } + if (!site) + { if (m_Dispatch && GetWindowThreadProcessId(m_Dispatch, NULL) == GetCurrentThreadId()) { HWND dispatch = m_Dispatch; @@ -178,57 +184,29 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal DestroyWindow(dispatch); } - InterlockedExchange(&g_ConnectStarted, 0); + g_ConnectStarted.store(false); return S_OK; } - EnterCriticalSection(&m_Lock); - m_Elements.clear(); - m_PrimaryStart = 0; - m_NextDiscoveryOrder = 0; - LeaveCriticalSection(&m_Lock); - - m_Site = site; + CComPtr newSite = site; + CComPtr newVisual; // XAML Diagnostics keeps the TAP site object and its module loaded for - // the lifetime of the diagnostics session. Do not reject a late SetSite - // when Open-Shell is inactive: keeping the site attached lets a later - // StartMenuDLL instance reuse the same resident TAP safely. - HRESULT hr = site->QueryInterface(__uuidof(IVisualTreeService), (void**)&m_Visual); - if (FAILED(hr) || !m_Visual) - { - m_Visual.Release(); - m_Site.Release(); - InterlockedExchange(&g_ConnectStarted, 0); + // the lifetime of the diagnostics session. Build the new COM state in + // locals first, and publish it only after the subscription succeeds. + HRESULT hr = site->QueryInterface(__uuidof(IVisualTreeService), (void**)&newVisual); + if (FAILED(hr)) return hr; - } + if (!newVisual) + return E_NOINTERFACE; if (!CreateDispatchWindow()) - { - DWORD error = GetLastError(); - m_Visual.Release(); - m_Site.Release(); - InterlockedExchange(&g_ConnectStarted, 0); - return HRESULT_FROM_WIN32(error); - } + return HRESULT_FROM_WIN32(GetLastError()); // Advise replays the existing tree. OnVisualTreeChange only records // element handles; all property access is dispatched afterwards. - hr = m_Visual->AdviseVisualTreeChange(static_cast(this)); - if (SUCCEEDED(hr)) - { - m_Advised = true; - - // Publish the TAP only after the subscription is fully established. - // Otherwise an Advise failure can leave g_Tap pointing at an object - // that the XAML runtime is about to release. - AcquireSRWLockExclusive(&g_TapLock); - g_Tap = this; - ReleaseSRWLockExclusive(&g_TapLock); - - RequestApply(false); - } - else + hr = newVisual->AdviseVisualTreeChange(static_cast(this)); + if (FAILED(hr)) { if (m_Dispatch) { @@ -237,10 +215,20 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal SetWindowLongPtr(dispatch, GWLP_USERDATA, 0); DestroyWindow(dispatch); } - m_Visual.Release(); - m_Site.Release(); - InterlockedExchange(&g_ConnectStarted, 0); + LogToFile(STARTUP_LOG, L"Win11StartButton: visual tree advise 0x%08X", hr); + return hr; + } + + m_Site = std::move(newSite); + m_Visual = std::move(newVisual); + m_Advised = true; + + { + std::unique_lock lock(g_TapMutex); + g_Tap = this; } + + RequestApply(false); LogToFile(STARTUP_LOG, L"Win11StartButton: visual tree advise 0x%08X", hr); return hr; } @@ -261,7 +249,8 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal // the BSTR fields; copy the values we need but never free callback input. bool interesting = false; - EnterCriticalSection(&m_Lock); + { + std::lock_guard lock(m_Mutex); if (mutationType == Remove) { auto it = m_Elements.find(element.Handle); @@ -300,7 +289,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal interesting = IsStartControlCandidate(record) || IsStartGlyph(record) || IsUnderStartButtonLocked(record.parent); } - LeaveCriticalSection(&m_Lock); + } if (interesting) RequestApply(false); @@ -345,8 +334,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal } if (msg == WM_OS_STARTBUTTON_APPLY && tap) { - bool enabled = InterlockedCompareExchange(&g_StartButtonActive, 0, 0) != 0 && - InterlockedCompareExchange(&g_StartButtonEnabled, 0, 0) != 0; + bool enabled = g_StartButtonActive.load() && g_StartButtonEnabled.load(); tap->ApplyState(enabled); return 0; } @@ -393,7 +381,8 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal InstanceHandle GetStartAncestor( InstanceHandle handle ) { InstanceHandle result = 0; - EnterCriticalSection(&m_Lock); + { + std::lock_guard lock(m_Mutex); auto it = m_Elements.find(handle); if (it != m_Elements.end()) { @@ -411,7 +400,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal parent = pit->second.parent; } } - LeaveCriticalSection(&m_Lock); + } return result; } @@ -505,7 +494,8 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal void SetControlClassification( InstanceHandle handle, bool isStartControl ) { - EnterCriticalSection(&m_Lock); + { + std::lock_guard lock(m_Mutex); auto it = m_Elements.find(handle); if (it != m_Elements.end()) { @@ -513,7 +503,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal it->second.isStartControl = isStartControl; m_PrimaryStart = FindPrimaryStartLocked(); } - LeaveCriticalSection(&m_Lock); + } } HRESULT FindProperty( InstanceHandle handle, const wchar_t *name, unsigned int *index, CString *typeName ) @@ -575,7 +565,8 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal void SetOverrideFlags( InstanceHandle handle, bool *visibility, bool *hitTest ) { - EnterCriticalSection(&m_Lock); + { + std::lock_guard lock(m_Mutex); auto it = m_Elements.find(handle); if (it != m_Elements.end()) { @@ -584,7 +575,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal if (hitTest) it->second.hitTestOverride = *hitTest; } - LeaveCriticalSection(&m_Lock); + } } void ApplyState( bool enabled ) @@ -593,10 +584,11 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal return; std::vector> elements; - EnterCriticalSection(&m_Lock); + { + std::lock_guard lock(m_Mutex); for (auto it = m_Elements.begin(); it != m_Elements.end(); ++it) elements.push_back(*it); - LeaveCriticalSection(&m_Lock); + } // Start and Task View share ExperienceToggleButton#LaunchListButton on // current Windows 11 builds. Resolve the attached AutomationId on the XAML @@ -617,11 +609,12 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal } InstanceHandle primaryStart = 0; - EnterCriticalSection(&m_Lock); + { + std::lock_guard lock(m_Mutex); primaryStart = m_PrimaryStart; - LeaveCriticalSection(&m_Lock); + } - const bool allTaskbars = InterlockedCompareExchange(&g_AllTaskbars, 0, 0) != 0; + const bool allTaskbars = g_AllTaskbars.load(); for (size_t i = 0; i < elements.size(); i++) { @@ -687,33 +680,26 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal } } - LONG m_Refs; - bool m_Advised; - HWND m_Dispatch; - CRITICAL_SECTION m_Lock; + std::atomic m_Refs{ 1 }; + bool m_Advised = false; + HWND m_Dispatch = NULL; + std::mutex m_Mutex; CComPtr m_Site; CComPtr m_Visual; - InstanceHandle m_PrimaryStart; - unsigned int m_NextDiscoveryOrder; + InstanceHandle m_PrimaryStart = 0; + unsigned int m_NextDiscoveryOrder = 0; std::unordered_map m_Elements; }; -static CWin11StartButtonTap *GetTapRef( void ) +static CComPtr GetTapRef( void ) { - CWin11StartButtonTap *tap = NULL; - AcquireSRWLockShared(&g_TapLock); - tap = g_Tap; - if (tap) - tap->AddRef(); - ReleaseSRWLockShared(&g_TapLock); - return tap; + std::shared_lock lock(g_TapMutex); + return CComPtr(g_Tap); } class CStartButtonTapFactory: public IClassFactory { public: - CStartButtonTapFactory( void ) { m_Refs = 1; } - STDMETHODIMP QueryInterface( REFIID riid, void **ppv ) { if (!ppv) @@ -726,8 +712,8 @@ class CStartButtonTapFactory: public IClassFactory return S_OK; } - STDMETHODIMP_(ULONG) AddRef( void ) { return (ULONG)InterlockedIncrement(&m_Refs); } - STDMETHODIMP_(ULONG) Release( void ) { return (ULONG)InterlockedDecrement(&m_Refs); } + STDMETHODIMP_(ULONG) AddRef( void ) { return ++m_Refs; } + STDMETHODIMP_(ULONG) Release( void ) { return --m_Refs; } STDMETHODIMP CreateInstance( IUnknown *outer, REFIID riid, void **ppv ) { @@ -755,7 +741,7 @@ class CStartButtonTapFactory: public IClassFactory } private: - LONG m_Refs; + std::atomic m_Refs{ 1 }; }; static CStartButtonTapFactory g_Factory; @@ -785,12 +771,12 @@ static DWORD WINAPI ConnectAttemptThread( LPVOID param ) return 0; } -static DWORD FinishConnectThread( HMODULE moduleReference, HMODULE runtime, bool resetConnectionState ) +static DWORD FinishConnectThread( HMODULE moduleReference, HMODULE runtime, bool connected ) { if (runtime) FreeLibrary(runtime); - if (resetConnectionState) - InterlockedExchange(&g_ConnectStarted, 0); + if (!connected) + g_ConnectStarted.store(false); // Keep a private StartMenuHelper reference while this worker is running. // Release it atomically with thread termination so a failed diagnostics @@ -804,20 +790,20 @@ static DWORD WINAPI ConnectThread( LPVOID param ) HMODULE moduleReference = (HMODULE)param; HMODULE runtime = LoadLibraryEx(L"Windows.UI.Xaml.dll", NULL, LOAD_LIBRARY_SEARCH_SYSTEM32); if (!runtime) - return FinishConnectThread(moduleReference, NULL, true); + return FinishConnectThread(moduleReference, NULL, false); InitXamlDiagnosticsEx_t init = (InitXamlDiagnosticsEx_t)GetProcAddress(runtime, "InitializeXamlDiagnosticsEx"); if (!init) - return FinishConnectThread(moduleReference, runtime, true); + return FinishConnectThread(moduleReference, runtime, false); HMODULE module = GetThisModule(); wchar_t dllPath[MAX_PATH]; if (!module || !GetModuleFileName(module, dllPath, _countof(dllPath))) - return FinishConnectThread(moduleReference, runtime, true); + return FinishConnectThread(moduleReference, runtime, false); const wchar_t *endpoints[] = { L"VisualDiagConnection1", L"VisualDiagConnection2" }; HRESULT last = E_FAIL; - for (int retry = 0; retry < 8 && InterlockedCompareExchange(&g_StartButtonActive, 0, 0); retry++) + for (int retry = 0; retry < 8 && g_StartButtonActive.load(); retry++) { for (int i = 0; i < _countof(endpoints); i++) { @@ -843,18 +829,19 @@ static DWORD WINAPI ConnectThread( LPVOID param ) } LogToFile(STARTUP_LOG, L"Win11StartButton: connection failed 0x%08X", last); - return FinishConnectThread(moduleReference, runtime, true); + return FinishConnectThread(moduleReference, runtime, false); } static void EnsureConnection( void ) { - if (InterlockedCompareExchange(&g_ConnectStarted, 1, 0) != 0) + bool expected = false; + if (!g_ConnectStarted.compare_exchange_strong(expected, true)) return; HMODULE moduleReference = NULL; if (!GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS, (LPCTSTR)&ConnectThread, &moduleReference)) { - InterlockedExchange(&g_ConnectStarted, 0); + g_ConnectStarted.store(false); return; } @@ -866,21 +853,20 @@ static void EnsureConnection( void ) else { FreeLibrary(moduleReference); - InterlockedExchange(&g_ConnectStarted, 0); + g_ConnectStarted.store(false); } } extern "C" void StartWin11StartButtonTap( BOOL enabled, BOOL allTaskbars ) { - InterlockedExchange(&g_StartButtonEnabled, enabled ? 1 : 0); - InterlockedExchange(&g_AllTaskbars, allTaskbars ? 1 : 0); - InterlockedExchange(&g_StartButtonActive, 1); + g_StartButtonEnabled.store(enabled != FALSE); + g_AllTaskbars.store(allTaskbars != FALSE); + g_StartButtonActive.store(true); - CWin11StartButtonTap *tap = GetTapRef(); + auto tap = GetTapRef(); if (tap) { tap->RequestApply(false); - tap->Release(); return; } @@ -889,16 +875,15 @@ extern "C" void StartWin11StartButtonTap( BOOL enabled, BOOL allTaskbars ) extern "C" void UpdateWin11StartButtonTap( BOOL enabled, BOOL allTaskbars ) { - InterlockedExchange(&g_StartButtonEnabled, enabled ? 1 : 0); - InterlockedExchange(&g_AllTaskbars, allTaskbars ? 1 : 0); + g_StartButtonEnabled.store(enabled != FALSE); + g_AllTaskbars.store(allTaskbars != FALSE); - CWin11StartButtonTap *tap = GetTapRef(); + auto tap = GetTapRef(); if (tap) { tap->RequestApply(false); - tap->Release(); } - else if (InterlockedCompareExchange(&g_StartButtonActive, 0, 0)) + else if (g_StartButtonActive.load()) { EnsureConnection(); } @@ -906,14 +891,13 @@ extern "C" void UpdateWin11StartButtonTap( BOOL enabled, BOOL allTaskbars ) extern "C" void StopWin11StartButtonTap( void ) { - InterlockedExchange(&g_StartButtonActive, 0); + g_StartButtonActive.store(false); - CWin11StartButtonTap *tap = GetTapRef(); + auto tap = GetTapRef(); if (tap) { HRESULT hr = tap->Deactivate(); if (FAILED(hr)) LogToFile(STARTUP_LOG, L"Win11StartButtonTap: deactivate failed 0x%08X", hr); - tap->Release(); } } From 789076a0c7ebed7421db5612f18e539df5459a07 Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Tue, 6 Oct 2026 20:29:32 +0200 Subject: [PATCH 12/16] Keep connection state after successful TAP attach --- Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp index deaf407c8..4986ea2d4 100644 --- a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp +++ b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp @@ -822,7 +822,7 @@ static DWORD WINAPI ConnectThread( LPVOID param ) if (SUCCEEDED(last)) { LogToFile(STARTUP_LOG, L"Win11StartButton: connected using %s", endpoints[i]); - return FinishConnectThread(moduleReference, runtime, false); + return FinishConnectThread(moduleReference, runtime, true); } } Sleep(500); From 676632bc47d7de7d81a011732fc832f70847822e Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Tue, 6 Oct 2026 20:31:21 +0200 Subject: [PATCH 13/16] Polish RAII locking in Win11 TAP --- .../StartMenuHelper/Win11StartButtonTap.cpp | 87 +++++++++---------- 1 file changed, 41 insertions(+), 46 deletions(-) diff --git a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp index 4986ea2d4..c57d12bff 100644 --- a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp +++ b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp @@ -251,44 +251,44 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal { std::lock_guard lock(m_Mutex); - if (mutationType == Remove) - { - auto it = m_Elements.find(element.Handle); - if (it != m_Elements.end()) + if (mutationType == Remove) { - interesting = it->second.visibilityOverride || it->second.hitTestOverride || - it->second.isStartControl || IsStartControlCandidate(it->second); - bool wasPrimary = element.Handle == m_PrimaryStart; - m_Elements.erase(it); - if (wasPrimary) - m_PrimaryStart = FindPrimaryStartLocked(); - } - } - else if (mutationType == Add) - { - StartElement record; - record.parent = relation.Parent; - record.type = element.Type ? element.Type : L""; - record.name = element.Name ? element.Name : L""; - - auto previous = m_Elements.find(element.Handle); - if (previous != m_Elements.end()) - { - record.visibilityOverride = previous->second.visibilityOverride; - record.hitTestOverride = previous->second.hitTestOverride; - record.startControlResolved = previous->second.startControlResolved; - record.isStartControl = previous->second.isStartControl; - record.discoveryOrder = previous->second.discoveryOrder; + auto it = m_Elements.find(element.Handle); + if (it != m_Elements.end()) + { + interesting = it->second.visibilityOverride || it->second.hitTestOverride || + it->second.isStartControl || IsStartControlCandidate(it->second); + bool wasPrimary = element.Handle == m_PrimaryStart; + m_Elements.erase(it); + if (wasPrimary) + m_PrimaryStart = FindPrimaryStartLocked(); + } } - else + else if (mutationType == Add) { - record.discoveryOrder = ++m_NextDiscoveryOrder; - } - m_Elements[element.Handle] = record; + StartElement record; + record.parent = relation.Parent; + record.type = element.Type ? element.Type : L""; + record.name = element.Name ? element.Name : L""; - interesting = IsStartControlCandidate(record) || IsStartGlyph(record) || - IsUnderStartButtonLocked(record.parent); - } + auto previous = m_Elements.find(element.Handle); + if (previous != m_Elements.end()) + { + record.visibilityOverride = previous->second.visibilityOverride; + record.hitTestOverride = previous->second.hitTestOverride; + record.startControlResolved = previous->second.startControlResolved; + record.isStartControl = previous->second.isStartControl; + record.discoveryOrder = previous->second.discoveryOrder; + } + else + { + record.discoveryOrder = ++m_NextDiscoveryOrder; + } + m_Elements[element.Handle] = record; + + interesting = IsStartControlCandidate(record) || IsStartGlyph(record) || + IsUnderStartButtonLocked(record.parent); + } } if (interesting) @@ -380,9 +380,8 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal InstanceHandle GetStartAncestor( InstanceHandle handle ) { + std::lock_guard lock(m_Mutex); InstanceHandle result = 0; - { - std::lock_guard lock(m_Mutex); auto it = m_Elements.find(handle); if (it != m_Elements.end()) { @@ -400,7 +399,6 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal parent = pit->second.parent; } } - } return result; } @@ -494,8 +492,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal void SetControlClassification( InstanceHandle handle, bool isStartControl ) { - { - std::lock_guard lock(m_Mutex); + std::lock_guard lock(m_Mutex); auto it = m_Elements.find(handle); if (it != m_Elements.end()) { @@ -503,7 +500,6 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal it->second.isStartControl = isStartControl; m_PrimaryStart = FindPrimaryStartLocked(); } - } } HRESULT FindProperty( InstanceHandle handle, const wchar_t *name, unsigned int *index, CString *typeName ) @@ -565,8 +561,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal void SetOverrideFlags( InstanceHandle handle, bool *visibility, bool *hitTest ) { - { - std::lock_guard lock(m_Mutex); + std::lock_guard lock(m_Mutex); auto it = m_Elements.find(handle); if (it != m_Elements.end()) { @@ -575,7 +570,6 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal if (hitTest) it->second.hitTestOverride = *hitTest; } - } } void ApplyState( bool enabled ) @@ -586,8 +580,9 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal std::vector> elements; { std::lock_guard lock(m_Mutex); - for (auto it = m_Elements.begin(); it != m_Elements.end(); ++it) - elements.push_back(*it); + elements.reserve(m_Elements.size()); + for (const auto &element : m_Elements) + elements.push_back(element); } // Start and Task View share ExperienceToggleButton#LaunchListButton on @@ -611,7 +606,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal InstanceHandle primaryStart = 0; { std::lock_guard lock(m_Mutex); - primaryStart = m_PrimaryStart; + primaryStart = m_PrimaryStart; } const bool allTaskbars = g_AllTaskbars.load(); From 39b84dcf9143e5ee2d71a43ad1029c72a804256d Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Tue, 6 Oct 2026 20:38:39 +0200 Subject: [PATCH 14/16] Remove redundant XAML connection attempt thread --- .../StartMenuHelper/Win11StartButtonTap.cpp | 32 +++---------------- 1 file changed, 4 insertions(+), 28 deletions(-) diff --git a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp index c57d12bff..f69f8edec 100644 --- a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp +++ b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp @@ -750,22 +750,6 @@ HRESULT GetWin11StartButtonTapClassObject( REFCLSID clsid, REFIID riid, LPVOID * typedef HRESULT (WINAPI *InitXamlDiagnosticsEx_t)( LPCWSTR, DWORD, LPCWSTR, LPCWSTR, CLSID, LPCWSTR ); -struct ConnectAttempt -{ - InitXamlDiagnosticsEx_t init; - const wchar_t *endpoint; - wchar_t dllPath[MAX_PATH]; - HRESULT hr; -}; - -static DWORD WINAPI ConnectAttemptThread( LPVOID param ) -{ - ConnectAttempt *attempt = (ConnectAttempt*)param; - attempt->hr = attempt->init(attempt->endpoint, GetCurrentProcessId(), NULL, - attempt->dllPath, CLSID_OpenShellStartButtonTap, NULL); - return 0; -} - static DWORD FinishConnectThread( HMODULE moduleReference, HMODULE runtime, bool connected ) { if (runtime) @@ -802,18 +786,8 @@ static DWORD WINAPI ConnectThread( LPVOID param ) { for (int i = 0; i < _countof(endpoints); i++) { - ConnectAttempt attempt = {}; - attempt.init = init; - attempt.endpoint = endpoints[i]; - Strcpy(attempt.dllPath, _countof(attempt.dllPath), dllPath); - attempt.hr = E_FAIL; - - HANDLE thread = CreateThread(NULL, 0, ConnectAttemptThread, &attempt, 0, NULL); - if (!thread) - continue; - WaitForSingleObject(thread, INFINITE); - CloseHandle(thread); - last = attempt.hr; + last = init(endpoints[i], GetCurrentProcessId(), NULL, + dllPath, CLSID_OpenShellStartButtonTap, NULL); if (SUCCEEDED(last)) { LogToFile(STARTUP_LOG, L"Win11StartButton: connected using %s", endpoints[i]); @@ -829,6 +803,8 @@ static DWORD WINAPI ConnectThread( LPVOID param ) static void EnsureConnection( void ) { + // Connection probing retries endpoints and may sleep, so keep it off the + // Explorer taskbar thread. ConnectThread is the only worker we need here. bool expected = false; if (!g_ConnectStarted.compare_exchange_strong(expected, true)) return; From d95836f01b62ef2999e05a4763a90e66c992be4e Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Tue, 6 Oct 2026 20:54:20 +0200 Subject: [PATCH 15/16] Polish XAML TAP state handling --- .../StartMenuHelper/Win11StartButtonTap.cpp | 58 +++++++++---------- 1 file changed, 28 insertions(+), 30 deletions(-) diff --git a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp index f69f8edec..45168ef42 100644 --- a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp +++ b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp @@ -22,7 +22,6 @@ #include #include #include -#include #include static const GUID CLSID_OpenShellStartButtonTap = @@ -95,7 +94,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal ~CWin11StartButtonTap( void ) { { - std::unique_lock lock(g_TapMutex); + std::unique_lock lock(g_TapMutex); if (g_Tap == this) g_Tap = NULL; } @@ -110,7 +109,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal DestroyWindow(dispatch); } - g_ConnectStarted.store(false); + g_ConnectStarted = false; _AtlModule.Unlock(); } @@ -159,7 +158,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal } { - std::unique_lock lock(g_TapMutex); + std::unique_lock lock(g_TapMutex); if (g_Tap == this) g_Tap = NULL; } @@ -168,7 +167,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal m_Site.Release(); { - std::lock_guard lock(m_Mutex); + std::lock_guard lock(m_Mutex); m_Elements.clear(); m_PrimaryStart = 0; m_NextDiscoveryOrder = 0; @@ -184,11 +183,10 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal DestroyWindow(dispatch); } - g_ConnectStarted.store(false); + g_ConnectStarted = false; return S_OK; } - CComPtr newSite = site; CComPtr newVisual; // XAML Diagnostics keeps the TAP site object and its module loaded for @@ -219,12 +217,12 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal return hr; } - m_Site = std::move(newSite); - m_Visual = std::move(newVisual); + m_Site = site; + m_Visual = newVisual; m_Advised = true; { - std::unique_lock lock(g_TapMutex); + std::unique_lock lock(g_TapMutex); g_Tap = this; } @@ -250,7 +248,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal bool interesting = false; { - std::lock_guard lock(m_Mutex); + std::lock_guard lock(m_Mutex); if (mutationType == Remove) { auto it = m_Elements.find(element.Handle); @@ -334,7 +332,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal } if (msg == WM_OS_STARTBUTTON_APPLY && tap) { - bool enabled = g_StartButtonActive.load() && g_StartButtonEnabled.load(); + bool enabled = g_StartButtonActive && g_StartButtonEnabled; tap->ApplyState(enabled); return 0; } @@ -380,7 +378,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal InstanceHandle GetStartAncestor( InstanceHandle handle ) { - std::lock_guard lock(m_Mutex); + std::lock_guard lock(m_Mutex); InstanceHandle result = 0; auto it = m_Elements.find(handle); if (it != m_Elements.end()) @@ -492,7 +490,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal void SetControlClassification( InstanceHandle handle, bool isStartControl ) { - std::lock_guard lock(m_Mutex); + std::lock_guard lock(m_Mutex); auto it = m_Elements.find(handle); if (it != m_Elements.end()) { @@ -561,7 +559,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal void SetOverrideFlags( InstanceHandle handle, bool *visibility, bool *hitTest ) { - std::lock_guard lock(m_Mutex); + std::lock_guard lock(m_Mutex); auto it = m_Elements.find(handle); if (it != m_Elements.end()) { @@ -579,7 +577,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal std::vector> elements; { - std::lock_guard lock(m_Mutex); + std::lock_guard lock(m_Mutex); elements.reserve(m_Elements.size()); for (const auto &element : m_Elements) elements.push_back(element); @@ -605,11 +603,11 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal InstanceHandle primaryStart = 0; { - std::lock_guard lock(m_Mutex); + std::lock_guard lock(m_Mutex); primaryStart = m_PrimaryStart; } - const bool allTaskbars = g_AllTaskbars.load(); + const bool allTaskbars = g_AllTaskbars; for (size_t i = 0; i < elements.size(); i++) { @@ -688,7 +686,7 @@ class CWin11StartButtonTap: public IObjectWithSite, public IVisualTreeServiceCal static CComPtr GetTapRef( void ) { - std::shared_lock lock(g_TapMutex); + std::shared_lock lock(g_TapMutex); return CComPtr(g_Tap); } @@ -755,7 +753,7 @@ static DWORD FinishConnectThread( HMODULE moduleReference, HMODULE runtime, bool if (runtime) FreeLibrary(runtime); if (!connected) - g_ConnectStarted.store(false); + g_ConnectStarted = false; // Keep a private StartMenuHelper reference while this worker is running. // Release it atomically with thread termination so a failed diagnostics @@ -782,7 +780,7 @@ static DWORD WINAPI ConnectThread( LPVOID param ) const wchar_t *endpoints[] = { L"VisualDiagConnection1", L"VisualDiagConnection2" }; HRESULT last = E_FAIL; - for (int retry = 0; retry < 8 && g_StartButtonActive.load(); retry++) + for (int retry = 0; retry < 8 && g_StartButtonActive; retry++) { for (int i = 0; i < _countof(endpoints); i++) { @@ -812,7 +810,7 @@ static void EnsureConnection( void ) HMODULE moduleReference = NULL; if (!GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS, (LPCTSTR)&ConnectThread, &moduleReference)) { - g_ConnectStarted.store(false); + g_ConnectStarted = false; return; } @@ -824,15 +822,15 @@ static void EnsureConnection( void ) else { FreeLibrary(moduleReference); - g_ConnectStarted.store(false); + g_ConnectStarted = false; } } extern "C" void StartWin11StartButtonTap( BOOL enabled, BOOL allTaskbars ) { - g_StartButtonEnabled.store(enabled != FALSE); - g_AllTaskbars.store(allTaskbars != FALSE); - g_StartButtonActive.store(true); + g_StartButtonEnabled = enabled != FALSE; + g_AllTaskbars = allTaskbars != FALSE; + g_StartButtonActive = true; auto tap = GetTapRef(); if (tap) @@ -846,15 +844,15 @@ extern "C" void StartWin11StartButtonTap( BOOL enabled, BOOL allTaskbars ) extern "C" void UpdateWin11StartButtonTap( BOOL enabled, BOOL allTaskbars ) { - g_StartButtonEnabled.store(enabled != FALSE); - g_AllTaskbars.store(allTaskbars != FALSE); + g_StartButtonEnabled = enabled != FALSE; + g_AllTaskbars = allTaskbars != FALSE; auto tap = GetTapRef(); if (tap) { tap->RequestApply(false); } - else if (g_StartButtonActive.load()) + else if (g_StartButtonActive) { EnsureConnection(); } @@ -862,7 +860,7 @@ extern "C" void UpdateWin11StartButtonTap( BOOL enabled, BOOL allTaskbars ) extern "C" void StopWin11StartButtonTap( void ) { - g_StartButtonActive.store(false); + g_StartButtonActive = false; auto tap = GetTapRef(); if (tap) From 941bef152d3db0362ab94ec11508992067955d4e Mon Sep 17 00:00:00 2001 From: YellowNest <59575587+YellowNest@users.noreply.github.com> Date: Tue, 6 Oct 2026 21:03:16 +0200 Subject: [PATCH 16/16] Unify XAML connection failure cleanup --- .../StartMenuHelper/Win11StartButtonTap.cpp | 23 ++++++++----------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp index 45168ef42..a987ecd95 100644 --- a/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp +++ b/Src/StartMenu/StartMenuHelper/Win11StartButtonTap.cpp @@ -808,22 +808,19 @@ static void EnsureConnection( void ) return; HMODULE moduleReference = NULL; - if (!GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS, (LPCTSTR)&ConnectThread, &moduleReference)) - { - g_ConnectStarted = false; - return; - } - - HANDLE thread = CreateThread(NULL, 0, ConnectThread, moduleReference, 0, NULL); - if (thread) - { - CloseHandle(thread); - } - else + if (GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS, (LPCTSTR)&ConnectThread, &moduleReference)) { + HANDLE thread = CreateThread(NULL, 0, ConnectThread, moduleReference, 0, NULL); + if (thread) + { + CloseHandle(thread); + return; + } FreeLibrary(moduleReference); - g_ConnectStarted = false; } + + // A worker was not started, so connection can be attempted again later. + g_ConnectStarted = false; } extern "C" void StartWin11StartButtonTap( BOOL enabled, BOOL allTaskbars )