Skip to content

ci: Added testing with latest N4E changes on Prs - #4178

Open
michalChrobot wants to merge 1 commit into
develop-3.x.xfrom
test-latest-n4e
Open

michalChrobot wants to merge 1 commit into
develop-3.x.xfrom
test-latest-n4e

Conversation

@michalChrobot

Copy link
Copy Markdown
Member

Purpose of this PR

We started having a discussion that as we are getting closer to GA we could just run unified-netcode tests with latest landed N4E changes. So this PR follows-up on this and we can discuss this here

Note that I would use 6000.7 editors in that for stability (reason why we don't want to run trunk on our PRs) and the fact that this editor is closer to getting released and we support it anyway

Jira ticket

Will do

Documentation

N/A

Testing & QA (How your changes can be verified during release Playtest)

Will make sure that job works correctly and is green

Up-port

N/A

Backports

N/A

@michalChrobot michalChrobot self-assigned this Oct 2, 2026
@u-pr

u-pr Bot commented Oct 2, 2026

Copy link
Copy Markdown

⚠️ Some settings were ignored in '.pr_agent.toml (repository root)' repo settings

Check the configuration's TOML syntax, permitted settings, and size limit. See the error below.


Error message:
Ignored prohibited settings: github_app.handle_pr_actions. Permitted settings were applied.

Configuration content:
# This is the configuration for the u-pr bot
# https://github.cds.internal.unity3d.com/unity/u-pr
# For configuration of this file:
# https://developer.portal.internal.unity.com/catalog/default/component/u-pr/docs/configuration/automatic_runs/

[github_app]
handle_pr_actions = ['opened', 'ready_for_review']  # PR events that auto-run pr_commands
pr_commands       = ["/harness-review"]             # what runs on those events
reviewer_commands = ["/harness-review"]             # what runs when @u-pr is added as reviewer

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Ship it

The change adds unified playmode testing against N4E trunk to code-change PR checks. I examined the trigger, generated job, manifest resolution, and unified test guards and found no actionable issues.

Reviewed commit f464296

🤖 Helpful? 👍/👎

@codecov-github-com

codecov-github-com Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@              Coverage Diff               @@
##           develop-3.x.x    #4178   +/-   ##
==============================================
  Coverage          78.19%   78.19%           
==============================================
  Files                153      153           
  Lines              26272    26272           
==============================================
  Hits               20544    20544           
  Misses              5728     5728           
Flag Coverage Δ
NGOv2_project_testproject_ubuntu 76.64% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
com.unity.netcode.gameobjects 78.19% <ø> (ø)

ℹ️ Need help interpreting these results?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants