ci: Added testing with latest N4E changes on Prs - #4178
Open
michalChrobot wants to merge 1 commit into
Open
michalChrobot wants to merge 1 commit into
michalChrobot wants to merge 1 commit into
Conversation
michalChrobot
requested review from
a team,
EmandM and
NoelStephensUnity
as code owners
October 2, 2026 14:02
|
Check the configuration's TOML syntax, permitted settings, and size limit. See the error below. Error message: Configuration content:# This is the configuration for the u-pr bot
# https://github.cds.internal.unity3d.com/unity/u-pr
# For configuration of this file:
# https://developer.portal.internal.unity.com/catalog/default/component/u-pr/docs/configuration/automatic_runs/
[github_app]
handle_pr_actions = ['opened', 'ready_for_review'] # PR events that auto-run pr_commands
pr_commands = ["/harness-review"] # what runs on those events
reviewer_commands = ["/harness-review"] # what runs when @u-pr is added as reviewer
|
There was a problem hiding this comment.
💡 Harness Review
The change adds unified playmode testing against N4E trunk to code-change PR checks. I examined the trigger, generated job, manifest resolution, and unified test guards and found no actionable issues.
Reviewed commit f464296
🤖 Helpful? 👍/👎
EmandM
approved these changes
Oct 2, 2026
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-3.x.x #4178 +/- ##
==============================================
Coverage 78.19% 78.19%
==============================================
Files 153 153
Lines 26272 26272
==============================================
Hits 20544 20544
Misses 5728 5728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
We started having a discussion that as we are getting closer to GA we could just run unified-netcode tests with latest landed N4E changes. So this PR follows-up on this and we can discuss this here
Note that I would use 6000.7 editors in that for stability (reason why we don't want to run trunk on our PRs) and the fact that this editor is closer to getting released and we support it anyway
Jira ticket
Will do
Documentation
N/A
Testing & QA (How your changes can be verified during release Playtest)
Will make sure that job works correctly and is green
Up-port
N/A
Backports
N/A