From d707a1e27289696f0d2f4ed25314255a5059e919 Mon Sep 17 00:00:00 2001 From: Pierre Jeanjacquot <26487010+PierreJeanjacquot@users.noreply.github.com> Date: Thu, 1 Oct 2026 12:12:18 +0000 Subject: [PATCH] fix(docker-promote): quote version in tag suffix removal The unquoted `$version` inside `${TAG%-v$version}` was interpreted as a glob pattern (shellcheck SC2295), so glob characters in a version would strip more than the literal `-v` suffix. Quote it so the suffix is matched literally. Release-please versions never contain glob characters, so the computed component is unchanged in practice. --- .github/workflows/docker-promote.yml | 2 +- docker-promote/workflow-sha256 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/docker-promote.yml b/.github/workflows/docker-promote.yml index 819e739..6ed0e38 100644 --- a/.github/workflows/docker-promote.yml +++ b/.github/workflows/docker-promote.yml @@ -82,7 +82,7 @@ jobs: version="${TAG#v}" component="." else - component="${TAG%-v$version}" + component="${TAG%-v"$version"}" fi if [ ! -f ".release-please-manifest.json" ]; then diff --git a/docker-promote/workflow-sha256 b/docker-promote/workflow-sha256 index 7f535e0..cc1689e 100644 --- a/docker-promote/workflow-sha256 +++ b/docker-promote/workflow-sha256 @@ -1 +1 @@ -a85a46fd1ad50e26807800e0ede8109b3e034abd885117e8a844748d64347f1e +d484d87dfb116f8f46519733d75e444f3f417f83eb19b21423420bf5ec9a2c8c