Skip to content

cli: flags after the brief, token counts, ssh paths and auth failures behave - #1669

Open
santoshkumarradha wants to merge 3 commits into
devfrom
fix/cli-provider-audit
Open

santoshkumarradha wants to merge 3 commits into
devfrom
fix/cli-provider-audit

Conversation

@santoshkumarradha

Copy link
Copy Markdown
Member

Re-cut from #1604 onto current dev: only the CLI and provider items.

Not included: #1558's workspace default. --workspace defaulting to the home directory is documented and used by the hosted road, so changing it is not a safe drive-by; that item stays open. #1566 is already on dev.

Fixes #1567
Fixes #1580
Fixes #1584
Fixes #1590
Part of #1558

… behave

Re-cut from #1604.

- delegate programs read flags wherever they sit, refuse unknown ones, and
  `--` still ends them (#1567)
- `do --json` on the run engine carries input and output tokens (#1558, token item)
- the ssh control-path check counts OpenSSH temporary suffix (#1580)
- an unsubmitted run with passing checks says so and gives the command to
  submit; the exit code stays 2 (#1584)
- a 401 or 403 is an auth failure everywhere and is not retried as a
  provider error; the failure names the key source on the default service, and
  `codeaf do` carries the reason to its error field (#1590)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant