Task template fixes for running RO+DD+QC DAQ - #861
Conversation
| envVars: | ||
| - O2_DETECTOR | ||
| - O2_PARTITION | ||
| - OCC_CONTROL_PORT |
There was a problem hiding this comment.
Why did you remove this? As far as I know dpl needs to have control port specified as it is a base for multiple different processes
There was a problem hiding this comment.
I just checked, it works with and without it... But I removed it only due to confusion, i can put it back.
There was a problem hiding this comment.
this is a list of required env vars for given template, but it is only check. So if you remove it from the yaml and run it, everything will still work, because ECS is inserting the environment variables eitherway. This is basically sanity check for us to know what needs to be passed when running by hand.
There was a problem hiding this comment.
but now looking at it: the name should be "requiredEnvVars", so it is more clear
There was a problem hiding this comment.
btw, initially that commit was removing OCC_CONTROL_PORT in all task templates, but i rebased it against your latest branch version and that was the only one left. I removed the commit completely now.
but now looking at it the name should be "requiredEnvVars", so it is more clear
indeed it would be clearer.
There was a problem hiding this comment.
yes, I know... that was my mistake when I created the dpl branch on wrong commit and forgot to rebase the dpl branch to master when master was updated
ce96d17 to
8c3e9a6
Compare
2 participants
No description provided.