Repository navigation
fix: MCP HTTP transport protocol hardening - #299
Merged
Merged
Conversation
Send notifications/initialized after initialize (best-effort) so strict spec-compliant remote servers accept tools/list. Verify the JSON-RPC response id matches the request — notification or out-of-order frames now error instead of silently returning an empty result. SSE parsing is now spec-compliant: data: lines of one event are joined with newlines, CRLF handled, notification frames skipped, the matching-id frame selected.
Verify response id before honoring error objects on the plain-JSON path; matchSSEFrame scans past unrelated interleaved responses; dead sseData wrapper removed; tests echo request ids.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
odek | 93a3a8b | Commit Preview URL Branch Preview URL |
Oct 04 2026, 03:04 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sends notifications/initialized after initialize (best-effort) for spec-compliant remote servers. Verifies JSON-RPC response ids on both plain-JSON and SSE paths — notification, out-of-order, or spoofed-error frames now error instead of silently returning empty or attacker-chosen text. SSE parsing is spec-compliant: multi-line data joined per event, CRLF handled, notification and unrelated interleaved frames skipped, matching-id frame selected. Adversarially reviewed; regression tests included.