Skip to content

Change the method of get file extension. - #475

Open
myafer wants to merge 10 commits into
Baseflow:mainfrom
myafer:develop
Open

myafer wants to merge 10 commits into
Baseflow:mainfrom
myafer:develop

Conversation

@myafer

@myafer myafer commented Dec 4, 2024 •

Copy link
Copy Markdown

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix.

⤵️ What is the current behavior?

When the http response's Content-Type is not image and the _resizeimage is not work.

🆕 What is the new behavior (if this is a feature change)?

The new method is get files extension with the file's binary data.

💥 Does this PR introduce a breaking change?

No.

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@cedvdb

cedvdb commented Apr 22, 2025 •

Copy link
Copy Markdown

@renefloor could this be reviewed ? using magic bytes is preferred over a potentially missing extension

@rickdijk
rickdijk changed the base branch from develop to main September 16, 2026 00:24
settings.gradle and pubspec.yaml conflicted on lines main has since
moved past (kotlin 2.3.20, build_runner ^2.14.0), so main's lines are
kept. image_cache_manager.dart reformatted with dart format.

Co-Authored-By: Claude <noreply@anthropic.com>
@rickdijk

Copy link
Copy Markdown
Contributor

main has moved since you opened this, and our changes to example/android/settings.gradle and pubspec.yaml left it conflicting. I have merged main into your branch and resolved those conflicts. In both files main had already moved past the versions this pull request set (Kotlin 2.3.20 rather than 1.8.22, and build_runner ^2.14.0 rather than ^2.4.9), so I kept main's lines there. Your image_cache_manager.dart change is untouched apart from one line reflowed by dart format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants