Conversation
cache_store_test.dart conflicted only with main's format pass (cce9a65). Took main's formatting and re-applied this branch's change. Co-Authored-By: Claude <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix. This carries #477 by @js2702, whose branch does not allow maintainer edits, so it could not be updated in place. Both of their commits are kept, with
mainmerged on top.emptyCache()only deletes the files the cache store knows about. Files on disk that are missing from the store, for example after a desync like the ones in #476, are never cleaned up and keep filling the cache directory.🆕 What is the new behavior (if this is a feature change)?
emptyCache()deletes the whole cache directory through a newFileSystem.deleteCacheDir(), then removes all objects from the store.IOFileSystem,MemoryCacheSystemand the testFileSystemimplement it, andMemoryCacheSystemrecreates its temp directory on next use.💥 Does this PR introduce a breaking change?
Yes.
FileSystemgets a new abstract method,deleteCacheDir(), so apps that implement their ownFileSystemmust add it.🐛 Recommendations for testing
Format, analyze and tests pass locally on Flutter 3.47.2; CI on 3.47.4 is the check that counts. The existing
emptyCachetest now also writes a file that is not in the store and checks that every file is gone.📝 Links to relevant issues/docs
Supersedes #477. Related: #476.
🤔 Checklist before submitting
Co-authored-by: Jorge Sardina jorge@skilldevs.com
🤖 Generated with Claude Code