chore(root): scope HSM codeowners to sdk-core crypto paths - #9875
Merged
2 commits merged intoOct 1, 2026
Merged
2 commits merged into
2 commits merged into
Conversation
The blanket `/modules/sdk-core/` line routed every sdk-core PR to `@BitGo/hsm` regardless of whether it touched cryptography, creating noise in the team's external review queue. Replace it with explicit ownership on `src/bitgo/tss/` and `src/account-lib/mpc/`, the subdirectories that are actually pure MPC/TSS cryptography with no coin-specific branching. TICKET: HSM-645 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
joeypinz
reviewed
Sep 30, 2026
Per PR review feedback, wallet-core and wallet-core-india should remain co-owners of the tss/ and account-lib/mpc/ paths alongside hsm, rather than HSM being the sole owner. TICKET: HSM-645 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
joeypinz
approved these changes
Sep 30, 2026
yogeshramesh-pixel
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@BitGo/hsmownership from/modules/sdk-core/, which was routing every sdk-core PR to the HSM team's review queue regardless of whether it touched cryptography (see linked ticket for examples of the resulting noise).@BitGo/hsmownership onsrc/bitgo/tss/andsrc/account-lib/mpc/— the subdirectories that are actually pure MPC/TSS cryptography (ECDSA/EdDSA/RedPallas, Shamir secret sharing, curve/Paillier primitives, HD-tree derivation) with no coin-family branching.src/bitgo/keychain/was considered but intentionally excluded — it's wallet/API orchestration (delegates tobaseCoin.getFamily(), makes HTTP calls) rather than core crypto, and is better owned by the wallet team.Test plan
yarn commitlintpassed via pre-commit hookRef: https://linear.app/bitgo/issue/HSM-645/clean-up-hsm-team-code-ownership-in-bitgojs
🤖 Generated with Claude Code