Repository navigation
test: regression tests for the pandas-2 fixes in #1325 - #1320
Open
EnvDroneSense wants to merge 1 commit into
Open
EnvDroneSense wants to merge 1 commit into
EnvDroneSense wants to merge 1 commit into
Conversation
EnvDroneSense
requested review from
chahank,
emanuel-schmid and
peanutfun
as code owners
September 7, 2026 21:09
emanuel-schmid
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for pointing this out, the suggested fixes and writing tests.
I've made some remarks. You can address them as you wish.
In any case, I'm going to just apply minimal fixes without much ado soon. 🤷 There bugs and ought to be removed.
EnvDroneSense
force-pushed
the
fix/1319-pandas2-removals
branch
from
September 30, 2026 11:30
0a248d3 to
4a5b1ab
Compare
Author
|
@emanuel-schmid thanks for the review (sorry for the delay, the semester has just started, so it was quite busy). I rebased onto your fixes on develop and reworked the tests as suggested:
So the PR is now is tests + changelog only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
LitPop.from_shape_and_countries(GeoSeries shape, and overlapping shapes),impact_data.hit_country_per_hazard,calibration_opt.calib_allandcalibration_opt.calib_instance(multi-rowdf_outwithyearly_impact=True).The source changes originally in this PR were dropped in favour of #1325.
This PR fixes #1319
PR Author Checklist
develop)PR Reviewer Checklist