London | 26-ITP-Sep | Anita Amirhaeri | Sprint 3 | coursework/sprint 3

[anitahy73]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Task code

CYF-1053

Changelist

oursework/sprint 3

Questions

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	54f45d7
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ac5503183e67300083c5b8d
😎 Deploy Preview	https://deploy-preview-1636--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[github-actions]

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/1-count.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/1-count.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/1-count.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/1-count.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/1-count.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/1-count.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[abdishakoor-dev]

Before I can review your Sprint 3 work, this PR needs to change Sprint 3 files only. At the moment it also changes 5 Sprint 2 files, which is why the bot keeps taking the Needs Review label off:

• Sprint-2/1-key-exercises/1-count.js
• Sprint-2/1-key-exercises/3-paths.js
• Sprint-2/2-mandatory-errors/4.js
• Sprint-2/3-mandatory-interpret/1-percentage-change.js
• Sprint-2/3-mandatory-interpret/3-to-pounds.js

Your Sprint 2 work is already completed. It's in your Sprint 2 PR (#1553), which is already marked Complete. So we can simply remove the Sprint 2 files from this PR:

1. Open the project in VS Code. In the bottom-left corner, check the branch name says acoursework/sprint-3. If it doesn't, click it and pick acoursework/sprint-3 from the list.
2. Open a terminal: Terminal menu, then New Terminal.
3. Copy and paste these lines one at a time, pressing Enter after each:

git pull
git fetch https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals.git main
git checkout FETCH_HEAD -- Sprint-2
git commit -m "Remove Sprint-2 changes from this PR"
git push

4. Refresh this page and click the Files changed tab at the top. You should see only Sprint-3 files (10 of them), and no Sprint-2 files.
5. Add the Needs Review label again. This time it will stay.

If anything looks different from what I've described, or you get an error, post a screenshot here and I'll help you through it.

[github-actions]

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/1-count.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/1-count.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.