Repository navigation
Manchester | 26-ITP-Sep | Salah Alsabhi | Sprint 1 | format clock edge cases - #1642
Open
salahalsabhi wants to merge 2 commits into
Open
salahalsabhi wants to merge 2 commits into
salahalsabhi wants to merge 2 commits into
Conversation
salahalsabhi
added
the
Needs Review
Author
|
Fixed formatAs12HourClock for edge cases (midnight, noon, minutes). |
cjyuan
reviewed
Oct 5, 2026
|
|
||
| function formatAs12HourClock(time) { | ||
| const hours = Number(time.slice(0, 2)); | ||
| const minutes = time.slice(3, 5); |
Contributor
There was a problem hiding this comment.
Note: The .slice() method supports negative indices, which count positions from the end of the string.
For example, str.slice(-3) returns the substring containing last three characters from str.
Comment on lines
9
to
12
| let displayHour = hours % 12; | ||
| if (displayHour === 0) { | ||
| displayHour = 12; | ||
| } |
Contributor
There was a problem hiding this comment.
Optional change: Simplify code on lines 9-12 into one line of code.
cjyuan
added
Reviewed
salahalsabhi
changed the title
salahalsabhi
changed the title
Author
|
Thanks for the review. Updated the PR description with the learners template, simplified displayHour to one line, and used slice(-2) for minutes. All 9 tests still pass. |
salahalsabhi
added
the
Needs Review
Contributor
|
Excellent work! |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1197
Changelist
Fixed
formatAs12HourClockfor edge cases (midnight, noon, non-zero minutes).Added tests for am/pm boundaries and times that keep minutes.