Conversation
lucic71
force-pushed
the
split-mapper
branch
from
September 29, 2026 14:21
72a716f to
fe88312
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mapper grew too big. It has 4 responsibilities at the same time:
Only the first should be in Mapper, the rest should be split.
For (2) I plan to add a new tree matcher instead of the current string matcher. To make the transition smooth I extracted the matching logic form Mapper into
cpp2rust/converter/rules/matcher.h.For (3) I added
cpp2rust/converter/rules/registry.hwhich keeps theexprs_andrules_multimaps + handles queries about the translation rules.For (4) I added
cpp2rust/converter/printer.hwhich should BTW disappear after we switch to tree matching instead of string matching.This is a building block for fixing #435