Fix sliders allowing values outside their number of stops - #5749
Merged
Merged
Conversation
Clicking left and right only did -1 & +1 without checking the validity of the result.
ab9rf
reviewed
Jul 11, 2026
ab9rf
approved these changes
Jul 12, 2026
Applies the same num_stops clamping to RangeSlider's click-to-step paths that Slider already had, and renames the internal slide_core class to _SliderCore per naming conventions (CamelCase, leading underscore marks it as not intended for direct instantiation).
Member
|
I've revised this PR based on the discussion above and also applied the same bug fix to |
SilasD
approved these changes
Sep 28, 2026
SilasD
left a comment
SilasD
left a comment
Contributor
There was a problem hiding this comment.
the changes you made look fine. ISTR wanting these changes but otherwise approving of the PR.
all good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking left and right only recorded -1 or +1 based on mouse position without any safeguard against potential larger frame than the slider itself. EDIT: Dragging was affected too.
If this PR makes an externally-visible change in behavior or API, please add an appropriate line to
docs/changelog.txt.