feat(arc): let a profile run on burst nodes only - #27
Merged
Merged
Conversation
burst.exclusive: true gives a profile's runner pods a required node affinity with the burst term alone, so they never land on the fixed nodes, and makes burst.max_runners the profile's whole maxRunners. It suits work the fixed nodes cannot hold, such as image builds whose Docker daemon needs more memory than they can spare. An exclusive profile takes no sizing, max_runners or autoscale. Profiles without exclusive behave as before.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
burst.exclusive. With it set, a profile's runner pods get a required node affinity that has only the burst term (no eligibility term, nothing preferred), andburst.max_runnersbecomes the profile's wholemaxRunners. The listener stays on the eligible nodes.The use case is a builder scale set whose dind sidecar needs more memory than the fixed nodes can spare. It pairs with
minRunners: 0so no burst node is kept for an idle runner. An exclusive profile rejectssizing,max_runnersandautoscale. Non-exclusive profiles render as before.Covered by filter unit tests and an overlay render test.