Improve time complexity of identity node removal - #4625
Open
0HyperCube wants to merge 4 commits into
Open
0HyperCube wants to merge 4 commits into
0HyperCube wants to merge 4 commits into
Conversation
0HyperCube
force-pushed
the
faster-identity-removal
branch
from
September 30, 2026 07:11
b3f3bdb to
f72edce
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
TrueDoctor
reviewed
Sep 30, 2026
TrueDoctor
reviewed
Sep 30, 2026
TrueDoctor
approved these changes
Sep 30, 2026
0HyperCube
force-pushed
the
faster-identity-removal
branch
from
September 30, 2026 11:25
c55551f to
09109a0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards #4572.
remove_passthrough_nodefrom O(n) to O(1) by using the cached list of dependants.OriginalLocationremove_passthrough_nodefunction works properly.