README sections, licence text, conduct contact and display example fix - #13
Merged
Merged
Conversation
agreed_rate (25.50) included a clean_room surcharge, but activation_route includes only publisher_side, and no other included option carries a price. Set agreed_rate to the 24.00 base rate and recompute derived_units (80000.00 / 24.00 x 1000 = 3333333).
- About this repository: main holds the current draft; tags mark published drafts; normative changes go through the changelog. - How to comment: anyone may comment; the working group decides dispositions (links GOVERNANCE.md). - Contributors and governance, Contact, About IAB Tech Lab, Disclaimer.
Match schema/README.md: schemas follow the first revision, after the comment period closes on 2026-10-22.
Replace the README summary with the licence, Submission clause and disclaimer from LICENSE, which follow the OpenRTB 2.x README with the specification name changed.
Sirajmx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five separate commits. Please merge with Create a merge commit to keep them separate.
1. Fix
agreed_ratein the display example (checklist 7.2)examples/line-item-display.yamlhadagreed_rate: 25.50, commented as "base 24.00 + clean_room 1.50". Butactivation_route.includedispublisher_side, and no other included option carries a price. Now:agreed_rate: 24.00, the base ratederived_units: 3333333(80000.00 / 24.00 × 1000)2. Conduct contact (4.5)
CODE_OF_CONDUCT.mdhadTBD — maintainer contact address. It now uses support@iabtechlab.com, the usual IAB Tech Lab contact. Please confirm, or name a dedicated address.3. README sections (1.4, 6.2, 6.3)
mainholds the current draft, and tags mark published drafts (linksv3.0-draft-1).4. Schema timing in the README
The Schemas section now gives the same timing as
schema/README.md: schemas follow the first revision, after the comment period closes on 2026-10-22.5. Full licence and disclaimer in the README
The README's Licence and IPR and Disclaimer sections now carry the full text from
LICENSE, following the OpenRTB 2.x README, instead of a summary. The disclaimer matches OpenRTB 2.x word for word.Pending: the working group name. OpenRTB names the "Programmatic Supply Chain Working Group"; this text says "the IAB Tech Lab working group responsible for OpenProposal" until the name is confirmed. It's a one-line change in
LICENSEand the README.Type
Editorial. No change to
spec/.Checks
Examples parse, and Appendix A still matches the body.