Conversation
GNOME/Mutter on Wayland does not implement xdg-decoration, so the window had no title bar: it could not be moved, resized or closed with the mouse. GPUI's default request for server-side decorations also makes `window_decorations()` report `Server` there, so nothing drew a frame. On Linux the window now requests client-side decorations. When GPUI reports `Decorations::Client`: - an invisible 8px border resizes the window (edges and corners, with resize cursors), plus a 1px border and shadow while not tiled; - the header's title/status area drags the window, double-click maximizes/restores, right-click opens the compositor window menu; - minimize / maximize / close buttons in the GNOME header-bar style (round, path-drawn icons) are appended to the header. Where the platform draws the frame (macOS, Windows, X11 without a compositor) all of this is a no-op. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GNOME Wayland the window has no title bar, so it can't be moved, resized or closed with the mouse (issue #6).
Mutter doesn't implement
xdg-decoration, and GPUI's default server-side request leaveswindow_decorations()reportingServer, so nothing draws a frame.This requests
WindowDecorations::Clienton Linux (as Zed does) and addssrc/decorations.rs, active only when GPUI reportsDecorations::Client:No-op on macOS, Windows and X11 without a compositor.
Tested on Ubuntu 24.04, GNOME 46 on Wayland.
cargo fmt,clippy -D warningsandcargo test --libpass. Not tested on KDE or wlroots.