hostmot2: fix bounds of the sserial global duplicate check - #4634
Merged
Merged
Conversation
The loop that tells process records apart from globals ran with i <= num_confs, reading one entry past the confs array, and dereferenced chan->confs even when the remote has no process records at all (confs == NULL), crashing the driver load on such a device. Bound the loop to num_confs, which also skips it safely for a globals-only remote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The duplicate check in get_globals_list that tells process records apart from globals runs with i <= num_confs, reading one entry past the confs array, and dereferences chan->confs even when a remote has globals but no process records (confs == NULL), crashing the driver load on such a device. Bound the loop to num_confs, which also skips it safely for a globals-only remote.
One of three candidates for @andypugh's hostmot2 SIGSEGV on master (see #4453, #4632). Split out of #4626.