Skip to content

fix(linux): keep idle Switch Pro controllers connected - #180

Open
ReenigneArcher wants to merge 1 commit into
masterfrom
fix/linux/switch-pro-periodic-report
Open

ReenigneArcher wants to merge 1 commit into
masterfrom
fix/linux/switch-pro-periodic-report

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Stream the latest Switch Pro state every 15 ms and stop UHID workers before device destruction. Add regression coverage for idle reports, state updates, shutdown, and SDL idle connection stability.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.75%. Comparing base (dc57a03) to head (5c4b857).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   70.80%   70.75%   -0.06%     
==========================================
  Files          47       47              
  Lines       10815    10818       +3     
  Branches     3796     3798       +2     
==========================================
- Hits         7658     7654       -4     
- Misses       2447     2492      +45     
+ Partials      710      672      -38     
Flag Coverage Δ
FreeBSD 52.64% <ø> (ø)
Linux-Clang 55.58% <77.77%> (+0.09%) ⬆️
Linux-GCC 66.23% <100.00%> (-0.03%) ⬇️
PowerShell 75.60% <ø> (ø)
Windows-MSVC 88.70% <ø> (-0.10%) ⬇️
Windows-MinGW-UCRT64 63.89% <ø> (ø)
macOS 44.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/uhid_backend.cpp 81.35% <100.00%> (-0.08%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc57a03...5c4b857. Read the comment docs.

Stream the latest Switch Pro state every 15 ms and stop UHID workers before device destruction. Add regression coverage for idle reports, state updates, shutdown, and SDL idle connection stability.
@sonarqubecloud

sonarqubecloud Bot commented Oct 3, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux Switch Pro UHID device repeatedly dropped by Steam due to "hid_read failure"

1 participant