Skip to content

Bug/sr ndsp 660 feedback msg retain original entity - #168

Merged
georgeRobertson merged 1 commit into
release_v010from
bug/sr-ndsp-660_feedback_msg_retain_original_entity
Sep 29, 2026
Merged

georgeRobertson merged 1 commit into
release_v010from
bug/sr-ndsp-660_feedback_msg_retain_original_entity

fix: ensure that original entity detials persisted in feedback messag…

b245abd
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Sep 28, 2026 in 44s

Annotations

Check warning on line 424 in src/dve/core_engine/backends/base/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "list(...)[0]" with "next(iter(...))" to avoid materializing the entire iterable.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDpziBZDSmfIj2RlwO3&open=AaDpziBZDSmfIj2RlwO3&pullRequest=168

Check warning on line 414 in src/dve/core_engine/backends/base/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "list(...)[0]" with "next(iter(...))" to avoid materializing the entire iterable.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDpziBZDSmfIj2RlwO2&open=AaDpziBZDSmfIj2RlwO2&pullRequest=168

Check warning on line 93 in src/dve/core_engine/message.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "ReportingEntity" to match the regular expression ^[_a-z][_a-z0-9]*$.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDpziE5DSmfIj2RlwO4&open=AaDpziE5DSmfIj2RlwO4&pullRequest=168

Check warning on line 675 in src/dve/pipeline/pipeline.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this comprehension with passing the iterable to the collection constructor call

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDpziIMDSmfIj2RlwO6&open=AaDpziIMDSmfIj2RlwO6&pullRequest=168

Check warning on line 385 in src/dve/core_engine/backends/implementations/spark/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDpzh_gDSmfIj2RlwOz&open=AaDpzh_gDSmfIj2RlwOz&pullRequest=168

Check warning on line 344 in src/dve/core_engine/backends/implementations/spark/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDpzh_gDSmfIj2RlwOy&open=AaDpzh_gDSmfIj2RlwOy&pullRequest=168

Check warning on line 391 in src/dve/core_engine/backends/implementations/spark/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDpzh_gDSmfIj2RlwO0&open=AaDpzh_gDSmfIj2RlwO0&pullRequest=168

Check failure on line 548 in src/dve/pipeline/pipeline.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDpziIMDSmfIj2RlwO5&open=AaDpziIMDSmfIj2RlwO5&pullRequest=168