refactor(js): centralize page bootstrapping into single DOMContentLoaded handler by titas-mahato · Pull Request #646 · NextCommunity/NextCommunity.github.io

titas-mahato · 2026-10-03T08:29:39Z

Closes #644

Summary

Consolidates multiple scattered DOMContentLoaded listeners in src/assets/js/script.js into a centralized bootstrap() function.

Changes

Extracted footer surge state check into initFooterSurgeState().
Extracted dev tools and console state setup into initConsoleState().
Unified all initialization routines under a single bootstrap() function on document.addEventListener("DOMContentLoaded", bootstrap).
Verified formatting and linting with Biome.

…ded handler

deepsource-io · 2026-10-03T08:30:15Z

DeepSource Code Review

We reviewed changes in e9a1615...fa7e110 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
JavaScript		Oct 3, 2026 8:29a.m.	Review ↗
Secrets		Oct 3, 2026 8:29a.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-10-03T08:30:18Z

+function initFooterSurgeState() {
  const unlockedEggs = JSON.parse(localStorage.getItem("unlockedEggs") || "[]");
  if (unlockedEggs.includes("footer_surge")) {
    finalizeFooterDot(
      document.getElementById("footer-dot-core"),
      document.getElementById("footer-dot-ping"),
    );
  }
-});
+}


Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

It is considered a best practice to avoid 'polluting' the global scope with variables that are intended to be local to the script. Global variables created from a script can produce name collisions with global variables created from another script, which will usually lead to runtime errors or unexpected behavior. It is mostly useful for browser scripts.

deepsource-io · 2026-10-03T08:30:18Z

+function bootstrap() {
+  initSkillXP();
+  initFooterSurgeState();
+  initConsoleState();
  initDotEasterEgg();
  initSkillMining();
  // Initialize the profile counter
  initProfileTracker();

  applyTheme(localStorage.getItem("theme") || "light");
  updateGameUI();
-});
+}


Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

It is considered a best practice to avoid 'polluting' the global scope with variables that are intended to be local to the script. Global variables created from a script can produce name collisions with global variables created from another script, which will usually lead to runtime errors or unexpected behavior. It is mostly useful for browser scripts.

deepsource-io · 2026-10-03T08:33:36Z

DeepSource Code Review

We reviewed changes in e9a1615...03348fa on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
JavaScript		Oct 3, 2026 9:39a.m.	Review ↗
Secrets		Oct 3, 2026 9:39a.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-10-03T08:33:40Z

+/**
+ * INITIALIZATION
+ */
+document.addEventListener("DOMContentLoaded", () => {


Function has a cyclomatic complexity of 8 with "medium" risk

A function with high cyclomatic complexity can be hard to understand and
maintain. Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A higher cyclomatic complexity indicates
that the function has more decision points and is more complex.

titas-mahato · 2026-10-03T08:42:15Z

I saw the DeepSource check failed. The first commit was flagged for global scope declarations, and when I inlined it, it was flagged for complexity.

I'm now working on wrapping the helpers in a local scope so both the scope and complexity checks pass cleanly. Will push an update in a bit.

deepsource-io · 2026-10-03T09:33:00Z

-    devPanel.classList.remove("hidden");
+(() => {
+  function initFooterSurgeState() {
+    const unlockedEggs = JSON.parse(localStorage.getItem("unlockedEggs") || "[]");


'unlockedEggs' is already declared in the upper scope on line 20 column 7

Two variables can have the same name if they're declared in different scopes. In the example below, the parameter x is said to "shadow" the variable x declared above it. The outer x can no longer be accessed inside the sum function.

Copilot

Copilot review overview

🟢 Approval recommended

The focused initialization refactor has no identified blocking regressions or unresolved findings.

Review effort: Balanced
Findings: None

What changed in this PR

Centralizes page initialization in script.js, addressing #644 by consolidating scattered DOMContentLoaded listeners.

Changes:

Extracts footer surge and console state setup into helper functions.
Groups initialization calls in one handler within an isolated scope.

File	Description
`src/assets/js/script.js`	Consolidates initialization listeners and extracts state setup helpers.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

jbampton

Thank you 🏂

refactor(js): centralize page bootstrapping into single DOMContentLoa…

fa7e110

…ded handler

titas-mahato requested review from BaseMax and jbampton as code owners October 3, 2026 08:29

github-project-automation Bot added this to Next Oct 3, 2026

deepsource-io Bot reviewed Oct 3, 2026

View reviewed changes

fix: inline bootstrap logic to prevent global scope pollution

af6784e

deepsource-io Bot reviewed Oct 3, 2026

View reviewed changes

refactor: wrap bootstrap helpers locally to satisfy complexity checks

fe1fc13

deepsource-io Bot reviewed Oct 3, 2026

View reviewed changes

fix: remove redundant unlockedEggs declaration to resolve shadowing

03348fa

jbampton added this to the Hacktoberfest 2026 milestone Oct 4, 2026

jbampton added the javascript label Oct 4, 2026

jbampton self-assigned this Oct 4, 2026

jbampton requested a balanced review from Copilot October 4, 2026 02:08

Copilot started reviewing on behalf of jbampton October 4, 2026 02:09 View session

Copilot AI reviewed Oct 4, 2026

View reviewed changes

jbampton approved these changes Oct 4, 2026

View reviewed changes

jbampton added hacktoberfest-accepted hacktoberfest waiting payment $1 labels Oct 4, 2026

jbampton merged commit b391a41 into NextCommunity:main Oct 4, 2026
16 checks passed

github-project-automation Bot moved this from Reviewer approved to Done in Next Oct 4, 2026

jbampton added paid and removed waiting payment labels Oct 4, 2026

Navigation Menu

Repository navigation

refactor(js): centralize page bootstrapping into single DOMContentLoaded handler - #646

refactor(js): centralize page bootstrapping into single DOMContentLoaded handler#646
jbampton merged 4 commits into
NextCommunity:mainfrom
titas-mahato:centralize-domcontentloaded-bootstrap

titas-mahato commented Oct 3, 2026

Uh oh!

deepsource-io Bot commented Oct 3, 2026

Uh oh!

deepsource-io Bot Oct 3, 2026

Uh oh!

deepsource-io Bot Oct 3, 2026

Uh oh!

deepsource-io Bot commented Oct 3, 2026 •

edited

Loading

Uh oh!

deepsource-io Bot Oct 3, 2026

Uh oh!

titas-mahato commented Oct 3, 2026

Uh oh!

deepsource-io Bot Oct 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

jbampton left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

titas-mahato commented Oct 3, 2026

Summary

Changes

Uh oh!

deepsource-io Bot commented Oct 3, 2026

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

deepsource-io Bot Oct 3, 2026

Choose a reason for hiding this comment

Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

Uh oh!

deepsource-io Bot Oct 3, 2026

Choose a reason for hiding this comment

Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable

Uh oh!

deepsource-io Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

deepsource-io Bot Oct 3, 2026

Choose a reason for hiding this comment

Function has a cyclomatic complexity of 8 with "medium" risk

Uh oh!

titas-mahato commented Oct 3, 2026

Uh oh!

deepsource-io Bot Oct 3, 2026

Choose a reason for hiding this comment

'unlockedEggs' is already declared in the upper scope on line 20 column 7

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

jbampton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

deepsource-io Bot commented Oct 3, 2026 •

edited

Loading