Fix context menu command thread affinity - #2546
Merged
ge0rdi merged 1 commit intoOct 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invoke shell context-menu commands on the thread that created the
IContextMenuobject instead of passing the interface pointer to a separate STA thread.Keep
opencontainingnon-blocking by using the existingSHOpenFolderAndSelectItemsSafepath, which performs the shell operation on the worker STA without moving theIContextMenuinterface across apartments.Why
The worker-STA invocation was introduced to avoid the Windows 11 "Open file location" delay. However, shell context-menu handlers can require invocation on the thread that created the context-menu object, as the existing special case for
propertiesalready demonstrates.This also avoids passing a raw apartment-bound
IContextMenuinterface pointer to another STA.Verification
Buildcompleted successfully for commitdfbbb969ab28a125c3e1cdc89c86f50279b25ffa.Send to -> Desktop (create shortcut)creates the shortcut without freezing Open-Shell.Open file locationstill opens Explorer and selects the item.Propertiesstill opens normally.Fixes #2536