fix: improved regex that doesn't exclude other windows languages - #59
PrimeBuild-pc merged 3 commits into
Conversation
|
Hi Nathan, thanks for the contribution. The fix is correctly scoped, and the updated parser handles French output while preserving English output, the active marker, and names containing parentheses. Before merging, please include the localized-output regression test mentioned in the PR description in |
|
Hi Nathan, friendly reminder on this PR. The parser change still looks good. The only remaining requirement before merge is the localized powercfg regression test in PowerPlanServiceTests, covering the French sample from issue #58 while preserving English output, the active marker, and plan names containing parentheses. Could you add the test when you have a chance? If you are no longer able to continue, please let us know so we can decide how to proceed. Thanks. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
PrimeBuild-pc
left a comment
There was a problem hiding this comment.
Completed the missing localized-output regression test and brought the branch up to date with main. The French powercfg sample now parses both plans and preserves the active marker; the existing English and parenthesized-name cases remain green.\n\nVerified locally: Release build, 752 tests, and scoped formatting. CI DevSecOps and CodeQL also pass.
Summary
Updated
PowerPlanServiceto parse power plan entries using their GUID format instead of the EnglishPower Scheme GUID:label. This fixes power plan detection on different languages Windows installations.Type of Change
Validation
Automated tests could not be run because
.NETwas unavailable in the development environment. A localized-output test was created locally but is not included in this pull request.Security and Risk Notes
No impact on elevation, process control, power plan operations, or persisted configuration. The change only affects parsing of
powercfg /listand/getactiveschemeoutput.Checklist