blit: accept MicroPython's tuple source in the bounding box - #34
Merged
Merged
Conversation
framebuf.blit takes (buffer, width, height, format), and FrameBuffer.blit passed it through to the base blit fine, then read source.width for the Area it returns and raised AttributeError. The spectrum example hit it on python.exe with the source tree on the path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FrameBuffer.blit((buf, w, h, fmt), x, y)draws correctly (the base blit takes the tuple form MicroPython's framebuf accepts), then raisesAttributeError: 'tuple' object has no attribute 'width'computing the Area it returns.clip_blit_boundsnow reads the width and height from a tuple too.Found running pydevices-examples' spectrum meter on Windows python.exe with the pygraphics source tree on the path (
SpectrumView._build_bar_columns). A new test covers the tuple form, including the fully-clipped case. It fails without the fix, and the suite passes with it (104 tests, 8 skipped).