Conversation
8 of 23 tasks
Contributor
|
Tested against a real device: Roborock Q10 S5+ (ss07 firmware family), on commit Watched Observations:
This was a single-room spot clean, so I didn't get to observe a room-to-room transition in this pass. |
3 of 4 tasks
This was referenced Sep 11, 2026
# Conflicts: # roborock/devices/traits/b01/q10/maps.py # tests/devices/traits/b01/q10/test_clean_history.py
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Q10 firmware does not provide a validated active-room field. This exposes
map.current_roomby conservatively matching the latest live robot position to the segmented map grid.Behavior
Q10Roommodel orNone, with a defensive copy of a resolved room.None.Session validity stays in the trait. Spatial resolution is a pure function of typed map/trace models.
Dependencies
Depends on #938 and #937. #936, #908, and #965 are merged. Upstream
mainthroughb3a98b9(7.12.0) is integrated.Allen’s follow-up feedback on merged #936 is addressed by separate clean-record and saved-map decoder tests, with no conditional assertions.
Validation and limits
Validation of
33b5af5:uv run pytest -qon Python 3.13: 1,497 passed, 53 xfailed, 92 snapshots passed.uv buildpassed for both wheel and sdist.No physical-device run was performed for this revision.
Existing tests cover room resolution, ambiguity, calibration, session freshness, custom labels, and diagnostic redaction. Earlier physical Q10 S5/S5+ testing observed a custom room label during a single-room clean and clearing during return/docking. A room-to-room transition was not covered by that reported run.
This is inferred room occupancy during cleaning, not an authoritative firmware report of the selected cleaning segment. Missing or unusable map/trace data returns
None. Archive requests inherit the bounded lifecycle from #937, including its clean-history ambiguity barrier and same-map freshness limitation.No private map captures, room labels, or account data are included. Related: #767.