Repository navigation
Drop scratch_enabled column from schools - #1050
Merged
jamiebenstead merged 1 commit intoOct 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The migration is reversible, schema changes are consistent, and no remaining references exist.
Review effort: Balanced
Findings: None
What changed in this PR
Removes the obsolete scratch_enabled field from schools.
Changes:
- Adds a reversible migration removing the column.
- Updates the schema and cleans up
School.ignored_columns.
| File | Description |
|---|---|
app/models/school.rb |
Removes the obsolete ignored-column entry. |
db/migrate/20261007131211_remove_scratch_enabled_from_schools.rb |
Drops the column. |
db/schema.rb |
Records the updated schema. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Test coverage93.86% line coverage reported by SimpleCov. |
raspberrypiherokubot
temporarily deployed
to
editor-api-p-1882-remov-qvt40s
October 7, 2026 13:28
Inactive
mwtrew
approved these changes
Oct 7, 2026
jamiebenstead
deleted the
1882-remove-scratch_enabled-column-from-schools
branch
October 7, 2026 14:11
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the work for https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1882