Repository navigation
Skip frame register clearing when a call has extra arguments - #146
Merged
Merged
Conversation
When a caller passes more arguments than the callee has registers, l.top is past ci.top and the clear added in #145 panics on a backwards slice. The extra arguments are already discarded when l.top is reset to ci.top. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
abecevello
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#145 panics with
slice bounds out of rangewhen a Lua function gets more arguments than it has registers, e.g.local function noop() end noop(nil, "x", {}).The clear now only runs when its start is below
ci.top; extra arguments are already discarded whenl.topis reset.Fixes the 59 failures and 14 errors in genghis-flows unit tests; the full suite passes with this change.
🤖 Generated with Claude Code