Bench: cover Gradle hosted mode (gradle/hosted, gradle/rescan)

[Mikola Lysenko (mikolalysenko)]

What main changed. #646 (0685ba8c) added full Gradle support, including hosted mode. scan now crawls Gradle's modules-2/files-2.1 cache under GRADLE_USER_HOME and pins the suffixed versions in gradle.lockfile. It wires the build through an owned settings script and index under .socket/gradle/. The suite had no Gradle scenario: maven/* only covers the pom.xml + ~/.m2 path.

Suite changes

• Added gradle/hosted and gradle/rescan. The project is a single-project Groovy-DSL build with dependencyLocking: 1000 locked artifacts, 25 of them patched direct deps. Its cache lives under the fixture's GRADLE_USER_HOME, with jar and pom in separate sha1 hash dirs. The scenarios expect these rewrites: .socket/gradle/{.gitattributes,hosted-index.tsv,socket-patch.hosted.settings.gradle}, gradle.lockfile and settings.gradle. The only allowed warning is redirect_gradle_detached_configs_unguarded, which the planner always emits.
• The grant's indexUrl is https://patch.socket.dev/..., not the mock. The Gradle planner refuses non-https repositories (redirect_gradle_override_invalid), and a scan never fetches the index. The artifact URL still points at the mock.
• Refactor, no behavior change. maven and gradle now share the Maven-coordinate generator, the pom writer and the maven2 grant builder. The maven fixture bytes are unchanged: I built maven/hosted with the old and new bench binaries and diff -r showed them identical.
• README: lists gradle and GRADLE_USER_HOME.

Validation (all runs against the main CLI 9c43dfc9, on a 4 vCPU Xeon @ 2.10GHz)

• cargo fmt -p socket-patch-bench, cargo clippy -p socket-patch-bench --all-features --all-targets -- -D warnings and cargo test -p socket-patch-bench (29 passed) are all clean.
• run -f '^gradle/' --runs 3: gradle/hosted 170.5 ms (0.17 ms/pkg), gradle/rescan 259.2 ms. Both validate with 53 requests each.
• A/A compare -f '^gradle/' -f '^maven/' (head binary vs a copy of itself): no regressions. gradle/hosted -1.1%, gradle/rescan +4.5%, maven/hosted -1.6%, maven/rescan +1.7%.
• strace -f -e trace=execve on the serve gradle/hosted command: the CLI spawns nothing; the only execves are the shell, env and socket-patch itself. The rewritten gradle.lockfile carries <v>-socket.<uuid8> pins, and settings.gradle gains the apply from: line.

Time budget: compare grows by about 2 × 0.4 s per pair. A full compare took about 13 min on this runner both before and after, so the change is within noise. Nothing was removed.

🤖 Generated with Claude Code

https://claude.ai/code/session_014cKiDSpASodTewYpmHqEnG

---

Generated by Claude Code

---

Note

Low Risk
Primarily benchmark fixtures and digest helper consolidation; Maven fixture output is explicitly parity-checked, with no intended runtime behavior change in core.

Overview
Adds Gradle to the socket-patch bench suite (gradle/hosted and gradle/rescan) so hosted-mode rewrites—.socket/gradle/*, gradle.lockfile, settings.gradle—and crawling of GRADLE_USER_HOME’s modules-2/files-2.1 cache are covered in CI. The Gradle fixture uses dependency locking (~1000 artifacts, ~25 patched), sets GRADLE_USER_HOME on the fixture tree, and uses an https patch-registry indexUrl (Gradle’s planner rejects non-https repos) while artifact URLs still hit the mock.

Maven and Gradle fixtures now share Maven-coordinate generation, POM writing, and maven2 grant construction (jvm_universe, jvm_pom, jvm_patch); Maven bytes are intended to stay identical. README lists gradle and documents isolated GRADLE_USER_HOME in the harness env.

In socket-patch-core, SHA-1/SHA-256 hashing in Gradle cache, JVM jar patching, and Maven sidecars is routed through utils::digest::{sha1_hex_of, sha256_hex_of} (refactor only).

^{Reviewed by Cursor Bugbot for commit bb74cac. Configure here.}

---

Generated by Claude Code

[Mikola Lysenko (mikolalysenko)]

bugbot run

---

Generated by Claude Code

[cursor]

Stale Bugbot comment from a previous run.

[Mikola Lysenko (mikolalysenko)]

[agent] Bench: coverage failed on 9b5c5491 because of main, not this PR.

utils::digest::tests::production_digests_go_through_the_helpers fails because #865 (digest helpers) and #646 (Gradle) crossed. Gradle added inline digests in crawlers/gradle_cache.rs, patch/jvm_jar.rs and patch/sidecars/maven.rs. The same test is red in main's CI on 9c43dfc9.

The fix is open as #878. I cherry-picked its single commit here (659ac2c2, with -x) so this PR can go green. It becomes a no-op once #878 merges. Locally, cargo test -p socket-patch-core --lib digest (21 passed) and cargo clippy -p socket-patch-core --lib -D warnings are both clean.

---

Generated by Claude Code

[Mikola Lysenko (mikolalysenko)]

bugbot run

---

Generated by Claude Code

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit bb74cac. Configure here.}

[Mikola Lysenko (mikolalysenko)]

Burn-down agent: labeled Ready for review.

• Head: bb74cac798ee825022b4fcb821c6e5031eabb024 (0 behind main; only waiting on review)
• CI: 411/411 check runs green (success/skipped) on this head
• Bugbot: reviewed bb74cac, no issues found
• Reviewer focus: new bench fixtures for Gradle hosted mode (gradle/hosted, gradle/rescan) in socket-patch-bench. The PR also carries Route Gradle digests through utils::digest #878's digest-helper commit so coverage passes on top of main; that becomes a no-op once Route Gradle digests through utils::digest #878 merges.

---

Generated by Claude Code