Feat/access input - #882
Open
SharonStrats wants to merge 4 commits into
Open
SharonStrats wants to merge 4 commits into
SharonStrats wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Search options, multi-value selection, asynchronous input handling, and existing tests have unresolved regressions.
Review effort: Balanced
Findings: 3
Open (5)
What changed in this PR
Adds directory-backed principal selection and pending access grants to the access-control modal.
Changes:
- Adds searchable principal and grant comboboxes.
- Introduces pending-grant chips and label resolution.
- Updates styling, theme colors, and screen-reader label bindings.
| File | Description |
|---|---|
src/styles/theme.css |
Adds gray theme tokens. |
src/components/select/Select.stories.ts |
Fixes label property binding. |
src/components/input/Input.stories.ts |
Fixes label property binding. |
src/components/combobox/Combobox.stories.ts |
Fixes label property bindings. |
src/components/access-control-modal/AccessControlModal.ts |
Implements access search and pending grants. |
src/components/access-control-modal/AccessControlModal.styles.css |
Styles the revised modal interface. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SharonStrats
force-pushed
the
feat/access-input
branch
from
October 4, 2026 20:44
4df8ffa to
4ada9f1
Compare
SharonStrats
force-pushed
the
feat/access-input
branch
from
October 5, 2026 00:28
d032eb1 to
43ee42d
Compare
…6.0.0 pane-registry@5.0.1)
Member
|
Hei your decisions make colplete sense to me. I like tge No access and how the combo box works, actually design wide itnis more consistent and better overall. |
timea-solid
approved these changes
Oct 5, 2026
timea-solid
left a comment
Member
There was a problem hiding this comment.
Great job and thanks dmfir addint tests too!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This was for the input ticket, the add at the top. I used the solid-ui-combobox.
This relies on solid-logic SolidOS/solid-logic#336
Some notes:
Here is a screenshot
