fix(hig): draw toolbar and status bar icons in one consistent style - #3252
Merged
Merged
Conversation
A window toolbar draws outline glyphs: Save is the bare checkmark, and Actions, the filter menus and Disconnect lose their circle where a toolbar item has its own glass container (macOS 26 and later). ToolbarSymbols owns the names that depend on the release. Safe Mode fills its icon only at the levels that also gate reads. Status bar controls take one height from a fixed icon box. Export no longer draws the Import glyph, a database is an outline glyph everywhere, and the two toolbar-hosted menus carry a VoiceOver name. Fixes #3250
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The window chrome mixed symbol variants. Save drew the filled, circled check the app uses for "succeeded". Safe Mode filled its icon at Silent and Read-Only, where the fill meant nothing. Toolbars kept circled glyphs the HIG marks incorrect inside a glass toolbar item. Each glyph was a string literal at its call site, so nothing kept them in step.
Change
ToolbarSymbolsowns the names.Verified
ToolbarSymbolConventionTestsreports the four pre-fix glyphs on main. Checked on a Debug build on macOS 27. Not run on macOS 13 to 15.Screenshots
Connection window toolbar, welcome toolbar, status bar.
Not in this PR
exclamationmark.seal.fillis not a system symbol, and eleven symbols in use are newer than macOS 13.Fixes #3250