Skip to content

fix(hig): draw toolbar and status bar icons in one consistent style - #3252

Merged
datlechin merged 1 commit into
mainfrom
fix/datagrid-icon-consistency
Oct 3, 2026
Merged

datlechin merged 1 commit into
mainfrom
fix/datagrid-icon-consistency

Conversation

@datlechin

Copy link
Copy Markdown
Member

Why

The window chrome mixed symbol variants. Save drew the filled, circled check the app uses for "succeeded". Safe Mode filled its icon at Silent and Read-Only, where the fill meant nothing. Toolbars kept circled glyphs the HIG marks incorrect inside a glass toolbar item. Each glyph was a string literal at its call site, so nothing kept them in step.

Change

  • Toolbar Save is a bare checkmark. Safe Mode fills its icon only at the two Full levels.
  • On macOS 26 and later, Actions, the filter menus and Disconnect lose their circle, and Actions its chevron, as Finder draws it. Earlier releases keep the circled form. ToolbarSymbols owns the names.
  • Status bar buttons share one height. Highlight Rules stays icon-only: its title would take the titles off Columns and Filters at the default window size.
  • Export no longer shows the Import icon, and a database is an outline icon everywhere.
  • VoiceOver names the welcome and Integrations toolbar menus instead of reading "chevron.pulldown".

Verified

ToolbarSymbolConventionTests reports the four pre-fix glyphs on main. Checked on a Debug build on macOS 27. Not run on macOS 13 to 15.

Screenshots

Connection window toolbar, welcome toolbar, status bar.

Light Dark
Before Before, light Before, dark
After After, light After, dark

Not in this PR

  • SwiftUI menus that mark the current row with an image show no mark on macOS 27: the result-set chooser, the editor's database picker and four more.
  • exclamationmark.seal.fill is not a system symbol, and eleven symbols in use are newer than macOS 13.
  • Integrations Activity: the filter icon and the empty state disagree on what "no filter" is.
  • The Results toolbar item's overflow entry keeps the glyph it was built with.
  • TableProMobile toolbars keep their circled glyphs.

Fixes #3250

A window toolbar draws outline glyphs: Save is the bare checkmark, and Actions, the filter menus and Disconnect lose their circle where a toolbar item has its own glass container (macOS 26 and later). ToolbarSymbols owns the names that depend on the release. Safe Mode fills its icon only at the levels that also gate reads. Status bar controls take one height from a fixed icon box. Export no longer draws the Import glyph, a database is an outline glyph everywhere, and the two toolbar-hosted menus carry a VoiceOver name.

Fixes #3250
@mintlify

mintlify Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
TablePro 🟢 Ready View Preview Oct 3, 2026, 7:50 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@datlechin
datlechin merged commit 8ea8e7e into main Oct 3, 2026
16 checks passed
@datlechin
datlechin deleted the fix/datagrid-icon-consistency branch October 3, 2026 09:54

This branch was successfully deployed

1 active deployment
staging - docs — 61c995bb Deployed Oct 3, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Improve icon consistency

1 participant