fix(form-core): bump devtools-event-client to 0.5.0 - #2410
TiagoGranelli wants to merge 1 commit into
Conversation
The root EventClient export is a no-op outside development since 0.5.0, so forms stop connecting to the devtools bus in production builds and SSR. Fixes TanStack#2132
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: TanStack/form/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughform-core updates its ChangesForm-core event client
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The updated client does not start a connection retry outside development, and the dependency resolution matches the update. No issue identified here prevents merging after normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎯 Changes
Bumps
@tanstack/devtools-event-clientin form-core from ^0.4.1 to ^0.5.0.Since 0.5.0 (TanStack/devtools#471) the root
EventClientexport is a no-op unlessNODE_ENVisdevelopment, and bundlers drop the real client. Pacer already made the same bump. On 0.4.x the first form emit firestanstack-connectand starts a retry interval even with no devtools installed, which also keeps a Node SSR process alive for about 5s after rendering a form.v2 alpha already removes the event client from form-core, so this is only for 1.x. One side effect:
react-form-devtools/productionwon't get form events in production builds anymore, same as Pacer after its bump.Added a test that mounts a form and checks nothing is sent to the devtools bus. It fails on 0.4.3. I also checked a minified production bundle of form-core (35.8 kB to 32.0 kB, no
tanstack-connectleft), and a Node script that mounts a form now exits right away instead of after ~5s.Fixes #2132
✅ Checklist
pnpm test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit