Skip to content

test(lit-query/testHost): remove unused 'waitFor' and 'waitForMissingQueryClient' helpers - #11676

Merged
sukvvon merged 1 commit into
mainfrom
test/lit-query-remove-waitfor-helpers
Sep 26, 2026
Merged

test(lit-query/testHost): remove unused 'waitFor' and 'waitForMissingQueryClient' helpers#11676
sukvvon merged 1 commit into
mainfrom
test/lit-query-remove-waitfor-helpers

Conversation

@sukvvon

@sukvvon sukvvon commented Sep 26, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

🎯 Changes

Removes the waitFor and waitForMissingQueryClient polling helpers (and the sleep import they used) from packages/lit-query/src/tests/testHost.ts. The lit-query tests now run under fake timers and no longer use them.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Removed test-only waiting utilities. This cleanup does not change application behavior or affect features available to end users.

@sukvvon sukvvon self-assigned this Sep 26, 2026
@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 38aebb79-9330-4a92-9a70-be814c75f785

📥 Commits

Reviewing files that changed from the base of the PR and between 98184c1 and cbb8df9.

📒 Files selected for processing (1)
  • packages/lit-query/src/tests/testHost.ts
💤 Files with no reviewable changes (1)
  • packages/lit-query/src/tests/testHost.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

📝 Walkthrough

Walkthrough

The test host removes the unused sleep import and the exported waitFor and waitForMissingQueryClient polling helpers.

Changes

lit-query test helpers

Layer / File(s) Summary
Remove polling helpers
packages/lit-query/src/tests/testHost.ts		 The test host no longer imports sleep or exports waitFor and waitForMissingQueryClient.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to cbb8d

The removed helpers have no repository consumers, so no actionable merge risk remains beyond normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the removal of the unused waitFor and waitForMissingQueryClient helpers from the Lit Query test host.
Description check ✅ Passed The description explains the changes and motivation, completes all required checklist items, and identifies the change as dev-only with no release impact.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Sep 26, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit cbb8df9

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 54s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-26 17:43:33 UTC

@github-actions

github-actions Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@pkg-pr-new

pkg-pr-new Bot commented Sep 26, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11676

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11676

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11676

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11676

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11676

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11676

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11676

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11676

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11676

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11676

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11676

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11676

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11676

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11676

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11676

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11676

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11676

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11676

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11676

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11676

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11676

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11676

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11676

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11676

commit: cbb8df9

@github-actions

github-actions Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.73 KB (0%)
react minimal 8.58 KB (0%)

@sukvvon
sukvvon merged commit 0c40a4b into main Sep 26, 2026
9 checks passed
@sukvvon
sukvvon deleted the test/lit-query-remove-waitfor-helpers branch September 26, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sukvvon sukvvon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sukvvon