refactor: move resource parsing and org connection helpers into config-free modules

[scott-lowe-vapi]

Value

V.A.L.U.E. tier: project — PR 3 of 10 for inline simulation PR checks (TEST-141); this PR is a behaviour-preserving refactor.

• Problem: the PR check (PRs 4–7) has to read an org's resource files and resolve org API keys. All the code that does that sits behind config.ts, which parses argv, binds one org and can process.exit at import time. Copying it into the check would let push and the check drift apart, so the check could test a different payload from the one push sends.
• Who it affects: gitops users, whose PR checks must test exactly what push would deploy; and maintainers, who get one copy of the loader instead of two (three for the .md system-prompt injection).
• What changes: code moves into two config-free modules. resources.ts, config.ts and promote-cmd.ts delegate to them and keep their exports, logs and error messages.
  • src/resource-parse.ts:
    • from resources.ts: FOLDER_MAP, VALID_EXTENSIONS, frontmatter/file parsing, the directory scan and the loader;
    • from config.ts: .vapi-ignore reading and matching;
    • new: orgResourcesRead(rootDir, org), which returns every resource of an org keyed type:id;
    • the three copies of the .md body → system message injection become markdownResourceParse.
  • src/org-connection.ts: envValue, tokensParse(envName), connectionLoad and childRun, moved from promote-cmd.ts and parameterised on the root dir, the token variable and the base URL.
  • api.ts: takes VapiApiError, parseApiMessage, shouldRetry and the backoff constants from vapi-client.ts, and re-exports VapiApiError. Both clients now share one error class (so instanceof checks see one class) and one retry rule.
  • promotion.ts:
    • imports FOLDER_MAP / VALID_EXTENSIONS instead of keeping its own copies;
    • exports SLUG_RE, promotionBindingsParse, promotionBindingsResolve, promotionBindingsApply and PromotionBindingsResolved, for the check config (PR 4) and the payload builder (PR 5).
  • Also dropped: the unused FOLDER_TO_TYPE map in resources.ts.

Evidence of value

The output is byte-identical before and after. The same fixture org was run at both refs against a local stub API. Nothing reached a real org.

The fixture:

• an .md assistant whose frontmatter has a system message the body must replace;
• a nested assistant;
• an ignored assistant;
• a backup copy and an unsupported file;
• a .ts tool and a YAML tool;
• a squad, a structured output and all four simulation types;
• a two-org promotion.yml.

Command	fix/sim-false-green (06a1492)	This branch (0518af1)
push ev-dev --dry-run (new-file gate refusal)	identical	identical
push ev-dev --dry-run --allow-new-files (full plan, every would-POST)	identical	identical
loadResources JSON for every type (full parsed data, incl. the .md system message)	identical	identical
validate ev-dev	identical	identical
promote --pipeline release --from ev-dev --to ev-prod (plan)	identical	identical
Combined stdout + stderr + stub request log	sha256 3f3b609f…1d3b, 14,927 bytes	sha256 3f3b609f…1d3b, 14,927 bytes

• Dry-run placeholder IDs (dry-run-post-<Date.now()>) and the stub's port are normalised before hashing.
• --allow-new-files is passed only because every fixture file is new by construction.

Tests: npm test goes from 377 to 398 passing (21 new), and npm run build (src + tests) is clean.

Testing plan

• tests/resource-parse.test.ts (temp-dir fixtures) covers:
  • .md body replacing a frontmatter system message, and an empty body;
  • missing frontmatter;
  • .md parsing being the same for parseResourceDataFromFile and the loader;
  • sorted order across .yml/.yaml/.ts and nested dirs;
  • hidden and .bkp files skipped;
  • duplicate IDs refused, with the exact YAML-not-an-object message;
  • missing directory;
  • .vapi-ignore comments, blanks and !;
  • * vs ** vs ? matching;
  • orgResourcesRead reading one org and applying its ignore file, and the caller's override.
• tests/org-connection.test.ts covers:
  • plain and quoted .env values;
  • token-map parsing, with the variable named in every error;
  • token precedence (map, then .env.<org>) and base URL precedence (configured, then .env.<org>);
  • the missing-token error;
  • childRun passing the org and key to a real child, and dropping an inherited VAPI_BASE_URL;
  • a failing child.
• The existing push dry-run, .vapi-ignore push, promotion, audit and cleanup-safety suites pass unchanged.
• Not tested:
  • a push against a real org (the comparison uses a stub API that returns empty lists, so update/PATCH paths for existing resources aren't exercised; the code they call is unchanged);
  • promote --apply (the moved connectionLoad/childRun are covered by unit tests, but no live child pull/apply was run);
  • Node 20 locally (left to CI).

Stacked on #58. Review with git diff --color-moved=dimmed-zebra fix/sim-false-green... to see that most of the diff is moved lines.

Refs TEST-141

🤖 Generated with Claude Code

[scott-lowe-vapi]

• feat(check): add the opt-in Vapi checks PR workflow and user docs #64
• feat(check): run checks live and report Vapi Evals statuses #63
• feat(check): fail closed on tools and servers in inline check payloads #62
• feat(check): build inline simulation-run payloads and add a dry-run CLI #61
• feat(check): parse vapi-checks.yml check configuration #60
• refactor: move resource parsing and org connection helpers into config-free modules #59 👈 (View in Graphite)
• fix(sim): report failed, canceled and incomplete runs instead of a false pass #58
• ci: type-check tests/ and send a User-Agent on sim API requests #57
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[scott-lowe-vapi]

Merge activity

• Oct 3, 5:59 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Oct 3, 6:03 AM UTC: Graphite rebased this pull request as part of a merge.
• Oct 3, 6:03 AM UTC: @scott-lowe-vapi merged this pull request with Graphite.