Repository navigation
Fuzzer: Emit elem.drop instructions #9201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9781802
Fuzzer: Emit more br_on_cast_desc_eq and br_on_cast_desc_eq_fail inst…
tlively 9d8ae81
Fuzzer: Emit try-delegate instructions
tlively 4e04f93
Fuzzer: Emit elem.drop instructions
tlively 6f3ebe7
Merge branch 'main' into fuzzer-more-br-on-desc
tlively 2773397
Merge branch 'fuzzer-more-br-on-desc' into fuzzer-delegate
tlively fd57169
Merge branch 'fuzzer-delegate' into fuzzer-elem-drop
tlively a8843da
Merge branch 'main' into fuzzer-more-br-on-desc
tlively ec2cc02
Merge branch 'fuzzer-more-br-on-desc' into fuzzer-delegate
tlively b59b864
Merge branch 'fuzzer-delegate' into fuzzer-elem-drop
tlively 2b91e7a
Merge branch 'main' into fuzzer-more-br-on-desc
tlively 35a159e
Merge branch 'fuzzer-more-br-on-desc' into fuzzer-delegate
tlively c81955a
Merge branch 'fuzzer-delegate' into fuzzer-elem-drop
tlively ab1eb44
Merge branch 'main' into fuzzer-more-br-on-desc
tlively 9835276
Merge branch 'fuzzer-more-br-on-desc' into fuzzer-delegate
tlively 6a01e4e
Merge branch 'fuzzer-delegate' into fuzzer-elem-drop
tlively 0dc32ad
Merge remote-tracking branch 'origin/main' into fuzzer-elem-drop
tlively File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
166 changes: 86 additions & 80 deletions
166
test/passes/translate-to-fuzz_all-features_metrics_noprint.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,89 +1,95 @@ | ||
| Metrics | ||
| total | ||
| [exports] : 42 | ||
| [funcs] : 98 | ||
| [exports] : 78 | ||
| [funcs] : 163 | ||
| [globals] : 13 | ||
| [imports] : 12 | ||
| [memories] : 1 | ||
| [memory-data] : 31 | ||
| [table-data] : 26 | ||
| [table-data] : 39 | ||
| [tables] : 2 | ||
| [tags] : 2 | ||
| [total] : 51844 | ||
| [vars] : 3186 | ||
| ArrayCmpxchg : 15 | ||
| ArrayCopy : 24 | ||
| ArrayFill : 22 | ||
| ArrayGet : 227 | ||
| ArrayLen : 315 | ||
| ArrayNew : 626 | ||
| ArrayNewFixed : 176 | ||
| ArrayRMW : 9 | ||
| ArraySet : 35 | ||
| AtomicCmpxchg : 15 | ||
| AtomicFence : 39 | ||
| AtomicNotify : 5 | ||
| AtomicRMW : 13 | ||
| AtomicWait : 5 | ||
| Binary : 1921 | ||
| Block : 3625 | ||
| BrOn : 329 | ||
| Break : 539 | ||
| Call : 527 | ||
| CallIndirect : 44 | ||
| CallRef : 99 | ||
| Const : 6799 | ||
| ContNew : 58 | ||
| DataDrop : 4 | ||
| Drop : 443 | ||
| GlobalGet : 2648 | ||
| GlobalSet : 1044 | ||
| I31Get : 41 | ||
| If : 1304 | ||
| Load : 143 | ||
| LocalGet : 6906 | ||
| LocalSet : 2161 | ||
| Loop : 423 | ||
| MemoryCopy : 8 | ||
| MemoryFill : 8 | ||
| MemoryInit : 7 | ||
| Nop : 360 | ||
| Pop : 97 | ||
| RefAs : 4588 | ||
| RefCast : 374 | ||
| RefEq : 128 | ||
| RefFunc : 1000 | ||
| RefGetDesc : 34 | ||
| RefI31 : 318 | ||
| RefIsNull : 21 | ||
| RefNull : 4688 | ||
| RefTest : 33 | ||
| Return : 221 | ||
| SIMDExtract : 54 | ||
| SIMDShift : 1 | ||
| Select : 164 | ||
| Store : 73 | ||
| StringConst : 200 | ||
| StringEncode : 38 | ||
| StringEq : 35 | ||
| StringMeasure : 35 | ||
| StringNew : 4 | ||
| [total] : 93958 | ||
| [vars] : 3603 | ||
| ArrayCmpxchg : 19 | ||
| ArrayCopy : 20 | ||
| ArrayFill : 28 | ||
| ArrayGet : 307 | ||
| ArrayLen : 415 | ||
| ArrayNew : 1092 | ||
| ArrayNewFixed : 288 | ||
| ArrayRMW : 11 | ||
| ArraySet : 48 | ||
| AtomicCmpxchg : 31 | ||
| AtomicFence : 49 | ||
| AtomicNotify : 17 | ||
| AtomicRMW : 17 | ||
| AtomicWait : 10 | ||
| Binary : 3070 | ||
| Block : 5914 | ||
| BrOn : 559 | ||
| Break : 820 | ||
| Call : 930 | ||
| CallIndirect : 146 | ||
| CallRef : 167 | ||
| Const : 12562 | ||
| ContBind : 4 | ||
| ContNew : 98 | ||
| DataDrop : 14 | ||
| Drop : 721 | ||
| ElemDrop : 8 | ||
| GlobalGet : 4766 | ||
| GlobalSet : 1777 | ||
| I31Get : 40 | ||
| If : 2028 | ||
| Load : 263 | ||
| LocalGet : 10162 | ||
| LocalSet : 3451 | ||
| Loop : 720 | ||
| MemoryCopy : 6 | ||
| MemoryFill : 12 | ||
| MemoryInit : 13 | ||
| Nop : 531 | ||
| Pop : 168 | ||
| RefAs : 9573 | ||
| RefCast : 666 | ||
| RefEq : 216 | ||
| RefFunc : 1946 | ||
| RefGetDesc : 79 | ||
| RefI31 : 601 | ||
| RefIsNull : 44 | ||
| RefNull : 11542 | ||
| RefTest : 50 | ||
| Return : 330 | ||
| SIMDExtract : 115 | ||
| SIMDLoad : 2 | ||
| SIMDReplace : 3 | ||
| SIMDShuffle : 4 | ||
| SIMDTernary : 4 | ||
| Select : 270 | ||
| Store : 94 | ||
| StringConcat : 2 | ||
| StringConst : 425 | ||
| StringEncode : 45 | ||
| StringEq : 53 | ||
| StringMeasure : 52 | ||
| StringNew : 3 | ||
| StringSliceWTF : 2 | ||
| StringWTF16Get : 36 | ||
| StructCmpxchg : 19 | ||
| StructGet : 234 | ||
| StructNew : 6141 | ||
| StructRMW : 21 | ||
| StructSet : 31 | ||
| Switch : 4 | ||
| TableSet : 29 | ||
| Throw : 37 | ||
| ThrowRef : 5 | ||
| Try : 184 | ||
| TryTable : 232 | ||
| TupleExtract : 114 | ||
| TupleMake : 107 | ||
| Unary : 1009 | ||
| Unreachable : 546 | ||
| WideIntAddSub : 12 | ||
| WideIntMul : 8 | ||
| StringWTF16Get : 56 | ||
| StructCmpxchg : 33 | ||
| StructGet : 449 | ||
| StructNew : 11929 | ||
| StructRMW : 38 | ||
| StructSet : 47 | ||
| Switch : 6 | ||
| TableSet : 56 | ||
| Throw : 76 | ||
| ThrowRef : 8 | ||
| Try : 350 | ||
| TryTable : 394 | ||
| TupleExtract : 225 | ||
| TupleMake : 273 | ||
| Unary : 1657 | ||
| Unreachable : 916 | ||
| WideIntAddSub : 13 | ||
| WideIntMul : 9 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What removed the need for this check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out that
makeMemoryInit,makeMemoryCopy, andmakeMemoryFillalready do this check.makeDataDropandmakeElemDropcan still make sense to do even when there is no memory.