Repository navigation
Conversation
Keep the initialized Hole in the render cache after updating it. Previously, the second callback render cached a fresh, uninitialized Hole, so the third render could throw and leave the DOM stale. Add a browser regression for repeated text and list updates, including DOM node reuse. Verify it against both development and production bundles.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For non-engineers.
Why
Fix the third and subsequent
render(container, callback)calls for an unchanged template so repeated updates remain usable.Watch out for
Door: two-way. A plain revert restores the broken repeated-render path; this change has no persistent data effects.
Shape of the change
The second render updates the initialized cached
Hole, but previously stored the fresh callback result instead; the third render then interpreted raw values as prepared update entries.test/render.htmlchecks four text renders, a list changing from empty to restored to prepended entries, and DOM node identity. Serve the repository root and open/test/render.htmlfor the development bundle or/test/render.html?prodfor production.Evidence
Cannot assign to read only property '2' of string 'second'. In a desktop WebKit application, the list update failed withNode.insertBeforereceiving a non-Node value.PASS: repeated text and list rendersfor the same browser regression.npm run test:allandnpm run typespass. Development and production bundles were rebuilt with Rollup and tested in Chromium. CI has not run for this branch yet.