Conversation
The second gene was always num_genes // 2 after the first, so only num_genes // 2 pairs of genes could be swapped. Pick 2 different genes at random, as the docs say. Fixes ahmedfgad#374
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #374.
swap_mutation()picked its first gene at random and took the genenum_genes // 2after it as the second, so onlynum_genes // 2pairs could be swapped. The docs say it "interchanges the values of 2 randomly selected genes"; this makes the code do that, withnumpy.random.choice(num_genes, size=2, replace=False), and updates the docstring.Test:
test_swap_mutation_manual_callintests/test_crossover_mutation.pyswaps 1000 copies ofrange(6)and checks that each has exactly 2 genes exchanged and that all 15 pairs occur. It fails on master (3 pairs) and passes with this change.pytest tests(withouttest_kerasga.pyandtest_torchga.py, which need TensorFlow and PyTorch): 872 passed, 1 skipped. The only failure istest_submodule_versions.py::test_changed_submodule_is_version_bumped[utils], sincepygad/utilschanged; I left the version bump to you for the release.