Skip to content

docs: expand coding, testing, and PR guidelines in AGENTS.md - #34183

Merged
alan-agius4 merged 2 commits into
angular:mainfrom
alan-agius4:docs/agents-no-sharding
Sep 29, 2026
Merged

alan-agius4 merged 2 commits into
angular:mainfrom
alan-agius4:docs/agents-no-sharding

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Updates AGENTS.md with additional guidance for AI agents:

  • Adds a Coding Practices section covering imports (including import type) and preferring ECMAScript private fields (#field).
  • Documents how to run unit tests without sharding and retries using --config=no-sharding.
  • Clarifies that fixup commits should only be used for changes belonging to the target commit, while unrelated changes must use a separate commit.

@angular-robot angular-robot Bot added the area: docs Related to the documentation label Sep 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates AGENTS.md to document how to run tests without sharding using the --config=no-sharding flag. The feedback suggests wrapping the newly added, extremely long line into multiple lines to improve readability.

Comment thread AGENTS.md Outdated
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 26, 2026
@alan-agius4
alan-agius4 requested a review from dgp1130 September 26, 2026 08:53
@alan-agius4
alan-agius4 force-pushed the docs/agents-no-sharding branch 2 times, most recently from 7c7b328 to 682ea51 Compare September 28, 2026 11:47
@alan-agius4 alan-agius4 changed the title docs: document running tests without sharding in AGENTS.md docs: expand coding, testing, and PR guidelines in AGENTS.md Sep 28, 2026
Comment thread AGENTS.md Outdated
Comment thread AGENTS.md
Comment thread AGENTS.md
Comment thread AGENTS.md
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 28, 2026
@alan-agius4 alan-agius4 reopened this Sep 29, 2026
Updates `AGENTS.md` with additional guidance for AI agents:
- Adds a `Coding Practices` section covering imports (including `import type`) and preferring ECMAScript private fields (`#field`).
- Documents how to run unit tests without sharding and retries using `--config=no-sharding`.
- Clarifies that fixup commits should only be used for changes belonging to the target commit, while unrelated changes must use a separate commit.
@alan-agius4
alan-agius4 force-pushed the docs/agents-no-sharding branch from f2564c3 to 0d57221 Compare September 29, 2026 07:57
@alan-agius4
alan-agius4 merged commit 9b7a14a into angular:main Sep 29, 2026
39 checks passed
@alan-agius4
alan-agius4 deleted the docs/agents-no-sharding branch September 29, 2026 08:10
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants