fix(@angular/build): capture and report Rolldown warnings in library builder - #34228
Open
alan-agius4 wants to merge 2 commits into
Open
alan-agius4 wants to merge 2 commits into
alan-agius4 wants to merge 2 commits into
Conversation
…in library builder Updates `bundleEntryPoints` to capture Rolldown warning logs via `onLog` and bundling errors, returning them to `buildAction` so warnings are logged via the builder logger instead of `console.warn` and errors are properly surfaced.
There was a problem hiding this comment.
Code Review
This pull request updates the Angular library builder pipeline to capture and propagate warnings and errors emitted during the Rolldown bundling process, including adding a test case to verify warning logging. The review feedback suggests preserving the original error objects and stack traces instead of converting them to strings. Specifically, it is recommended to change the type of errors to unknown[] in the bundle outputs, push the raw error objects directly in the catch block, and throw the original error or an AggregateError in the build action to avoid losing critical diagnostic details.
…errors in library builder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
bundleEntryPointsto capture Rolldown warning logs viaonLogand return them tobuildActionso warnings are logged via the builder logger instead ofconsole.warn.