Conversation
|
|
tadeja
changed the title
tadeja
marked this pull request as ready for review
September 29, 2026 22:01
tadeja
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
September 29, 2026 22:01
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted configuration is correctly propagated to CMake and addresses the reported CI failure.
Review effort: Balanced
Findings: None
What changed in this PR
Temporarily uses bundled simdjson 4.6.4 in MinGW CI to avoid failures with MSYS2 simdjson 5.0.1.
Changes:
- Forces bundled simdjson for MINGW64 and CLANG64 C++ jobs.
| File | Description |
|---|---|
.github/workflows/cpp.yml |
Configures MinGW jobs to build bundled simdjson. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#51638
What changes are included in this PR?
As a (temporary) workaround we can use bundled 4.6.4 simdjson instead of 5.0.1 of MSYS2.
Are these changes tested?
Yes, MinGW jobs now pass parquet-reader-test.
Are there any user-facing changes?
No.
Was AI used for this PR?
Only along some parts of analysis here.
PR code and description written by:
Reviewed before submission by:
parquet-reader-testwith MSYS2 simdjson 5.0.1 #51638