Remove redundant CheckTablespaceDirectory calls - #2068
Open
chenjinbao1989 wants to merge 1 commit into
Open
chenjinbao1989 wants to merge 1 commit into
chenjinbao1989 wants to merge 1 commit into
Conversation
chenjinbao1989
force-pushed
the
rm_tablespace_check
branch
from
October 2, 2026 22:33
88893b8 to
f6e541b
Compare
leborchuk
approved these changes
Oct 5, 2026
leborchuk
left a comment
leborchuk
left a comment
Contributor
There was a problem hiding this comment.
LGTM, here the commit in PG postgres/postgres@9e4f914
leborchuk
added
Merge PG16
In pg16, the check for the tablespace directory has been moved to CheckRecoveryConsistency to ensure that the check is only called when xlog recovery is complete. Therefore, we need to remove the other tablespace directory checks.
tuhaihe
force-pushed
the
rm_tablespace_check
branch
from
October 5, 2026 19:51
f6e541b to
5ffdc49
Compare
tuhaihe
enabled auto-merge (rebase)
October 5, 2026 19:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pg16, the check for the tablespace directory has been moved to CheckRecoveryConsistency to ensure that the check is only called when xlog recovery is complete. Therefore, we need to remove the other tablespace directory checks.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions