Support migration between different PowerFlex clusters when connect on demand is enabled

[sureshanaparti]

Description

This PR supports the migration between different PowerFlex clusters when connect on demand is enabled, has the following changes:

• Prepare the PowerFlex/ScaleIO pool on the host when needed during the migration
• Register the PowerFlex/ScaleIO pool on agent if needed
• Fix live migration between PowerFlex/ScaleIO pools (regression from this - engine-storage: Set SecretConsumerDetail for VM live migration with storage on shared NFS #9222)

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Verified the migrate VM / Volumes operations between pools of different PowerFlex clusters, mainly:

Running VM

• Migrate VM with data disk to another host with storage, same cluster, different pool
• Migrate VM with data disk to another host with storage, different cluster

Stopped VM

• Migrate VM without data disk to a single primary storage, different cluster
• Migrate VM without data disk to specific primary storages, different cluster
• Migrate VM with data disk to a single primary storage, different cluster
• Migrate VM with data disk to specific primary storages, different cluster
• Root volume migrate to different PowerFlex cluster
• Data volume migrate to different PowerFlex cluster

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[codecov]

Codecov Report

❌ Patch coverage is 42.57426% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.01%. Comparing base (31b6855) to head (c015d67).
⚠️ Report is 1 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...e/cloudstack/storage/volume/VolumeServiceImpl.java	0.00%	27 Missing ⚠️
...atastore/driver/ScaleIOPrimaryDataStoreDriver.java	14.28%	11 Missing and 1 partial ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java	76.92%	5 Missing and 7 partials ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java	0.00%	0 Missing and 2 partials ⚠️
...torage/motion/StorageSystemDataMotionStrategy.java	33.33%	0 Missing and 2 partials ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	0 Missing and 2 partials ⚠️
...om/cloud/deploy/DeploymentPlanningManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #14267   +/-   ##
=========================================
  Coverage     18.00%   18.01%           
- Complexity    16218    16241   +23     
=========================================
  Files          5936     5936           
  Lines        535716   535788   +72     
  Branches      65596    65610   +14     
=========================================
+ Hits          96450    96514   +64     
+ Misses       428276   428272    -4     
- Partials      10990    11002   +12     

Flag	Coverage Δ
uitests	4.02% <ø> (ø)
unittests	19.08% <42.57%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19348

[andrijapanicsb]

@ACSHomeBot package A

[ACSHomeBot]

Accepted: package kvm A for c015d67d6717.

Planned: RPM + DEB, KVM SystemVM.

Status: Running on worker A.