HBASE-30380 Add configuration change propagation through CacheAccessService - #8704
Open
VladRodionov wants to merge 2 commits into
Open
VladRodionov wants to merge 2 commits into
VladRodionov wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagates runtime configuration changes through the CacheAccessService / CacheEngine
architecture instead of relying on the legacy BlockCache compatibility reference.
Changes
CacheEngineparticipate in HBase configuration updates viaConfigurationObserver, with a default no-oponConfigurationChange(Configuration).CacheAccessService.TopologyBackedCacheAccessService.CacheEngineparticipating in the activeCacheTopology.CacheConfig.registerChildren()andderegisterChildren()to register theCacheAccessServicerather than the legacyBlockCache.BlockCacheBackedCacheEngine.CacheConfig child registration.
Motivation
CacheAccessServiceis now the primary cache abstraction and can be backed by nativeCacheEngineimplementations which do not expose a legacyBlockCache.Registering only the legacy BlockCache with the configuration propagation mechanism would
therefore bypass native cache engines.
This change makes
CacheAccessServicethe configuration propagation root for the cachesubsystem:
Legacy BlockCache implementations continue to receive configuration updates through
BlockCacheBackedCacheEngine, avoiding duplicate registration and keeping the migrationpath compatible with existing cache implementations.