[core] Reject all-dedicated data-evolution schemas at validation - #10219
Open
LuciferYang wants to merge 2 commits into
Open
LuciferYang wants to merge 2 commits into
LuciferYang wants to merge 2 commits into
Conversation
The BLOB and VECTOR column checks each required "other normal columns" but only counted their own dedicated kind, so a table mixing BLOB and VECTOR columns — no normal column at all — passed validation. The write path then has no normal anchor file to assign first row ids from, and every commit fails with "This is a bug, blobStart ... should be less than start". Add a combined check: when any dedicated column exists, at least one column must be stored in neither dedicated kind. Assisted-by: GLM-5.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A row-tracking data-evolution table that mixes a BLOB column and a VECTOR column with no other columns passed schema validation. The BLOB and VECTOR checks each required "other normal columns" but only counted their own dedicated kind, so each treated the other's column as normal and both passed. Such a table has no normal-file column to anchor first-row-id assignment, and every commit then fails with "This is a bug, blobStart ... should be less than start".
This adds a combined check: once any dedicated (BLOB or VECTOR) column exists, at least one column must be stored in neither dedicated kind, rejecting the schema up front instead of at commit time.
Tests
Added
SchemaValidationTest.testAllDedicatedColumnsSchemaValidation, which pins that a data-evolution schema with only a BLOB and a VECTOR column is rejected at validation with "Table with BLOB or VECTOR type column must have other normal columns."API and Format
No.
Documentation
No.