[core] Handle null merge result in first-row changelog wrapper - #10222
Open
LuciferYang wants to merge 2 commits into
Open
LuciferYang wants to merge 2 commits into
LuciferYang wants to merge 2 commits into
Conversation
With ignore-delete configured, 0.7- tables could persist lone retract records into data files; a merge group consisting solely of such records leaves FirstRowMergeFunction.getResult() null, and FirstRowMergeFunctionWrapper dereferenced it for the contains lookup — every compaction of such a key crashed with a NullPointerException. Return the empty result before the lookup when the merge result is null. Assisted-by: GLM-5.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
With ignore-delete configured, 0.7- tables could persist lone retract records into data files, so a first-row merge group consisting solely of such records leaves
FirstRowMergeFunction.getResult()null.FirstRowMergeFunctionWrapper.getResult()then dereferenced that null atcontains.test(result.key()), so every compaction of such a key crashed with aNullPointerException.This returns the empty result before the contains lookup when the merge result is null, matching the existing "nothing to emit" path.
Tests
Added
testFirstRowAllRetractRecordsWithIgnoreDeleteinLookupChangelogMergeFunctionWrapperTest: with ignore-delete, a merge group of only DELETE records now yields an emptyChangelogResult(null result, no changelog) instead of an NPE.API and Format
No.
Documentation
No.