Conversation
S3FileIO mirrors the hyphenated access-key and secret-key options to the dotted keys read by S3A, but not the session token. s3.session-token was rewritten to fs.s3a.session-token, which S3A never reads, so temporary credentials were signed without their token. Mirror it like its siblings and document the option in the S3 filesystem docs. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #10227
S3FileIOmirrors hyphenatedaccess-key/secret-keyto the dotted S3A keys, but not the session token.s3.session-tokenbecamefs.s3a.session-token, which S3A never reads, so temporary STS credentials passed via Flink/Spark/Hive catalog options were signed without the token (403).{"fs.s3a.session-token", "fs.s3a.session.token"}toMIRRORED_CONFIG_KEYS; precedence matches the existing mirrors. Dotteds3.session.tokenis unaffected.s3.session-token([python] Support S3 options in filesystem catalog #7712).s3.session-tokenin the S3 section offilesystems.mdx.Tests
S3FileIOConfigTest:testHyphenSessionTokenIsMirrored(conf key plus resolvedAwsSessionCredentials),testDotSessionTokenIsKept.testHyphenSessionTokenIsMirroredfails (fs.s3a.session.tokenis null).mvn -pl paimon-filesystems/paimon-s3-impl clean installgreen on JDK 11 (S3FileIOConfigTest2/2, spotless/checkstyle); Docker-based MinIO tests not run locally.