Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes?
Add a backward-compatible structured form for per-column Hadoop configuration keys. Each UTF-8 path component is encoded independently, so the valid paths
["a.b"]and["a", "b"]no longer collapse to the same"a.b"identity.The PR adds:
ColumnConfigParserString[]path overloads for Bloom-filter and statistics propertiesParquetOutputFormatsetters for those structured pathsLegacy dot-string keys continue to work. Structured overrides are applied afterward, so callers can opt into unambiguous paths without a compatibility break. This does not change the Parquet file format.
Why is this needed?
Per-column configuration currently passes a flattened string into
ColumnPath.fromDotString. A top-level field literally nameda.bis therefore indistinguishable from nested fieldbundera; configuration intended for one column can be applied to the other. The issue is datatype-independent.TDD verification
The first commit adds the reproduction before production changes. On
master, it fails because the top-level["a.b"]override is ignored. The second commit adds the structured-path implementation.Final verification:
TestParquetProperties: 11 tests passedTestParquetWriter: 32 tests passedTestColumnConfigParser: 1 test passedFixes #3832