Skip to content

Show the error of a deployment on its own lines in bref deployments:logs #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnapoli merged 1 commit into from
Sep 28, 2026
Merged

Show the error of a deployment on its own lines in bref deployments:logs #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Commands/DeploymentsLogs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,12 @@ protected function show(InputInterface $input, OutputInterface $output): int
foreach ($logs as $log) {
$output->writeln($log['line'], OutputInterface::OUTPUT_RAW);
}
$summary = "Deployment #$id: {$deployment['message']}";
$stderr = $this->stderr($output);
$stderr->writeln("Deployment #$id: {$deployment['message']}", OutputInterface::OUTPUT_RAW);
// On its own lines, as `bref deploy` shows it: it can span several lines, and ends with a hint for known errors
if ($deployment['error_message']) {
$summary .= " ({$deployment['error_message']})";
$stderr->writeln(['', $deployment['error_message']], OutputInterface::OUTPUT_RAW);
}
$this->stderr($output)->writeln($summary, OutputInterface::OUTPUT_RAW);

return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Commands/DeploymentsLogsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,6 @@ public function test_agents_get_the_logs_as_text_without_colors(): void

$this->assertSame(0, $tester->getStatusCode(), $tester->getDisplay());
$this->assertSame("✔ Packaged\nUPDATE_FAILED AWS::Lambda::Function\n", $tester->getDisplay());
$this->assertSame("Deployment #25: failed (The CloudFormation stack failed to update)\n", $tester->getErrorOutput());
$this->assertSame("Deployment #25: failed\n\nThe CloudFormation stack failed to update\n", $tester->getErrorOutput());
}
}
Loading