Conversation
markstory
reviewed
Oct 4, 2026
Comment on lines
+567
to
+572
| Any feature that needs to discover PHP attributes at runtime can use | ||
| `AttributeResolver`. For event subscriptions, use CakePHP's built-in | ||
| [`#[EventListener]` attribute and registration APIs](events#registering-listeners-with-attributes). | ||
| The example below illustrates how to build a custom integration instead: it | ||
| finds methods tagged with a hypothetical `#[ListensTo]` attribute and registers | ||
| them as event listeners: |
Member
There was a problem hiding this comment.
Should this example be changed now? With EventListener I would hope developers don't do this anymore. Perhaps the example could use TracingSpan as the hypothetical example?
|
|
||
| #### Multiple Events and Priorities | ||
|
|
||
| The attribute is repeatable, so a method or class can subscribe to multiple |
Member
There was a problem hiding this comment.
Suggested change
| The attribute is repeatable, so a method or class can subscribe to multiple | |
| The `EventListener` attribute is repeatable, so a method or class can subscribe to multiple |
Comment on lines
+629
to
+630
| `EventManagerInterface` also raises this exception, including the attribute's | ||
| source location. Abstract classes, interfaces, and traits are skipped. |
Member
There was a problem hiding this comment.
Should be clarify that while abstract classes/interfaces/traits are skipped the implementations will not be skipped?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the attribute-based event listeners introduced in cakephp/cakephp#19469 for CakePHP 6.0.
The Events guide now covers method- and class-level attributes, repeatable subscriptions, callable resolution, priorities, discovery and registration, constructor dependency injection, named event managers, and registration errors and deduplication. Listener registration is organized into listener classes, attribute-based listeners, and anonymous listeners. The Attribute Resolver and 6.0 migration guides link to the new section.
Validation: