refactor(replay): move test outcomes and support into replay-port - #3024
Conversation
|
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 22 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
Reviewed at 1dbac80. The moves look right, but the PR adds a third copy of a test helper.
CI: the Smoke Tests jobs are still queued or running, with no failures yet. They do not exercise this package. This PR stacks on #3022, which was rebased, and now has conflicts with it. Please rebase. |
1dbac80 to
c36c940
Compare
|
This is a follow-up to the earlier review at 1dbac80 (#3024 (comment)). At c36c940 the request from that round is still open.
The rest of the move (9 files) was reviewed in the prior round and the range-diff shows no content change there, so that part is not re-checked here. Smoke Tests is the only non-passing check and is still queued; the prior review already noted it doesn't exercise this package, and this delta only touches replay-port test-support moves and a package.json export reorder, with no daemon boot, CLI, or device-facing route touched, so it reads as unrelated to this change. The Smoke Tests log itself wasn't opened since the job hadn't started. No conflicts are known. Before this can merge, the tmp-dir.fixtures.ts duplication either needs the same fallow-ignore marker as its sibling with a corrected cleanup comment, or needs to import the existing replay-test helper through a new subpath export. |
|
Reviewed at edec4ea. The comment and marker on the test fixture close the item from the earlier review. The rest is a pure move of test outcomes and support into packages/replay-port with import-path rewrites, so this is ready for human review. Not blocking: fallow-baselines/health.json line 579 still names src/daemon/replay/internal/session-test-infrastructure.ts, which no longer exists. Move that entry to packages/replay-port/src/daemon-port/session-test-infrastructure.ts, or drop it if fallow reports nothing there now. CI: Smoke Tests is still queued. This diff does not touch the route it runs. |
edec4ea to
b0948dd
Compare
Summary
Move ten dependency-light replay support files into
@agent-device/replay-port: test infrastructure classification, outcome projection, artifact collection, flag policy, trace writing, report action types, and suggestion ranking. The three paired test suites move with their sources. Daemon replay consumers import the owning package subpaths.This dependent #2663 slice builds on #3022. Production implementations are unchanged; moved tests use kernel response types and a package scratch helper to satisfy the package boundary.
Validation
edec4ea61: freshpnpm install --frozen-lockfile && pnpm build && pnpm check:affected --runpassed;pnpm check:fallow --base origin/mainand the focused runtime-artifacts suite (2 tests) passed.pnpm typecheck, tracked-file layering, eager-closure budgets, lint, and fallow passed.pnpm formatran repository-wide.The remaining daemon replay tree and live
.ad/Maestro characterization are tracked in #2663.